Help needed with the Code

[kartik rathore]

hi, iv been trying to design a bouncing ball program whose code is under but i dont seem to find the problem as its not drawing the ball.

i would really appreciate if any one could make the correctiion to the code for me so that it shows the ball bouncing

thanks

///////////////////////////////////////////////////////////////////////////

import java.awt.BorderLayout;
import Buttons.Button;
import Slider.Slider;
import java.awt.Color;
import java.awt.Dimension;
import java.awt.Graphics;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.swing.JFrame;
import javax.swing.JPanel;
 
 
public class Bounce extends JFrame implements Runnable // main class 
{
    private JPanel p;
  //  private JPanel p1;
    private Color colour;
    private Button b1;
    private Button b2;
    private Button b3;
    private BouncingBallBean.Axis a;
    private Graphics g;
    private Thread t;
    private boolean running;
    private int x=50;
    private int y=50;
    private int dx=2;
    private int dy=2;
    private int width=200;
    private int height=200;
    private int diameter=15;
    private Slider s;
    private int z=0;
 
    public Bounce() // constructor method for teh class
    {
        super();
        super.setBounds(0, 0, 450, 450);  // dimension of the frame
        p=new JPanel();
        p.setPreferredSize(new Dimension(200,200)); // dimension for the panel
        
        b1=new Button(); // initialising the button
        b2=new Button();
        b3=new Button();
        
        b1.setCaption("Up"); // setting the button shapes
        b2.setCaption("Play");
        b3.setCaption("Down");
        
        this.add(b1,BorderLayout.NORTH); // adding the buttons
        this.add(b2,BorderLayout.WEST);
        this.add(b3,BorderLayout.SOUTH);
        
        s=new Slider(); // instantiating the slider
        this.add(s,BorderLayout.EAST); // adding the slider
       this.add(p,BorderLayout.CENTER); // layout for the panel
        /////////////////////////////////
    }
    
    public static void main(String[] args) // main method
    {
       JFrame f=new Bounce();
        f.show(true);
        Thread t=new Thread();
        t.start();
    }
 
  public void run() // threads run method
    {
        while(running)  
       {         
          for(int i=0;i<1000;i++)
            {
              move();
              p.paintComponents(p.getGraphics());
                try {
                    t.sleep(100); 
                    } 
                catch (InterruptedException ex) {
        Logger.getLoggerBounce.class.getName)).logLevel.SEVERE, null, ex);
                }
              System.out.println("The execution of run  Thread ");
           }
        }
     }
    public void start() // threads start method
    {
        running=true;
       t=new Thread(this);
       t.setPriority(Thread.NORM_PRIORITY);
       t.run();
       t.start();
     System.out.println( " The execution of Start method ");
       
    } 
    public void paintComponents(Graphics g) // method to paint
    {
       super.paintComponents(g); 
       System.out.println( " The paint executed times : "+z);
       g.setColor(Color.RED);
       g.fillOval(x, y, diameter,diameter);
       
    }
    public void move()  // method to change the co=ordinates
    {
         x += dx;
      y += dy;
      //System.out.println(" the val of x is :"+x);
      if (x < p.getX())
      {
         x = p.getX();
         dx = -dx;
      }
      if ((x + diameter )>= (p.getX()+width))
      {
          x = (p.getX()+width) - diameter;
         dx = -dx;
      }
      if (y< p.getY())
      {
         y = p.getY();
         dy = -dy;
      }
      if ((y + diameter) >= (p.getY()+height))
      {
         y = (p.getY()+height) - diameter;
         dy = -dy;
      } 
     
    }
}
//////////////////////////////////////////////////////////////////////////
 
// my buttons class
 
import java.awt.*;
import java.io.Serializable;
import javax.swing.*;
 
 
        
public class Button extends JButton implements Serializable
{
    private Color buttonColour;
    private Color textColour;
    private String caption;
    private String a="Up";
    private String b="Play";
    private String c="Down";
    private Graphics g;
   
//  private String shape;
 
public Button()
{
super();
setPreferredSize(new Dimension(50,50));
setBorder(null);
setText("");
caption = "";
}
 
public Button(String acaption)
{
super();
setPreferredSize(new Dimension(50,50));
setBorder(null);
caption = acaption;
}
 
public void paintComponent(Graphics g)
{
            // the if else statement for setting the shapes of the buttons
            
               if (caption.startsWith(a))     // top button shape
{
  super.paintComponent(g);
  g.setColor(buttonColour);
    int d=40;
                    int e=44;
                    setText("");
                    setToolTipText(" UP ");
                 do
                   { 
                    for(int f=4;f<24;f++)
                    {
                      g.drawLine(f, d, e, d);
                      e--;  
                      d--;
                      g.setColor(textColour); 
                    }
                   }while(e>35);
               }
                else if(caption.startsWith(c))  // Bottom button shape
{
  super.paintComponent(g);
                  g.setColor(buttonColour);
                  int j=10;
                  int z=44;
                  setToolTipText(" Down ");
                  do
                    { 
                     for(int i=4;i<24;i++)
                     {
                      g.drawLine(i, j, z, j);
                      j++;
                      z--;
                      g.setColor(textColour);
                      setText("");
                     }
                    }while(z>30);
                }
        else if(caption.startsWith(b))  // middle button shape for play
                 {
                  super.paintComponent(g);
                  g.setColor(buttonColour);
                  g.fillRect(5, 5, 40, 40);    // filling a rectangle 
                  g.setColor(textColour);
                  setText("");
                  setToolTipText(" Play or Pause ");
                }
                
}
public void setButtonColour(Color acolour)
{
buttonColour = acolour;
}
 
public void setTextColour(Color acolour)
{
textColour = acolour;
}
 
public void setCaption(String acaption)
{
caption = acaption;
}
     /*   public void setShape(String ashape)
        {
            shape=ashape;
            
             // the if else statement for setting the shapes of the buttons
            
               if (shape.startsWith(a))     // top button shape
{
  super.paintComponent(g);
  g.setColor(buttonColour);
    int d=40;
                    int e=44;
                    setText("");
                 do
                   { 
                    for(int f=4;f<24;f++)
                    {
                      g.drawLine(f, d, e, d);
                      e--;  
                      d--;
                      g.setColor(textColour); 
                    }
                   }while(e>35);
               }
                else if(shape.startsWith(c))  // Bottom button shape
{
  super.paintComponent(g);
                  g.setColor(buttonColour);
                  int j=10;
                  int z=44;
                  do
                    { 
                     for(int i=4;i<24;i++)
                     {
                      g.drawLine(i, j, z, j);
                      j++;
                      z--;
                      g.setColor(textColour);
                      setText("");
                     }
                    }while(z>30);
                }
        else if(shape.startsWith(b))  // middle button shape for play
                 {
                  super.paintComponent(g);
                  g.setColor(buttonColour);
                  g.fillRect(5, 5, 40, 40);    // filling a rectangle 
                  g.setColor(textColour);
                  setText("");
                }
                
        } */
} // End of class
 
///////////////////////////////////////////////////////////////////////////
 // my slider class /////
 
 
import java.io.Serializable;
import javax.swing.JSlider;
import javax.swing.SwingConstants;
 
 
 
 
public class Slider extends JSlider implements Serializable
{
    private int a=600;
    private int b=0;
    private int c=150;
    private int d=50;
    
    public Slider()
    {
      super();
      setOrientation(SwingConstants.VERTICAL ); // orientation
      setPaintTicks(true);                // ticks display
      setPaintLabels(true);              // numbers as labels for ticks
      setMaximum(a);                 // maximum value of the slider
      setMinimum(b);                   // minimum value of the slider
      setMajorTickSpacing(c);        //  major tick spacing
      setMinorTickspacing(d);           // minimum tick spacing
      setInverted(false);               // inversion diaplay setting
    }
    public void setMajorTickSpacing(int value)
    {
        super.setMajorTickSpacing(c);
        super.setPaintTicks(true);
    }
    public void setMinorTickspacing(int value)
    {
        super.setMinorTickSpacing(d);
        super.setPaintTicks(true);
    }
    public void setMaximum(int maximum)
    {
       super.setMaximum(a); 
       super.setPaintTicks(true);
    }
    public void setMinimum(int minimum)
    {
       super.setMinimum(b);
       super.setPaintTicks(true);
    }
}
///////////////////////////////////////////////////////////////////////////

[MG Edited for code tags]

[ November 02, 2008: Message edited by: Maneesh Godbole ]

[ November 02, 2008: Message edited by: kartik rathore ]
[ November 02, 2008: Message edited by: Bear Bibeault ]

[Maneesh Godbole]

Kartik,

A few things:
1) Ease Up
2) Use Code Tags. I have edited your original post. As you can see it is much easier for everyone to read as it is properly indented.

I noticed you have a very similar post here.
Incidently in this post too, Pete Stein had requested you to Ease Up and use the Code Tags.
Craig Wood had been most helpful there by posting a workable code.
Did you try it out? Did it work?

[kartik rathore]

hi
i did try the code that was posted by craig wood but it didnt seem to work so i tried to make sum changes into it and still i just dnt seem to have the graphics working in the program at all ....

[Ernest Friedman-Hill]

Well, one hint is that you don't call "paintComponent()" yourself. You call "repaint" and let Java call paintComponent() for you -- as any working examples you've looked at would undoubtedly show.