Can someone tell me why?

[marcus conway]

Hello,

Can someone tell me why--after i create a cube--it display 'enter test operation' twice?

import java.util.*;
 
//Constructs new cube
 
 
public class Cube {
 
        private char [] faces;
        private int faceIndex;
        private String id;
        private Random rnd;
        public Cube(){
                faceIndex = faceIndex;
                }
 
 
        //1.Constructor that initializes id
        //2.Initializes faces array using the first 6
        //characters of faceValues
        //3.Sets faceIndex to 0
        //4.Creates rnd object
 
 
        public Cube (String id, String faceValues){
                this.id = id;
        char[] faces = new char[6];
                for (int i =0; i <6; i++){
                        faces[i]=faceValues.charAt(i);
                }
                faceIndex = 0;
                rnd = new Random(0);
 
        }
       
        //Returns the current face character
        public String toString(){
                String s = ""+ faces[faceIndex];
                return s.toUpperCase();
        }
        //Returns the current face character
        public char getFace(){
 
                return faces[faceIndex];
 
        }
        //Returns the case-sensitive id for this cube
        public String getID(){
                return  id;
        }
        //Returns a numeric value associated with the currently
        //displayed face character
        public int getValue(){
                int val = 0;
                switch(getFace()){
                case 'a':
                case 'e':
                case 'i':
                case 'o':
                case 'u':
                case 'l':
                case 'n':
                case 'r':
                case 's':
                case 't':
                        val = 1;
                case 'd':
                case 'g':
                        val = 2;
                case 'b':
                case 'c':
                case 'm':
                case 'p':
                        val = 3;
                case 'f':
                case 'h':
                case 'v':
                case 'w':
                case 'y':
                        val = 4;
                case 'k':
                        val = 5;
                case 'j':
                case 'x':
                        val = 8;
                default:
                        val = 10;
 
                }
                return val;
        }
        //Returns true if the parameter cube c is also displaying the same
        //face character
        public boolean equals (Cube c){
                return (this.faceIndex == c.faceIndex);
        }
        //Returns positive if c's face value is lower.
        //Returns zero if c's face value is the same.
        //Returns negative if c's face value is greater.
        public int compareTo (Cube c){  //Method refers to equals method
                int compareVal = 0;
                if (this.faceIndex < c.faceIndex){
                        compareVal = 1;
                }
                else if (this.faceIndex == c.faceIndex){
                        compareVal = 0;
                }
                else if (this.faceIndex > c.faceIndex){
                        compareVal = -1;
                }
               
                return compareVal;
        }
        //Uses rnd exactly once to generate a new, valid faceIndex value
        public void roll(){
                rnd = new Random(5);
        }
 
}

import java.util.Scanner;
public class CubeTester {
private Cube c1;
private Cube c2;
private Cube c3;
public static void main(String[] args) {
//Made a tester cube so I can access the
//Cube class
Scanner s = new Scanner (System.in);
CubeTester ct = new CubeTester(s);
//Prompt user for test operation as long as
//doOperation() evaluates to true
String op;
boolean go = true;
boolean notInVal = true;
do{
System.out.print("*** Enter test operation: ");
op = s.nextLine();
String rest = op.trim();//Remove blanks at either end
String token = " ";//Word in String
int index;
while(rest.length() > 0){//Location of a blank
index = rest.indexOf(' ');
if (index == -1){
token = rest;
rest = "";
}
else {
//Found a blank
token = rest.substring(0, index);//Get token, overloaded
rest = rest.substring(index);//Rest of message, overloaded
rest = rest.trim();//Remove excess blanks again
}
}
go = ct.doOperation(op);

}while (go);
}
public  CubeTester (Scanner keyboard){
//Constructor invoked from main()
c1 = createCube(keyboard);
//c2 = createCube(keyboard);
//c3 = createCube(keyboard);
System.out.println("Creating three cubes");

}
private  Cube createCube (Scanner keyboard){
//Prompts the user to enter String id
System.out.println("Enter cube id: ");
// I want to set this as String id in the Cube method
String id = keyboard.next();
//Then ask for the String faceValue
System.out.println("Enter 6 letters for faces of the cube: ");
//I want to set this a the String faceValue in the Cube method
String faceVal = keyboard.next();
if(faceVal.length() < 0 || faceVal.length() > 6){
do{
System.out.println("Enter 6 letters for faces of the cube: ");
}while (!(Character.isLetter(' ')));
 
}
Cube cube = new Cube (id, faceVal);
return cube ;
}
 
public boolean doOperation (String operation){
//Checks the first word (case insensitive) in operation to see if it is roll
//or info, and calls the appropriate helper method.
//If input is not a equal "roll", display message
String rest = operation.trim();
String token = " ";
int index;
 
while(rest.length() > 0){//Location of a blank
index = rest.indexOf(' ');
if (index == -1){
//No more blanks
token = rest;
rest = "";
}
else {
//Found a blank
token = rest.substring(0, index);//Get token, overloaded
rest = rest.substring(index);//Rest of message, overloaded
rest = rest.trim();//Remove excess blanks again
 
}
//System.out.println(token); //Display token
 
 
if (operation.equals("roll")){
//doOperation doRoll = new doOperation();
String op = "roll";
doRoll(op);
return true;
 
}
else if (operation.equals("info")){
String op = "info";
doInfo(op);
return true;
 
}
else if (operation.equals("quit")){
String op = "quit";
return false;
}
//else if(){
//System.out.println("Invalid operation");
//return true;
//}
}return true;
}
 
private void doRoll(String operation){
//This method is invoked from the doOperation() method and processes operation
//and performs the task of using one of the overloaded roll() methods with
//appropriate parameters
String index;
int i = operation.indexOf(" ");
if (i == -1) {
index = operation.trim();
}
else {
index = operation.substring(0,i).trim();
}
Cube c =  getCube(index);
c.getID();
//If times is a character, use roll(Cube c, char) method()
if (Character.isDigit(operation.charAt(0))){
roll(c, 3);
}
else {
roll(c, 'f');
}
 
//If user inputs a non-valid cubeId, print this error
 if(!(c.equals(c))){
System.out.println("Invalid cube id");
}
else{
System.out.println("Insufficient information for roll operation");
}
}
 
private void doInfo(String operation){
if(operation.equals("info")){
printInfo(c1);
printInfo(c2);
printInfo(c3);
}
else if(operation.equals("info max")){
printLargest();
}
//else if(operation.equals(){
//print info of cube name
//printInfo(//cube name)
//}
 
}
 
private Cube getCube (String id){
//Returns c1, c2, or c3 if parameter id
//matches the id of one of the three cubes
Cube testCube = new Cube();
if(id.equals(c1.getID())){
testCube= c1;
}
else if(id.equals(c2.getID())){
testCube= c2;
}
else if(id.equals(c3.getID())){
testCube =  c3;
}
else if(id.equals(null)){
testCube = null;
}
return testCube;
}
 
private void roll(Cube c, int times){
//Display that the cube is rolling x amount of times
System.out.println("Rolling "+ c.getID()+ " "+ times+" times");
//Initiate roll method on Cube c, x amount of times
roll(c, times);
//Display cubeId and the letter it's showing by
//calling the getFace() and getValue() methods
System.out.println("Cube "+ c.getID() + " is now showing "+
c.getFace() +" (value = "+ c.getValue() + ")");
 
}
private void roll(Cube c, char face){
int count = 0;
do{
c.roll();
count += 1;
}while((count != 100) ||(!(c.getFace()==face)));
//Display the number of times Cube c was rolled
//and the final face letter for Cube c
System.out.println(c.getID() + " was rolled "+ count+" times " +
"to obtain face letter " + c.toString());
}
 
private void printInfo(Cube c){
System.out.println("Information on Cube "+ c.getID());
System.out.println("Face Letter: " + c.getFace());
System.out.println("Face Value: " + c.getValue());
}
private void printLargest(){
 
//If c1 value is greater than c2 and c3, c1 has
//the largest value
if( (c1.compareTo(c2) == -1)&&(c1.compareTo(c3) == -1) ){
System.out.println("Cube with the largest value: " + c1.getID());
}//If c2 value is greater than c2 and c3, c3 has
//the largest value
else if( (c2.compareTo(c1) == -1)&&(c2.compareTo(c3) == -1) ){
System.out.println("Cube with the largest value: " + c2.getID());
}//If c3 value is greater than c2 and c3, c3 has
//the largest value
else if( (c3.compareTo(c2) == -1)&&(c3.compareTo(c2) == -1) ){
System.out.println("Cube with the largest value: " + c3.getID());
}
 
}
 
}

[ November 17, 2008: Message edited by: Bear Bibeault ]

[Ulf Dittmer]

That's in a loop, so I'd assume that the loop is executed repeatedly. Check whether the loop termination condition works as you expect it to.

By the way, I'm almost positive that the getValue method does not work as you expect it to work. You may want to read about the "switch" statement, and what happens once one of the cases is matched.

Lastly, in the future UseAMeaningfulSubjectLine that states what the problem is.
[ November 17, 2008: Message edited by: Ulf Dittmer ]

[marcus conway]

Originally posted by Ulf Dittmer:
That's in a loop, so I'd assume that the loop is executed repeatedly. Check whether the loop termination condition works as you expect it to.

By the way, I'm almost positive that the getValue method does not work as you expect it to work. You may want to read about the "switch" statement, and what happens once one of the cases is matched.

Lastly, in the future UseAMeaningfulSubjectLine that states what the problem is.

[ November 17, 2008: Message edited by: Ulf Dittmer ]

Is it because I'm using the getValue() switch statement on chars?

Thanks for your help

[Ulf Dittmer]

No, chars work fine in switch statements. Ask yourself this: Suppose getFace() returns 't', causing "val = 1;" to be executed. Now, what is the next statement that gets executed? And consequently, which value of "val" will be returned from the method?

[marcus conway]

Originally posted by Ulf Dittmer:
No, chars work fine in switch statements. Ask yourself this: Suppose getFace() returns 't', causing "val = 1;" to be executed. Now, what is the next statement that gets executed? And consequently, which value of "val" will be returned from the method?

how bout this?

 
        public int getValue(){
                int val = 0;
                switch(getFace()){
                case 'a':
                case 'e':
                case 'i':
                case 'o':
                case 'u':
                case 'l':
                case 'n':
                case 'r':
                case 's':
                case 't':
                        val = 1;
                case 'd':
                case 'g':
                        val = 2;
                case 'b':
                case 'c':
                case 'm':
                case 'p':
                        val = 3;
                case 'f':
                case 'h':
                case 'v':
                case 'w':
                case 'y':
                        val = 4;
                case 'k':
                        val = 5;
                case 'j':
                case 'x':
                        val = 8;
                case 'q' :
                case 'z' :
                        val = 10;
                        
 
                }
                return val;
        }

[Joanne Neal]

I think Ulf was hinting you should read about the break keyword in a switch statement

[Bill Shirley]

FAQ: Use A Meaningful Subject Line

welcome,

history note:
the good ol' switch statement comes down to us from the C programming language, the first step up from assembly programming, and as such still requires a little bit more work to do what you want it to,

(i.e. check on the break keyword as suggested above - and/or trace through the debugger and see how it's executing)
[ November 17, 2008: Message edited by: Bill Shirley ]