What does this code do or not do? What are you expecting it to do?

and how can you tell if this array is sorted or not? Just by eyeballing it, it would appear you have an array of 5 ints, but since you never set any of the elements, they're all 0.

There are only two hard things in computer science: cache invalidation, naming things, and off-by-one errors

I doubt you can do it with just one single loop.
Consider an array {4, 7, 3}. After not-swapping 4 and 7, the index moves one forward and you swap 7 and 3. The array is then {4, 3, 7}. Doesn't look sorted, does it?

As the other boys said, it's hard to implement a sorting algorithm that takes O(n) time. But there are two algorithms that try to do that: Bucket Sort and Radix Sort. If you're not concerned about time complexity, you should try Insertion Sort, Bubble Sort or Quicksort.

The code actually looks like it implements one iteration of a bubble sort -- the only guarantee is that the largest item is last. Implement the other iterations, and it will be done...

As this looks like an assignment, once you have sorted ( ) this problem, consider how you would sort, say, a list of integers, without having to write the code to do it from scratch....have a look at the Collections class.....

Rob Prime wrote:I doubt you can do it with just one single loop.
Consider an array {4, 7, 3}. After not-swapping 4 and 7, the index moves one forward and you swap 7 and 3. The array is then {4, 3, 7}. Doesn't look sorted, does it?

hi guys, im new here and new to java. based on what rob said, i think you should add 1 more loop to check the reverse way.

eg : you got {4,7,3}

currently it will sort to {4,3,7}.

then you check from reverse,

i think you will get

{3,4,7}

because 7 and 3 will not swap, but 3 and 4 will.

then add 1 more loop to check both sides of array[n], to make sure that its in the right spot.

im still new, but this is my input.

javaNoob me = new javaNoob();<br />String i = "i";<br />i += "love java!";

I simply don't see what's the point of a boolean "swapped". Since it's not declared in the method I'm assuming it's a private/public field of the class. If so, why are you declaring outside the method?