send files over the socket

[Bobes Calin]

I have a litle problem (i think) on my client server application. The aplication sends one file and not all that i give it to it.

here is the code for the server....

   
public class FileServer 
{
	private ServerSocket server = null;
	private Socket client = null;
	private DataInputStream in = null;
	private DataOutputStream out = null;
	private FileOutputStream fos = null;
	
	public FileServer()
	{
		listenSocket();
		receiveFileFromClient(in);		
	}
	
	public void listenSocket()
	{
		try
		{
			server = new ServerSocket(4321);
			System.out.println("Waiting for a client...");
		}
		catch (IOException e) 
		{
			System.out.println("Could not listen on port 4321");
			e.printStackTrace();
		}
		
		try
		{
			client = server.accept();
			System.out.println("The server and client are connected!");
			in = new DataInputStream(new BufferedInputStream(client.getInputStream()));
			out = new DataOutputStream(new BufferedOutputStream(client.getOutputStream()));
		}
		catch (IOException e) 
		{
			System.out.println("Accept failed: 4321");
			System.exit(-1);
		}
	}
	
	public void receiveFileFromClient(DataInputStream in)
	{		
		try
		{			
			byte[] buf=new byte[512];
			int len;
			int totsize=0;				
			
			String action = in.readUTF().trim();
			System.out.println("action "+action);
			long fileLong = new Long(in.readLong());
			//System.out.println("long value: "+fileLong.toString());
			
			
			String fname=in.readUTF();
			System.out.println("server : file name: "+fname);
			String prefix=fname.substring(0,fname.lastIndexOf('.')).trim();
			String suffix=fname.substring(fname.lastIndexOf('.'),fname.length()).trim();
			
			String file = prefix + suffix;			
			
			//long length = in.readLong();	
			
			fos=new FileOutputStream(file);			
			byte[] fileBuff = new byte[(int)fileLong];					
			while((len = in.read(fileBuff)) > 0)
			{					
				totsize=totsize+len;
				fos.write(fileBuff,0,len);
			}
						
			fos.flush();
			
			DecimalFormat df= new DecimalFormat("#0.00 MB");
			System.out.println("bytes read: " + df.format(totsize/1024/1024d));			
		}
		catch (Exception e) 
		{
			e.printStackTrace();
		}		
	}
	
	protected void finalize()
	{
		//Clean up 
		try
		{
			fos.close();
			out.close();
			in.close();
			server.close();
		}
		catch (IOException e) 
		{
			System.out.println("Could not close.");
			System.exit(-1);
		}
	}
	
	public static void main(String[] args)
	{
		new FileServer();
	}
	
}
 

and for the client....

 
public class FileClient 
{
	private Socket socket = null;
	private DataInputStream in = null;
	private DataOutputStream out = null;	
	private FileInputStream fis = null;
	
	public FileClient()
	{
		connectToServer();
		sendFileToServer(out);		
	}
	
	public void connectToServer()
	{		
		try 
		{
			socket = new Socket("127.0.0.1", 4321);
			in = new DataInputStream(new BufferedInputStream(socket.getInputStream()));
			out = new DataOutputStream(new BufferedOutputStream(socket.getOutputStream()));
		}
		catch (UnknownHostException e) 
		{
			System.out.println("Unknown host: 127.0.0.1");
			e.printStackTrace();
		}
		catch (IOException e) 
		{
			System.out.println("No I/O");
			e.printStackTrace();
		}
	}
	
	public void sendFileToServer(DataOutputStream out)
	{
		try
		{					
			File[] files = new File[]{new File("/home/calin/Desktop/files/temp.flv"),
							  		  new File("/home/calin/Desktop/files/temp.txt"), 
							  		  new File("/home/calin/Desktop/files/A.txt"),
							  		  new File("/home/calin/Desktop/files/B.txt")};			
			
			for (int i = 0; i < files.length; i++)
			{
				byte[] buf=new byte[512];
				int len;				
		
				System.out.println("client : file name: " + files[i].getName());
		
				String action = in.readUTF().trim();
				System.out.println("action "+action);				
				
				Long fileLong = new Long(files[i].length());		
				out.writeUTF("get");
				out.writeLong(fileLong.longValue());
				out.flush();				
				
				// send the filename
				out.writeUTF(files[i].getName());			
				
				out.writeLong(files[i].length());
				fis=new FileInputStream(files[i]);
			
				while((len=fis.read(buf))!=-1)
				{					
					out.write(buf,0,len);
				}
			
				out.flush();
			}
		}
		catch (IOException e) 
		{			
			e.printStackTrace();
		}		
	}
	
	protected void finalize()
	{
		//Clean up 
		try
		{			
			fis.close();
			out.close();
			in.close();
			socket.close();
		}
		catch (IOException e) 
		{
			System.out.println("Could not close.");
			System.exit(-1);
		}
	}
	
	public static void main(String[] args)
	{
		new FileClient();
	}
	
}
   

Can anybody show me how to send all the files? Thank you!

Calin

[Ernest Friedman-Hill]

Looks like your client should send all the files, but your server will only read one. "receiveFileFromClient()" should be called in a loop, right?

[Bobes Calin]

yes the server reads only the fisrt file. How can i do the loop? on what criteria?

Thank you!

Calin

[Ernest Friedman-Hill]

Maybe the client could send the number of files to expect first, and then you could just use a "for" loop.

[Bobes Calin]

I tried to send the number of files that are in the File[] array

in the client sendFileToServer()

   
public void sendFileToServer(DataOutputStream out)
	{
		try
		{			
			File[] files = new File[]{new File("/home/calin/Desktop/files/temp.flv"),
							  		  new File("/home/calin/Desktop/files/temp.txt"), 
							  		  new File("/home/calin/Desktop/files/A.txt"),
							  		  new File("/home/calin/Desktop/files/B.txt")};	
			int fileNumber = files.length;
			
			for (int i = 0; i < files.length; i++)
			{
				byte[] buf=new byte[512];
				int len;				
		
				System.out.println("client : file name: " + files[i].getName());
				
				// send the number of files to the server
				out.writeInt(fileNumber);
				out.flush();					
						
				out.writeUTF("get");
				out.writeLong(files[i].length());
				out.flush();				
				
				// send the filename
				out.writeUTF(files[i].getName());			
				
                                // send the file length
				out.writeLong(files[i].length());
				fis=new FileInputStream(files[i]);
			
				while((len=fis.read(buf))!=-1)
				{					
					out.write(buf,0,len);
				}
			
				out.flush();
			}
		}
		catch (IOException e) 
		{			
			e.printStackTrace();
		}		
	}
 

and the server receiveFileFromClient()

   
public void receiveFileFromClient(DataInputStream in)
	{		
		try
		{	for(int i = 0; i < in.readInt(); i++)
			{
			     byte[] buf=new byte[512];
			     int len;
			     int totsize=0;					
			
			    String action = in.readUTF().trim();
			    System.out.println("action "+action);
			    long fileLong = new Long(in.readLong());			
			
			   String fname=in.readUTF();
			   System.out.println("server : file name: "+fname);
			   String prefix=fname.substring(0,fname.lastIndexOf('.')).trim();
			   String suffix=fname.substring(fname.lastIndexOf('.'),fname.length()).trim();
			
			   String file = prefix + suffix;				
			
			   fos=new FileOutputStream(file);			
			   byte[] fileBuff = new byte[(int)fileLong];					
			   while((len = in.read(fileBuff)) > 0)
			   {					
				 totsize=totsize+len;
				 fos.write(fileBuff,0,len);
			   }
						
			   fos.flush();
			
			   DecimalFormat df= new DecimalFormat("#0.00 MB");
			   System.out.println("bytes read: " + df.format(totsize/1024/1024d));	
			}
		}
		catch (Exception e) 
		{
			e.printStackTrace();
		}		
	}
 

but hte same thing, only the first file is send.

[Ernest Friedman-Hill]

You want to read the file count from the socket only once, and store it in a variable, and then use that variable in the for loop. If you do this:

for(int i = 0; i < in.readInt(); i++) 

then the count gets changed to some random value each time through the loop, and that isn't good!

[Bobes Calin]

yes you are right with the count.

   
// send the number of files to the server   
int fileNumber = files.length;           
out.writeInt(fileNumber);  
out.flush();  

i put it out from the loop and initialized with a with an int value on the server

   
int files = in.readInt();
		   
for(int i = 0; i < files; i++) 
... 
 

but the same thing only one file is copied