Can Somebody please help me with my code?

[David Barry]

This is the code for the random Password generator I am trying to write. If anybody runs this code, they will see the problems I am having. Can somebody please help me see what is wrong with this code? Thanks in advance.

/**
 * This program generates random passwords based on the user selecting the character set and the length. 
 *  
 * 
 * @author John D. Barry 
 * @date   January 26, 2009
 */
import java.util.Scanner;
import java.util.Random;
public class Password
{
    public static void main(String [] args)
    {
        
        
        Scanner in = new Scanner(System.in);
        
        
        
        
        System.out.println("************************************************************************  ");
        System.out.println("*   [1]   Lowercase Letters                                            *  ");                                  
        System.out.println("*   [2]   Lowercase & Uppercase Letters                                * ");
        System.out.println("*   [3]   Lowercase, Uppercase, and Numbers                            * ");
        System.out.println("*   [4]   Quit                                                         * ");
        System.out.println("************************************************************************ ");
        System.out.println();
        System.out.print("Enter your selection:  ");
        int selection = in.nextInt();
        
        System.out.println();

        
        
        
        
        

        
        
        
        
        
        
        
        
        if (selection == 1)
        
        {
            
            
                int randNum = 0;
                Random randNumList = new Random();
                
               while( randNum>=97 && randNum<=122)
               
               randNum = randNumList.nextInt();
               char firstChar = (char)randNum;
               randNum = randNumList.nextInt();
               char secondChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirdChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fifthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char sixthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char seventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eighthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char ninthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char tenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eleventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char twelthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirteenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourteenthChar = (char)randNum;
               

                
               System.out.print("Enter the length of the password: ");
               int length = in.nextInt();
                
                if(length == 1)
                {
                    System.out.println(firstChar);
                }
                else if(length == 2)
                {
                    System.out.println(firstChar + secondChar);
                }
                else if(length == 3)
                {
                    System.out.println(firstChar + secondChar + thirdChar);
                }
                else if(length == 4)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar);
                }
                else if(length == 5)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + fifthChar);
                }
                else if(length == 6)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar);
                }
                else if(length == 7)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar);
                }
                else if(length == 8)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar);
                }
                else if(length == 9)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar);
                }
                else if(length == 10)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar);
                }
                else if(length == 11)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar);
                }
                else if(length == 12)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar);
                }
                else if(length == 13)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar);
                }
                else if(length == 14)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar + fourteenthChar);
                }

                }
            
            
            
           
            
            
            
            
           else if(selection == 2)
           
           {
               int randNum = 0;
               Random randNumList = new Random();
           
               while( (randNum>=65 && randNum<=90) && (randNum>=97 && randNum<=122))
            
               randNum = randNumList.nextInt();
               char firstChar = (char)randNum;
               randNum = randNumList.nextInt();
               char secondChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirdChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fifthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char sixthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char seventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eighthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char ninthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char tenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eleventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char twelthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirteenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourteenthChar = (char)randNum;
               
               System.out.print("Enter the length of the password: ");
               int length = in.nextInt();
                
                if(length == 1)
                {
                    System.out.println(firstChar);
                }
                else if(length == 2)
                {
                    System.out.println(firstChar + secondChar);
                }
                else if(length == 3)
                {
                    System.out.println(firstChar + secondChar + thirdChar);
                }
                else if(length == 4)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar);
                }
                else if(length == 5)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + fifthChar);
                }
                else if(length == 6)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar);
                }
                else if(length == 7)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar);
                }
                else if(length == 8)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar);
                }
                else if(length == 9)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar);
                }
                else if(length == 10)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar);
                }
                else if(length == 11)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar);
                }
                else if(length == 12)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar);
                }
                else if(length == 13)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar);
                }
                else if(length == 14)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar + fourteenthChar);
                }
               
               
            }
            
            else if(selection == 3)
            
            {
               int randNum = 0;
               Random randNumList = new Random();
               
               while( (randNum>=65 && randNum<=90) && (randNum>=97 && randNum<=122) && randNum>=48 && randNum<=57)
            
            
               randNum = randNumList.nextInt();
               char firstChar = (char)randNum;
               randNum = randNumList.nextInt();
               char secondChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirdChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fifthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char sixthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char seventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eighthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char ninthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char tenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char eleventhChar = (char)randNum;
               randNum = randNumList.nextInt();
               char twelthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char thirteenthChar = (char)randNum;
               randNum = randNumList.nextInt();
               char fourteenthChar = (char)randNum;
               
               
               System.out.print("Enter the length of the password: ");
               int length = in.nextInt();
                
                if(length == 1)
                {
                    System.out.println(firstChar);
                }
                else if(length == 2)
                {
                    System.out.println(firstChar + secondChar);
                }
                else if(length == 3)
                {
                    System.out.println(firstChar + secondChar + thirdChar);
                }
                else if(length == 4)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar);
                }
                else if(length == 5)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + fifthChar);
                }
                else if(length == 6)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar);
                }
                else if(length == 7)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar);
                }
                else if(length == 8)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar);
                }
                else if(length == 9)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar);
                }
                else if(length == 10)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar);
                }
                else if(length == 11)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar);
                }
                else if(length == 12)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar);
                }
                else if(length == 13)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar);
                }
                else if(length == 14)
                {
                    System.out.println(firstChar + secondChar + thirdChar + fourthChar + sixthChar + seventhChar + eighthChar + ninthChar + tenthChar + eleventhChar + twelthChar + thirteenthChar + fourteenthChar);
                }
               
               
               
               
            
            
            
        }
        
        else if(selection == 4)
        
        {
            System.out.println("Thanks for trying. Remember to create hard to guess passwords. ");
        }
            
        }
    }

[fred rosenberger]

Hi David, and welcome to the JavaRanch!

We're glad you're here, and folks are delighted to help. However, there are some things you can do to make life easier for others to help you.

Please take a few minutes and browse around this page. It will give you some tips on the best way to present your problem.

One of which is to actually tell other what the problem is. If you say "I was expecting A, but got B", often someone can skim your code and focus in on the problem. A lot of folks will read your post and say "Too much work to do all that, I'll skip it and move on".

The other main thing is to please use the 'code' tags. there are little buttons that you can use to insert special 'tags' that you then paste your code between. This preserves the formatting and makes it much easier to read.

I'll try and edit your post to have those, but if you could please post exactly what your problem is, you're more likely to get the help you need.

[Balagopal Kannampallil]

Please put your code inside the [code] tag so that it is more readable

[Ankit Garg]

Hi David, welcome to javaranch.

First of all you code has a lot of redundancy. You could have replaced your long code with this type of code

System.out.print("Enter the length of the password: ");
int length = in.nextInt();
for(int i = 0; i < length; i++)
{
     System.out.println( (char)(Math.random()*26 + 97) );
}

to get a similar result. Also when you add char values like this

System.out.println(firstChar + secondChar + thirdChar);

Then they are added as INTs instead of characters. So you should try this

System.out.println(""+firstChar + secondChar + thirdChar);

[fred rosenberger]

to elaborate on Ankit Garg's post...

When java sees something like "firstChar + secondChar + thirdChar" it says

"hmm... what are these things on either side of the '+' character?"

In this case, they are char variables, which java believes are actually numeric values. What does it mean to add two numeric values? you calculate the sum. So, I would expect you are calculating some big sum and printing garbage.

The suggested solution is a little different. Java sees the firs thing is a String (albeit an empty one). It then says "how do I add a String and a number?" The answer is it converts the number to a string, then concatenates them together. if you have a whole series (as in your case), it figures out what to do with the first pair. Then, it takes the result of that (which is a String), and figures it out all over again with the next value, and keeps working its way down the list.