Efficient Try Catch

[Joe Deluca]

Hey everybody!

I was just wondering which is more efficient, a try/catch in the method, or try/catch the actual method. Such as:

try {
doMethod();
}
catch(Exception e) {
return;
}

or

public void doMethod() {
    try {
    //Method Logic
    catch(Exception e) {
    return;
    }
}

What are your thoughts?
Thanks, Joe

[Campbell Ritchie]

It all depends what the method is doing, what sort of Exception it throws, and what you want to do with it. Are you inside a loop which can be repeated when whatever goes wrong has been sorted out? Do you have to close your app if there is an Exception?

But simply writing "return;" in a catch block is very inefficient. The most you will achieve like that is hiding errors; an Exception you know about is not dangerous. An Exception you don't know about, because it is consumed silently, can be very dangerous because you might be calculating "wrong" answers and not know about it. At least print a message so you know what has happened.





And you thought I would say "no 1" or "no 2"!