About for loop of jdk1.5

[kayanaat sidiqui]

Hi all,

I have following code for copying files-

final File dir = new File("abc");
final File[] listOfFiles = dir.listFiles();

for (int i = 0; i < listOfFiles.length; i++) {
   if (listOfFiles[i].isFile()) {
	sourceStream = new FileInputStream("abc/" + listOfFiles[i].getName());
	targetStream = new FileOutputStream("backupFolder/" + listOfFiles[i].getName());
	sourceFileChannel = sourceStream.getChannel();
	targetFileChannel = targetStream.getChannel();
	final long size = sourceFileChannel.size();
	sourceFileChannel.transferTo(0, size, targetFileChannel);
    }
}

It's doing fine. But i am using jdk1.5, so i should use their utility.
Now i want to use for loop like
for(File file : listOfFiles ).
But using this i am unable think that how to take vaue of i for -
sourceStream = new FileInputStream("abc/" + listOfFiles[i].getName());
targetStream = new FileOutputStream("backupFolder/" + listOfFiles[i].getName());

Can you please help me?

[Vijitha Kumara]

kayanaat sidiqui wrote:Now i want to use for loop like
for(File file : listOfFiles ).
But using this i am unable think that how to take vaue of i for -
sourceStream = new FileInputStream("abc/" + listOfFiles[i].getName());

I don't think you need the value of i but the element in the array index(which is referred by i). When you are using new for loop as you mentioned the "file" variable holds the current element of the array (i.e: listOfFiles). So you can directly use that to do what you want to do with it.

[Jesper de Jong]

Please use code tags when you post source code.

[Campbell Ritchie]

Have you tried it?

[kayanaat sidiqui]

Hi Campbell Ritchie/Jesper Young,

I tried the same but getting this error-
ERROR 2009-02-13 14:06:13,272 a.mine.backUpLogFile(SymProductProcessor.java:394) - Channel or stream is still in use, so cann't close..abc\2009-02-13_02-06-13\ abc\warn.log (The system cannot find the path specified)

the code i am using is as follows-

private void backUpLogFile() {
		final DateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd_hh-mm-ss", Locale.US);	
		FileInputStream sourceStream = null; 
		FileOutputStream targetStream = null;
		FileChannel sourceFileChannel = null;
		FileChannel targetFileChannel = null;
		String logBackupFolder = "abc/" + dateFormat.format(new Date());
		final boolean newLogDir = new File(logBackupFolder).mkdir();
		LOG.debug("Backup directory for log files created : " + newLogDir);
		final File logDir = new File("log");
		final File[] listOfFiles = logDir.listFiles();
	    try {
	    	for (File file : listOfFiles) {
				if (file.isFile()) {
					System.out.println("*********" + file);
					sourceStream = new FileInputStream(file);
					targetStream = new FileOutputStream(logBackupFolder + "/" + file);
					sourceFileChannel = sourceStream.getChannel();
					targetFileChannel = targetStream.getChannel();
					final long size = sourceFileChannel.size();
					sourceFileChannel.transferTo(0, size, targetFileChannel);
				}
	        }
	    } catch (IOException e) {
	    	LOG.error("Channel or stream is still in use, so cann't close." + e.getMessage());
	    } finally {
			if (sourceStream != null) {
				try {
					sourceStream.close();
				} catch (IOException e) {
					LOG.error("Problem while closing source stream"
							+ e.getMessage());
				}
			}
			if (targetStream != null) {
				try {
					targetStream.close();
				} catch (IOException e) {
					LOG.error("Problem while closing target stream"
							+ e.getMessage());
				}
			}
			if (sourceFileChannel != null) {
				try {
					sourceFileChannel.close();
				} catch (IOException e) {
					LOG.error("Problem while closing source file channel"
							+ e.getMessage());
				}
			}
			if (targetFileChannel != null) {
				try {
					targetFileChannel.close();
				} catch (IOException e) {
					LOG.error("Problem while closing target file channel"
							+ e.getMessage());
				}
			}
		}
		
	}

am i missing something?

[Jesper de Jong]

Please read this: How to use code tags.

I added code tags to your posts above. Next time please add them yourself.

Look carefully at what the error message says: The system cannot find the path specified

Does the target directory exist? Did you make a mistake by adding an extra space in the name? This looks suspicious:

abc\2009-02-13_02-06-13\ abc\warn.log

Note the space before the second "abc".