HeadFirst Java 2nd Edition

[Bob Cook]

I am just starting out learning Java using this text book. I finished reviewing chapter 2 and have run the GuessGame in Eclipse as written in the book. I am trying to make a change so that within the player object I can store the number of times a player guesses a specific number (5 for example). I then want to have this printout at the end of the game to say "player 1 guessed 5 x times), player 2 guessed 5 x times, etc....

I made the following changes to the code and thought I am getting no errors this is not working as intended so I am definitely missing something here. Below is the code in the player and guess game classes with my changes. Any suggestions to point me in the right direction would be appreciated.

public class Player {
	int number = 0; // where the guess goes
	int guessFive = 0; 
	public void guess() {
		number = (int) (Math.random() * 10);
		System.out.println("I'm guessing " + number);
		if (number == 5){guessFive++;}
		}
	}

public class GuessGame {
	Player p1;
	Player p2;
	Player p3;

	public void startGame() {
		p1 = new Player();
		p2 = new Player();
		p3 = new Player();

		int guessp1 = 0;
		int guessp2 = 0;
		int guessp3 = 0;

		boolean p1isRight = false;
		boolean p2isRight = false;
		boolean p3isRight = false;

		int targetNumber = (int) (Math.random() * 10);
		System.out.println("I'm thinking of a number between 0 and 9...");

		while (true) {
			System.out.println("Number to guess is " + targetNumber);

			p1.guess();
			p2.guess();
			p3.guess();

			guessp1 = p1.number;
			System.out.println("Player one guessed " + guessp1);

			guessp2 = p2.number;
			System.out.println("Player two guessed " + guessp2);

			guessp3 = p3.number;
			System.out.println("Player three guessed " + guessp3);

			if (guessp1 == targetNumber) {
				p1isRight = true;
			}
			if (guessp2 == targetNumber) {
				p2isRight = true;
			}
			if (guessp3 == targetNumber) {
				p3isRight = true;
			}

			if (p1isRight || p2isRight || p3isRight) {

				System.out.println("We have a winner!");
				System.out.println("Player one got it right? " + p1isRight);
				System.out.println("Player two got it right? " + p2isRight);
				System.out.println("Player three got it right? " + p3isRight);
				System.out.println("Game is over.");
				String p1guessFive = null;
				String p2guessFive = null;
				String p3guessFive = null;
				System.out.println("Player one guessed 5 " + p1guessFive);
				System.out.println("Player two guessed 5 " + p2guessFive);
				System.out.println("Player three guessed 5 " + p3guessFive);
				break; // game over, so break out of the loop

			} else {
				// we must keep going because nobody got it right!
				System.out.println("Players will have to try again.");
			} // end if/else
		} // end loop
	} // end method
} // end class

[Henry Wong]

I made the following changes to the code and thought I am getting no errors this is not working as intended so I am definitely missing something here.

It would probably help if you tell us what you consider "working as intended" or what do you consider "missing something".

But here's a hint...

  System.out.println("Player one guessed 5 " + p1guessFive);   

Where is the p1guessFive variable set? And what is it set to?

Henry

[marc weber]

Welcome to JavaRanch!

You've defined a counter in your Player class as an int variable called "guessFive." That looks fine.

But in your GuessGame class, you define String variables for each player (like "p1guessFive") and set these to null. These have no relation to the int counters in your Player instances, nor do they ever get assigned a value other than null. Do you see why?

[Campbell Ritchie]

Welcome to JavaRanch
I don't have that book (I ought to buy a copy) but I have seen that guessing game many times: here on the beginner's forum. A search for "GuessGame" will probably find several previous discussions, and you can see how others handled their problems.