If condition not working in transaction

[shaf maff]

Hi Guys

take a look at the following code:

try {
	connection = daoFactory.getConnection();
	connection.setAutoCommit(false);
	
	// Update existing Draft
	Object[] values = mapExistingObject(draft);
	preparedStatement1 = connection.prepareStatement(SQL_UPDATE_EXISTING_DRAFT);
	DAOUtilities.setValues(preparedStatement1, values);
	preparedStatement1.executeUpdate();
	
	// Delete existing letter recipients
	preparedStatement2 = connection.prepareStatement(SQL_DELETE_EXISTING_RECIPIENTS);
	preparedStatement2.setLong(1, draft.getId());
	preparedStatement2.executeUpdate();				
	
	
	// Insert new recipients
       if(recipientIds.size() != 0) {
	   for(int i=0; i<recipientIds.size(); i++) {
		preparedStatement3 = connection.prepareStatement(SQL_INSERT_RECIPIENTS);
		preparedStatement3.setLong(1, draft.getId());
		preparedStatement3.setObject(2, recipientIds.get(i));
		preparedStatement3.executeUpdate();
	   }
       }
	
	// Commit transaction
	connection.commit();
	connection.setAutoCommit(true);
}

In the "Insert new Recipients" bit of the code I am trying to introduce an if statement which checks the size of recipientIds. It will run preparedstatement3 only if that list has atleast 1 value. Now, when I run it and I enter nothing for the recipients I expect it to insert the data into the other tables and skip the recipients table, but that isnt the case. See the error ouput below:

SQLException1@draft@DraftDAO: Cannot add or update a child row: a foreign key constraint fails (`mail_cms2`.`mail_recipients`, 
CONSTRAINT `mail_recipients_ibfk_2` FOREIGN KEY (`contact_id`) REFERENCES `user_contacts` (`contact_id`))

Does anyone know why this is happening ?






.>

[Paul Sturrock]

Your recipientIds collection looks like it contains invalid data, hence your foreign key constraint fails. How/when do you populate it?

[shaf maff]

Thats the problem, it contains no data so it shouldn't execute that chunck of code.

[Paul Sturrock]

Well clearly it does contain data. I'd check the code where its set. Stick in a break point and see whats happening.