ArrayList advice needed

[Frank Sween]

OKay so i have assignment called mystery calculator, it seems simple enough but im stuck on how to arrange it..
What initially has to be done is that i have 6 'cards' populated with a series of numbers which cant be hardcoded ..

what i have so far is

    
import acm.program.*;
import java.util.ArrayList;

/**
 * 
 * 
 * @author
 * @version 
 */
public class Calculator extends ConsoleProgram
{
    
    private ArrayList<Integer> card1;
    private ArrayList<Integer> card2;
    private ArrayList<Integer> card3;
    private ArrayList<Integer> card4;
    private ArrayList<Integer> card5;
    private ArrayList<Integer> card6;

    /**
     * Constructor for objects of class Calculator
     */
    public Calculator()
    {
        card1 = new ArrayList<Integer>();
        card2 = new ArrayList<Integer>();
        card3 = new ArrayList<Integer>();
        card4 = new ArrayList<Integer>();
        card5 = new ArrayList<Integer>();
        card6 = new ArrayList<Integer>();
    }
    
    public void addToCards()
    {
        for(int i=0;i<64;i++)
        {
            if((i % 2) == 1)
            {
                card1.add(i);
            }
            if((i % 4)==2 || (i%4) == 3)
            {
                card2.add(i);
            }
            if((i%8)>=4 && (i%8)<=7)
            {
                card3.add(i);
            }
            if((i%16)>=8 && (i%16)<=15)
            {
                card4.add(i);
            }
            if((i>=16 && i<=31) || (i>=48))
            {
                card5.add(i);
            }
            if(i>=32)
            {
                card6.add(i);
            }
        }
        
        
    }

My Question is: should i have a separate class called Card and instantiate the 6 arraylists there? or should i have one arraylist in a Card class and one araylist in Calculator class and somehow do it like that? im new to this and relly could do with some help much appreciate

[Campbell Ritchie]

Difficult to be sure, and there is a very nice distinction between some of your options.
I don't know the full details about having Lists in different classes, but the idea of one List in one class and another List in another class seems a bit suspect to me.
The difference between what you have and a Card class appears slight, but I suspect you will get better OO design, a minor consideration, and better marks, a major consideration, if you can create a Card class and keep your 6 Lists in 6 Card objects.

I presume you don't mind that some numbers are going into several cards?
You realise that i % 16 can never be > 15, which means you might be able to simplify several of your if conditions.

[Campbell Ritchie]

And welcome to JavaRanch

[Frank Sween]

Hey thanks for reply,

yea my major consideration is good marks, just starting programming and liking it..
So I went and made a 'Card' class and it works but...... I have a feeling my code is kindof bloated and im trying to cut down on the amount of code (this is what lecturers are telling us to do),

heres what I have so far, this is my Calculator class

  
import acm.program.*;
import java.util.ArrayList;


public class Calculator extends ConsoleProgram
{
    
    private ArrayList<Card> cards;
    Card card1 = new Card(1);
    Card card2 = new Card(2);
    Card card3 = new Card(3);
    Card card4 = new Card(4);
    Card card5 = new Card(5);
    Card card6 = new Card(6);

    /**
     * Constructor for objects of class Calculator
     */
    public Calculator()
    {
        cards= new ArrayList<Card>();
    }
    
    public void addToCards()
    {
        for(int i=0;i<64;i++)
        {
            if((i % 2) == 1)
            {
                card1.numbers.add(i);
            }
            
            if((i % 4)==2 || (i%4) == 3)
            {
                card2.numbers.add(i);
            }
            
            if((i%8)>=4 && (i%8)<=7)
            {
                card3.numbers.add(i);
            }
            
            if((i%16)>=8 && (i%16)<=15)
            {
                card4.numbers.add(i);
            }
            
            if((i>=16 && i<=31) || (i>=48))
            {
                card5.numbers.add(i);
            }
            
            if(i>=32)
            {
                card6.numbers.add(i);
            }
        }
        
        
    }
    
    public void mainMenu()
    {
        int answer = 0;
        printCard1();
        println("------------------");
        printCard2();
        println("------------------");
        printCard3();
        println("------------------");
        printCard4();
        println("------------------");
        printCard5();
        println("------------------");
        printCard6();
        println("------------------");
        println("\n Pick a number from any card. Do not tell me. Write it down. When you have picked your number press y.");
        String picked = readLine();
        if(picked.equals("y"))
        {
            clear();
            printCard1();
            println("\n Is Your number on this card? (y/n)");
            String card1Ans = readLine();
            if(card1Ans.equals("y"))
            {
                answer+=card1.numbers.get(0);
            }
            clear();
            
            printCard2();
            println("\n Is Your number on this card? (y/n)");
            String card2Ans = readLine();
            if(card2Ans.equals("y"))
            {
                answer+=card2.numbers.get(0);
            }
            clear();
            
            printCard3();
            println("\n Is Your number on this card? (y/n)");
            String card3Ans = readLine();
            if(card3Ans.equals("y"))
            {
                answer+=card3.numbers.get(0);
            }
            clear();
            
            printCard4();
            println("\n Is Your number on this card? (y/n)");
            String card4Ans = readLine();
            if(card4Ans.equals("y"))
            {
                answer+=card4.numbers.get(0);
            }
            clear();
            
            printCard5();
            println("\n Is Your number on this card? (y/n)");
            String card5Ans = readLine();
            if(card5Ans.equals("y"))
            {
                answer+=card5.numbers.get(0);
            }
            clear();
            
            printCard6();
            println("\n Is Your number on this card? (y/n)");
            String card6Ans = readLine();
            if(card6Ans.equals("y"))
            {
                answer+=card6.numbers.get(0);
            }
            clear();
        }
        
        println(answer);
        
        
      
    }
    /**
     * print card methods
     */ 
    public void printCard1()
    {
        println("Card : 1");
        for(int i=0;i<card1.numbers.size();i++)
        {
            print(card1.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
    
    public void printCard2()
    {
        println("Card : 2");
        for(int i=0;i<card2.numbers.size();i++)
        {
            print(card2.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
    
    public void printCard3()
    {
        println("Card : 3");
        for(int i=0;i<card3.numbers.size();i++)
        {
            print(card3.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
    
    public void printCard4()
    {
        println("Card : 4");
        for(int i=0;i<card4.numbers.size();i++)
        {
            print(card4.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
    
    public void printCard5()
    {
        println("Card : 5");
        for(int i=0;i<card5.numbers.size();i++)
        {
            print(card5.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
    
    public void printCard6()
    {
        println("Card : 6");
        for(int i=0;i<card6.numbers.size();i++)
        {
            print(card6.numbers.get(i)+" ");
            if((i%8)==7)
            {
                print("\n");
            }
        }
    }
       
    public void run()
    {
        addToCards();
        mainMenu();
    }

}


  

And here is my Card class

  
import java.util.ArrayList;
/**
 * Write a description of class Card here.
 * 
 * @author (your name) 
 * @version (a version number or a date)
 */
public class Card
{
    private int cardNo;
    public ArrayList<Integer> numbers;

    public Card(int c)
    {
        this.cardNo = c;
        numbers = new ArrayList<Integer>();
    }
    
    public int getCardNo()
    {
        return cardNo;
    }
    
    public void setCardNo(int cardNo)
    {
        this.cardNo = cardNo;
    }

    
}


  

What i want to know is any way of lessening this code? Is there a way I can get rid of all those separate printCard*() methods?

again any help is greatly appreciated

[Campbell Ritchie]

Try calling the methods printCardList or similar and pass a List<Card> as a parameter.

[Campbell Ritchie]

And the long block of repeated print statements can probably be condensed similarly. But I am too tired to work out how just now

[Frank Sween]

This is Kevin Sweeney, Entertainment Systems, WIT.


(sorry for bump)