Help with this code!

I am trying to connect to the database and I tested as an java application and it was ok but no success as a Web app. I am using eclipse with it and MS Access.

This is my code for the login:

This is the process.jsp page:

Should I put request or session??

This is the class:

package dbConnect;
import java.sql.*;
 
public class Connect {
 
   private String username = "";
   private String password = "";
 
   public Connect() {
  }
 
  public void setUsername(String username) {
     this.username = username;
  }
  public void setPassword(String password) {
     this.password = password;
   }
public boolean  authenticate(String username2,String password2) {
   String query="select * from tablename;";
   String DbUserName="";
   String DbPassword="";
   String finalUser="";
   try {
   Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
   Connection con=DriverManager.getConnection("jdbc :-o	 dbc:Tablename");
   Statement stat=con.createStatement();
   ResultSet rst=stat.executeQuery(query);
   while(rst.next())
 
  {
   DbUserName=rst.getString("UserName");
   DbPassword=rst.getString("password");
 
   if (username2.equals(DbUserName) && password2.equals(DbPassword)) {
   break;
     }
   }
 return true;
 }catch(Exception e){
 
 e.printStackTrace();
 return false;
 }
}
}

DO I have to create a session in the class like
and then set the atributes like :

But that means I have to use a Servlet?? Is that the only solution to my problem to use a Servlet Or Can I put declare this in the process page?? As it is only for testing anyway.

I have another way to do to where I create and 2 methods in the class to open and close the connection in the process.jsp page.

Anyone opinion woulb be welcome ok

Thanks

The above method if(myBean.validate()) in the jsp page is authenticate not validate.

Also Can I put this in the code to instantiate the bean like:
import java.util.ResourceBundle; and inside the authenticate method
ResourceBundle bandle = ResourceBundle.getBundle("data04");

Is that the way to do it?? The code compiles but only calls the process.jsp page and doesnt connect to the database??

thanks

data04 is the bean myBean ok

campos teixeira wrote:data04 is the bean myBean ok

I couldn't find any of the bean that is data04.

Anyway here is my code for the login bean:

package edu.rmit.isys2049;

// Imports
// =======
import java.sql.*;
import javax.sql.*;
import javax.servlet.*;
import javax.servlet.http.*;
import java.lang.Object.*;

/**
 * Bean used for login
 *
 * @author 
 */
public class LoginBean implements java.io.Serializable {

// Attributes
  // ==========

private String  name;    // Employee name
  private String  password;

// Getters/Setters
  // ==============

/**
   *  Returns employee name
   */
  public String getName() {
    return name;
  }

/**
   *  Sets employee name
   *
   *  @param name  Employee name
   */
  public void setName(String name) {
    this.name = name;
  }

/**
   *  Returns password
   */
  public String getPassword() {
    return password;
  }

/**
   *  Sets password
   *
   *  @param password  Password
   */
  public void setPassword(String password) {
    this.password = password;
  }

// Public methods
    // ==============

/**
     *  Checks if password is valid
     *  Dummy check
     *  In practice, you would check the password against one stored in a database
     *
     */
    public boolean passwordValid() throws Exception{

boolean validate = false;
  	  String user = null;
  	  String pword = null;
  	  try{
  		  Connection connect = DriverManager.getConnection("org.hsqldb.jdbcDriver","sa","");

String query = "select userName from accounts where userName='"+user+"' and password='"+pword+"'";
		  Statement state = connect.createStatement();
		  ResultSet rs = state.executeQuery(query);
		  while (rs.next()){
			  user=rs.getString("userName");
			  pword=rs.getString("password");
	  	  }
	  		 connect.close();
	  		 System.out.println("Disconnected from database");
	  } catch (SQLException e) {

System.out.println(e.getMessage());
        	// Print any other nested exceptions
	   		throw e; // Re-throw the SQLException
   	  } if ((user.equals("userName")) && (pword.equals("password"))){
	   	return true;
   	 }	else {
	   return false;
     }
 }
}

I can't seem to do the log in even I have these files:

login:

<%-- 
   login.jsp  - Input page for finding an employee
   Version 1
--%>

<%@ include file="/setErrorPage.jsf"%>

<HTML>
   <HEAD>
      <TITLE>Find Employee</TITLE>
   </HEAD>

<BODY>
      
      <%@ include file="/header.html"%>
      
      
      <table >
          <tr >
             
             <td   >
                
                <%@ include file="menu01.html"%>           
             </td>
             <td >
                
                <H2>Login</H2>
                
                <FORM ACTION="dispatcher" METHOD="POST"> 
                   <table>
                      <tr>
                         <td><INPUT TYPE="HIDDEN" NAME="action" VALUE="login1"></td>
                      </tr>
                   
                      <tr>
                         <td>Username:</td>
                         <td><INPUT NAME="name" TYPE="TEXT" id="name" SIZE="20"></td>
                      </tr>
                      <tr>
                        <td>Password:</td>
                        <td><input name="password" type="password" id="password" size="20"></td>
                      </tr>                     
                      <tr>
                         <td><INPUT TYPE="SUBMIT" VALUE="Submit"> 
                             <INPUT TYPE="RESET">                        </td>
                      </tr>
                   </table>
               </FORM>
               <p>If you have forgotten your login credentials, please click here.</p>
             <p>To register, <a >click here</a>.</p></td>
          </tr>
       </table>
       
       
       <%@ include file="/footer.html"%>
       
    </BODY>
 </HTML>

<%-- 
    login1.jsp - First output page for finding an employee
    Version 1
 --%>
 
 <%@ include file="/setErrorPage.jsf"%>
 <%@ page import="edu.rmit.isys2049.EmployeeData" %>
 
 <jsp:useBean id="loginBean" 
              scope="request" 
              class="edu.rmit.isys2049.LoginBean" /> 
 <jsp:setProperty name="loginBean" property="*" />
 
 <HTML>
    <HEAD>
       <TITLE>Find Employee</TITLE>
    </HEAD>
 
    <BODY>
       
       <%@ include file="/header.html"%>
       
       
       <table >
          <tr >
             
             <td   >
                
                <%@ include file="menu01.html"%>           
             </td>
             <td >
                
                
                <H2>Find an employee</H2>
 
                <% if(loginBean.passwordValid()) { %>
                   You are logged in as: 
                   <jsp:getProperty name="loginBean" property="name" /> 
                <% 
                   // Instantiate an employee object and store it in the session
                   EmployeeData emp = new EmployeeData();
                   emp.setName(loginBean.getName());
                   request.getSession().setAttribute("login", emp);
                   
                   // The emp bean can be retrieved in other JSPs as follows
                   EmployeeData emp2 = (EmployeeData) request.getSession().getAttribute("login");
                   
                   } else { %>
                   Invalid username or password!
                <% session.invalidate(); } %>                         
                
             </td>
          </tr>
       </table>
      
      
      <%@ include file="/footer.html"%>
      
   </BODY>
</HTML>

Can someone tell me what is wrong with my codes? Need it urgently. Thanks.

Jia Bin Tang wrote:Can someone tell me what is wrong with my codes?

There are too much and I am not motivated enough to point them all out.

But I would say, this one really, really, surprised me:

I can spot at least 5 (think)faults in here.

Bauke Scholtz wrote:There are too much and I am not motivated enough to point them all out.

But I would say, this one really, really, surprised me:

String query = "select userName from accounts where userName='"+user+"' and password='"+pword+"'"; ... user=rs.getString("userName"); pword=rs.getString("password"); ... if ((user.equals("userName")) && (pword.equals("password"))){
I can spot at least 5 (think)faults in here.

Hahah! I guess I'm not getting very logical here. I do a dummy copy and paste here and there, so I guess that's one of the reasons why it isn't correct.
I get the idea from here:

import java.io.*;
import java.util.*;
import java.sql.*;
import javax.servlet.*;
import javax.servlet.http.*;

public class LoginAuthentication extends HttpServlet{

private ServletConfig config;
  
  public void init(ServletConfig config)
    throws ServletException{
     this.config=config;
     }
  public void doPost(HttpServletRequest request, HttpServletResponse response) 
              throws ServletException,IOException{
      
    PrintWriter out = response.getWriter();
    String connectionURL = "jdbc:mysql://192.168.10.59/messagepaging";
    Connection connection=null;
    ResultSet rs;
    String userName=new String("");
    String passwrd=new String("");
    response.setContentType("text/html");
    try {
       // Load the database driver
      Class.forName("com.mysql.jdbc.Driver");
      // Get a Connection to the database
      connection = DriverManager.getConnection(connectionURL, "root", "root"); 
      //Add the data into the database
      String sql = "select user,password from User";
      Statement s = connection.createStatement();
      s.executeQuery (sql);
      rs = s.getResultSet();
      while (rs.next ()){
        userName=rs.getString("user");
        passwrd=rs.getString("password");
      }
      rs.close ();
      s.close ();
      }catch(Exception e){
      System.out.println("Exception is ;"+e);
      }
      if(userName.equals(request.getParameter("user")) 
             && passwrd.equals(request.getParameter("pass"))){
        out.println("WELCOME "+userName);
      }
      else{
        out.println("Please enter correct username and password");
        out.println("<a ><br>Login again</a>");
      }
  }
}

I don't understand this line as you put:

The other one was:

import java.io.*;
import javax.servlet.*;
import javax.servlet.http.*;
import javax.sql.*;
import java.sql.*;

public class login extends HttpServlet{ 
 
   public void doPost(HttpServletRequest request, HttpServletResponse response)
                                   throws ServletException,IOException{
      response.setContentType("text/html");
      PrintWriter out = response.getWriter();

System.out.println("MySQL Connect Example.");
      Connection conn = null;
      String url = "jdbc:mysql://localhost:3306/";
      String dbName = "user_register";
      String driver = "com.mysql.jdbc.Driver";
      String userName = "root"; 
      String password = "root";

String username="";
       String userpass="";
       String strQuery= ""; 
      Statement st=null;
      ResultSet rs=null;
      HttpSession session = request.getSession(true);

try {
        Class.forName(driver).newInstance();
        conn = DriverManager.getConnection(url+dbName,userName,password);
        if(request.getParameter("username")!=null &&
 request.getParameter("username")!="" && request.getParameter("password")!=null &&
 request.getParameter("password")!="")
        {
          username = request.getParameter("username").toString();
        userpass = request.getParameter("password").toString();
                    strQuery="select * from userregister where 
username='"+username+"' and  password='"+userpass+"'";
           System.out.println(strQuery);
          st = conn.createStatement();
          rs = st.executeQuery(strQuery);
          int count=0;
          while(rs.next())
          {
            
            session.setAttribute("username",rs.getString(2));
            count++;
          }

if(count>0)
          {
            response.sendRedirect("welcome.jsp");
          }
          else
          {
                       response.sendRedirect("login.jsp");
          }
      
          
        }
        else
        {
           response.sendRedirect("login.jsp");
        }

System.out.println("Connected to the database");       
        
        conn.close();
        System.out.println("Disconnected from database");
      } catch (Exception e) {
      e.printStackTrace();
      }
  }
}

And due to the rule of using the dispatcher servlet, I can't use these servlets in my program.

Nobody wants to help me on this?

Mr/Ms Campos Teixeira
I'm new in JSP and JSF too
but i think your solution is not cool

I think it's better that use JPA (an entity bean) for Database connection with a simple JSP page with JSTL or a servlet

it's really cool and secure use JSF for authorizing users

good luck mi amigo

ArAsh Dex wrote:Mr/Ms Campos Teixeira
I'm new in JSP and JSF too
but i think your solution is not cool

I think it's better that use JPA (an entity bean) for Database connection with a simple JSP page with JSTL or a servlet

it's really cool and secure use JSF for authorizing users

good luck mi amigo

My solution is based on school's requirement, that we try not to use entity bean. If there isn't such a rule, I'd have used EJB long ago.