problem in passing while loop variables from database

[preethi Ayyappan]

Hi,

I am getting records from the database and store it in a string variable inside while loop.When i tried to access the variable in another class,i am getting the top most record saved inside the while loop
my code follows:
class1:

   
public class class1 extends BaseAgiScript implements AgiScript//NewIvr14

{
	Statement st;
	ResultSet rs=null;
	Connection conn = null;static String campaign1;
	public void service(AgiRequest request, AgiChannel channel)
    throws AgiException
{
		answer();
		try
		{

		 	  Class.forName
		 		("com.mysql.jdbc.Driver").newInstance();
		 		conn = DriverManager.getConnection("jdbc:mysql://localhost:3306/peopletech", "meetme", "meetme");
		 		st = conn.createStatement(); 
		 		rs=  st.executeQuery("select * from tables where campaign_status='running'");
			 	 while(rs.next())
			 	  {
			 		 
			 		campaign1=rs.getString("campaign");
			 		class2 c=new class2();
			 		c.service(request, channel);
			 	  }
		}
		catch(Exception e)
		{
			e.printStackTrace();
		}
	
		hangup();
	
}
}

class 2:

   
public class class2 extends BaseAgiScript implements AgiScript//NewIvr14

{
	Statement st;
	ResultSet rs=null;
	Connection conn = null;
	public void service(AgiRequest request, AgiChannel channel)
    throws AgiException
{
		answer();
	class1 c1=new class1();
	String call=c1.campaign1;
	System.out.print(call);
		hangup();
		
}
}
 

Actually the records in the database contains aircel and airtel.But when i run this code, i am getting only aircel.

How can i get all the records taken from the database.please assist me to do this.

Thanks

[Campbell Ritchie]

Are you always updating the same String? In which case you lose the previous value every time you traverse the loop. Try adding the Strings to a List<String> and return that List.

[Campbell Ritchie]

Or, are you hanging up in the loop? Then you might only get one value at all.

[preethi Ayyappan]

When i run the class1 alone without calling class2,i can able to get all the records from the database.But if i call class2 from class1 and tried to access the variable campaign1 from class1,it just prints the top most record.

[Jan Cumps]

In class2.service() (created in class1.service) you are again creating a new class1, and trying to read a static member from that. Why?

What does the hangup() do in your class2 ? Maybe it causes the end of the loop in the original class1?

[preethi Ayyappan]

Atually,I need to pass the variable "campaign1" from class1 to class 2.Thats why in class2,i am calling class1's variable.

This is an ivr application.hangup is to cut the customer's call after the ivr gets completed.

[Jan Cumps]

Let's find the problem step by step:
Replace, in class1

 
  campaign1=rs.getString("campaign");  
  class2 c=new class2();  
  c.service(request, channel);  

By

 
  campaign1=rs.getString("campaign");  
  System.out.println( campaign1); 

Show us the output.

Then, replace by

 
  campaign1=rs.getString("campaign");  
  System.out.println( campaign1); 
  class2 c=new class2();  
  c.service(request, channel);  

Show us the output again.

[preethi Ayyappan]

sorry for the delayed reply due to unavoidable circumstances.

output for the code:

   
 campaign1=rs.getString("campaign");    
   System.out.println( campaign1);  
 

is

aircel
airtel

output for the code:

 
 campaign1=rs.getString("campaign");    
 System.out.println( campaign1);   
class2 c=new class2();    
 c.service(request, channel); 
   

is

aircel

.

where am i wrong here.please assist me.

Thanks

[Swastik Dey]

public class class2 extends BaseAgiScript implements AgiScript//NewIvr14  
   
 {  
     Statement st;  
     ResultSet rs=null;  
     Connection conn = null;  
     public void service(AgiRequest request, AgiChannel channel)  
     throws AgiException  
 {  
         answer();  
     /* if I am not getting very wrong the following line is causing the issue, you are re-instantiating class1 means ResultSet 
         object declared in class1 becomes null, more over if you are using a static variable what is the use of re-instantiating       the class, class1.campaign1 is good enough */ 
     class1 c1=new class1();  
     String call=c1.campaign1;  
     System.out.print(call);  
         hangup();  
           
 }  
}

[preethi Ayyappan]

Then how should i get the variable from class1 in class2?

[Swastik Dey]

public class class2 extends BaseAgiScript implements AgiScript//NewIvr14  
   
 {  
     Statement st;  
     ResultSet rs=null;  
     Connection conn = null;  
     public void service(AgiRequest request, AgiChannel channel)  
     throws AgiException  
 {  
         answer();  
         //class1 c1=new class1();  //no need to instantiate to access a static variable
     String call=class1.campaign1;  //should work fine as campaign1 is declared static in class1
     System.out.print(call);  
         hangup();  
           
 }  
}

[preethi Ayyappan]

Thanks swastik.It works fine.