Need Help With Caesar Shift

[Jeff Johnson]

Hi,
I need help with the Caesar Shift formula in this program. Any help would be appreciated.

Here is what I have:

//packer

/*This program reads in a original three character password input and the amount 
 of times for it to shift to the right and outputs the encrypted password .*/

import java.io.*;
public class packer {
    public static void main(String[] arg)throws IOException {
        BufferedReader dataIn = new BufferedReader (new InputStreamReader (System.in));
        System.out.println("Enter a password: ");
        System.out.println("Enter a number: ");
        String stroriginal=dataIn.readLine();
        String strnum=dataIn.readLine();
        char character;
        for (int i = 0; i < stroriginal.length(); i++){
            for (int n=0;n<26;n++) {
                character = stroriginal.charAt(i);
                character = (char) (character + n % 26);
                System.out.println("Encrypted password is: " + (char)i);
            }
        }
    }
}

Thanks

[edited to add code tags]

[Jeanne Boyarsky]

Jeff,
What's the problem - does it not compile? Does it not do what is expected?

Please state what is happening vs what you expect.

[Jeff Johnson]

When I enter a three letter password such as "zip" and the amount of times for it to shift to the right, the output comes out as: Encrypted password is: 

Here is an example of what the program should do:

Input:
zip (three letter password)
25 (amount of times for it to shift)

Output:
yho (encrypted password)

[Ernest Friedman-Hill]

I think in this line:

System.out.println("Encrypted password is: " + (char)i);

you meant for that last "i" to be "character", eh? The variable "i" is the loop index; cast to a char, it'd be a non-printing character.

[Jeff Johnson]

Sorry, but when I changed the last "i" to "character", the output came out as:

Encrypted password is: z
Encrypted password is: {
Encrypted password is: |
Encrypted password is: }
Encrypted password is: ~
Encrypted password is: 
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: i
Encrypted password is: j
Encrypted password is: k
Encrypted password is: l
Encrypted password is: m
Encrypted password is: n
Encrypted password is: o
Encrypted password is: p
Encrypted password is: q
Encrypted password is: s
Encrypted password is: t
Encrypted password is: v
Encrypted password is: w
Encrypted password is: x
Encrypted password is: y
Encrypted password is: z
Encrypted password is: {
Encrypted password is: |
Encrypted password is: }
Encrypted password is: ~
Encrypted password is: 
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: p
Encrypted password is: q
Encrypted password is: s
Encrypted password is: t
Encrypted password is: v
Encrypted password is: w
Encrypted password is: x
Encrypted password is: y
Encrypted password is: z
Encrypted password is: {
Encrypted password is: |
Encrypted password is: }
Encrypted password is: ~
Encrypted password is: 
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?
Encrypted password is: ?

I'm not sure what else to do?

[Ernest Friedman-Hill]

Well, what is that loop over "n" supposed to do? The outer loop runs once for each character; then the inner loop runs 26 times each time around the outer loop. So you're getting 26 x stroriginal.length() lines printed.

You need to get rid of that inner loop, then work on the expression "(character + n % 26) " so it represents the actual encoded character.