Spring 2.5 @Transactional not working

[Lisa Ray]

Hi All,
I'm using annotation-based Spring 2.5 in my service layer. The service calls DAO. It seems that service is not wrapped in a transaction which causes the Hibernate DAO to fail.

My Configuration file looks like this:

  

<bean id="freshUserService" class="com.mycompany.test.service.impl.UserServiceImpl" />

<context:annotation-config />
<aop:aspectj-autoproxy/>
<context:component-scan base-package="com.mycompany" /> 

  

Following is the Service impl class:

@Service
@Transactional(propagation = Propagation.REQUIRED)
@Configurable(autowire=Autowire.BY_TYPE) 
public class UserServiceImpl implements UserService {

Please suggest in case I'm missing something here.


Thanks
Lisa

[Nathan Pruett]

Is that the only configuration file, or are there more? I don't see the '<tx:annotation-driven/>' in your configuration. Or a TransactionManager, or a DataSource defined.

[Lisa Ray]

Hi Nathan, Thanks for the post. For the sake of brevity I didn't post the entire app context XML. Here's the Spring XML:

   
  <bean id="myDataSource" class="org.apache.commons.dbcp.BasicDataSource" destroy-method="close">
    <property name="driverClassName"> <value>${driverClassName}</value> </property>
    <property name="url"> <value>${fraud.url}</value> </property>
    <property name="username"> <value>${fraud.username}</value> </property>
    <property name="password"><value>${fraud.password}</value> </property>
  </bean>

<bean name="mySessionFactory" class="org.springframework.orm.hibernate3.LocalSessionFactoryBean">
 <property name="dataSource" ref="myDataSource"/>
[i].....more code...  [/i]   
</bean>


<bean id="hibernateTemplate" class="org.springframework.orm.hibernate3.HibernateTemplate">
<property name="sessionFactory" ref="mySessionFactory"/>
</bean>

<bean id="userDAO" class="com.mycompany.dao.hibernate.UserDAOImpl" >
<property name="hibernateTemplate" ref="hibernateTemplate"/>
</bean>


....
<context:annotation-config />
<aop:aspectj-autoproxy/>
<context:component-scan base-package="com.mycompany" /> 

.....
 <!-- enable the configuration of transactional behavior based on annotations -->
  <tx:annotation-driven transaction-manager="transactionManager"/>

  <!-- a PlatformTransactionManager is still required -->
  <bean id="transactionManager" class="org.springframework.jdbc.datasource.DataSourceTransactionManager">
  <property name="dataSource" ref="myDataSource"/>
  </bean>

 

I'm sure that the beans have been wired correctly, else I would have got a fat parser error. The only concern is that the service layer is not wrapped in a transaction. Because of which I get the following exception from the DAO layer:

  

[b]org.hibernate.HibernateException: getNamedQuery is not valid without active transaction[/b]
	more stack trace




  

Thanks
Lisa

[Lisa Ray]

Hi Ranchers,
I'm not sure if this is really a Spring issue or Hibernate ORM problem. I changed the transaction strategy to use AOP, as shown below:

<bean id="userManager" 
        class="org.springframework.transaction.interceptor.TransactionProxyFactoryBean">
        <property name="transactionManager"><ref local="transactionManager"/></property>
        <property name="target"><ref local="freshUserService"/></property>
        <property name="transactionAttributes">
            <props>
                <prop key="foo*">PROPAGATION_REQUIRED</prop>
            </props>
        </property>
    </bean>

    

Now even with the new changes in place, I get the following error:

   org.hibernate.HibernateException: getNamedQuery is not valid without active transaction
	at org.hibernate.context.ThreadLocalSessionContext$TransactionProtectionWrapper.invoke(ThreadLocalSessionContext.java:297)
	at $Proxy14.getNamedQuery(Unknown Source)
	at com.common.dao.hibernate.UserDAOImpl.getExistingUserByEcn(UserDAOImpl.java:353)
	at com.common.dao.hibernate.UserDAOImpl.save(UserDAOImpl.java:198)
	at com..test.service.impl.UserServiceImpl.foo(UserServiceImpl.java:56)
	at com..test.unit.SmokeItAuthzTest.testAddUser(SmokeItAuthzTest.java:34)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.springframework.test.context.junit4.SpringTestMethod.invoke(SpringTestMethod.java:198)
	at org.springframework.test.context.junit4.SpringMethodRoadie.runTestMethod(SpringMethodRoadie.java:274)
	at org.springframework.test.context.junit4.SpringMethodRoadie$2.run(SpringMethodRoadie.java:207)
	at org.springframework.test.context.junit4.SpringMethodRoadie.runBeforesThenTestThenAfters(SpringMethodRoadie.java:254)
	at org.springframework.test.context.junit4.SpringMethodRoadie.runWithRepetitions(SpringMethodRoadie.java:234)
	at org.springframework.test.context.junit4.SpringMethodRoadie.runTest(SpringMethodRoadie.java:204)
	at org.springframework.test.context.junit4.SpringMethodRoadie.run(SpringMethodRoadie.java:146)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.invokeTestMethod(SpringJUnit4ClassRunner.java:151)
	at org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
	at org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
	at org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:26)
	at org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:36)
	at org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:45)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
 

- Lisa