creating JTable using data from .txt file

[boki markos]

i can compile, the JTable is created and so are the column headings but the rows arent... in the rows this comes up : [Ljava.lang.String;@408fbecf <--- these numbers change on every cell
i think the problem is with the getValueAt() class... can someone please help me out.

import javax.swing.*;
import javax.swing.table.AbstractTableModel;
import java.io.*;
import java.util.*;
import javax.swing.table.*;
import java.awt.*;


public class TableDemo extends JPanel {
    private boolean DEBUG = false;
    static ArrayList rosterList = new ArrayList();

    public TableDemo() {
        super(new GridLayout(1,0));

        JTable table = new JTable(new MyTableModel());
        table.setAutoCreateRowSorter(true);
        JTableHeader header = table.getTableHeader();
        header.setBackground(Color.yellow);
        table.setPreferredScrollableViewportSize(new Dimension(1700, 700));
        table.setFillsViewportHeight(true);
        for(int index = 1; index == 26; index++)
        {
        TableColumn col = table.getColumnModel().getColumn(index);
        int width = 150;
        col.setPreferredWidth(width);
        

        }
        int index0 = 0;
        TableColumn col = table.getColumnModel().getColumn(index0);
        int width = 250;
        col.setPreferredWidth(width);
        

        
        
        
        //Create the scroll pane and add the table to it.
        JScrollPane scrollPane = new JScrollPane(table);

        //Add the scroll pane to this panel.
        add(scrollPane);
    }

    class MyTableModel extends AbstractTableModel {
        private String[] columnNames = { "Name" , "Age", "Pos", "Nat", "St", "Tk", "Ps", "Sh", "Ag", "Kab", "Tab", "Pab", "Sab", "Gam", "Sub", "Min", "Mom", "Sav", "Con", "Ktk", "Kps", "Sht", "Gls", "Ass", "DP", "Inj", "Sus"};
        

        public int getColumnCount() {
            return columnNames.length;
        }

        public int getRowCount() {
            return rosterList.size();
        }

        public String getColumnName(int col) {
            return columnNames[col];
        }

      
        public Object getValueAt(int row, int col) 
        {    
            return rosterList.get(row);    [b]<-------------------------- i think i need to do something with the col integer here but everything i try gets the error: statement unreachable[/b]
                                
        }

        
    }

   
    private static void createAndShowGUI() {
        //Create and set up the window.
        JFrame frame = new JFrame("TableDemo");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        //Create and set up the content pane.
        TableDemo newContentPane = new TableDemo();
        newContentPane.setOpaque(true); //content panes must be opaque
        frame.setContentPane(newContentPane);
        


        //Display the window.
        frame.pack();
        frame.setVisible(true);
    }

    public static void main(String[] args) {
        //Schedule a job for the event-dispatching thread:
        //creating and showing this application's GUI.
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
                creatArr();
                createAndShowGUI();
                
            }
        });
    }
    

private static void creatArr() 
  {
     BufferedReader br = null;
     
     try
    {
      br = new BufferedReader(new FileReader("mydata.txt"));
      String line = br.readLine();
        
      while (line != null )
      {
        String [] rowfields = line.split("[ ]+");
        rosterList.add(rowfields);
        line = br.readLine();
       }
     
    }
    catch (FileNotFoundException e)
    {
      // can be thrown when creating the FileReader/BufferedReader
      // deal with the exception
      e.printStackTrace();
    }
    catch (IOException e)
    {
      // can be thrown by br.readLine()
      // deal with the exception
      e.printStackTrace();
    }
    
    
}
    
  
    

}

[Rob Spoor]

boki markos wrote:[Ljava.lang.String;@408fbecf <--- these numbers change on every cell

That is the result of toString() called on a String[].

You probably want to return rosterList.get(row)[column] in getValueAt - rosterList.get(row) returns a String[], and you take element column of that array.

Of course you will need a cast to String[] if you're not using generics.

[boki markos]

hey, thanks for reply... umm i am pretty new to java, what is a cast to String[]? :S

i changed

rosterList.get(row)[col] and i still get an error

[Rob Spoor]

Check out http://www.janeg.ca/scjp/oper/cast.html

Because your ArrayList does not use generics, rosterList.get(row) returns an Object reference. You need to cast that to String[] first, before you can access its elements.

Or you can make your ArrayList generic; check out http://java.sun.com/j2se/1.5.0/docs/guide/language/generics.html

[Campbell Ritchie]

We usually discuss this sort of question on the Swing forum. Moving.

[boki markos]

dont get that generics stuff lol

anyother way to do it?

can you show me what i need to change please?

[Rob Spoor]

Have you even read that first link?

[boki markos]

is this what you ment? i changed my ArrayList... the program now compiles and runs but no rows.. just the headings(columns)

       ArrayList<String[]> rosterList = new ArrayList<String[]>();

        public int getColumnCount() {
            return columnNames.length;
        }

        public int getRowCount() {
            return rosterList.size();
        }

        public String getColumnName(int col) {
            return columnNames[col];
        }

      
        public Object getValueAt(int row, int col) 
        {    
             return rosterList.get(row)[col];
                              
        }

[Rob Spoor]

That's from the second link, but to be honest, generics are better.

What are the contents of rosterList? Is the file read properly?