Jboss complains that our client is not disconnecting cleanly

[Martijn Verburg]

Hi all,

We use a client to manually publish to our JMS servers (Jboss EAP 4.3, no CP's applied) for testing purposes. For some reason we get Jboss complaining that our client is not closing off properly.

e.g.

20090521 11:01:48.253 WARN [Timer-4] SimpleConnectionManager.handleClientFailure(): A problem has been detected with the connection to remote client a3266w-q8u9wf-fuzaly7g-1-fuzalyfg-4, jmsClientID=b-mhylazuf-1-g7ylazuf-fw9u8q-w6623a. It is possible the client has exited without closing its connection(s) or the network has failed. All connection resources corresponding to that client process will now be removed.

The code we use to publish is below:

    private void publishToTopic(Context context, Object object) throws JMSException, NamingException,
            CommonException
    {
        Connection connection = getConnection(JMSToolsUtils.isAuthenticated());
        Session topicSession = null;
        MessageProducer messageProducer = null;
        Message message = null;
        try
        {
            connection = getConnection(JMSToolsUtils.isAuthenticated());
            String topicName = JMSToolsUtils.getTopicName();
            Topic targetTopic = (Topic) context.lookup(JMSConstants.TOPIC_KEY_PREFIX + topicName);
            topicSession = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
            // Publish the payload as many times as requested
            for (int i = 1; i <= JMSToolsUtils.getPayloadPublishNumber(); i++)
            {
                message = createMessage(object, topicSession);
                messageProducer = topicSession.createProducer(targetTopic);
                logger.info("Publishing [" + i + "/" + JMSToolsUtils.getPayloadPublishNumber() + "].");
                messageProducer.send(targetTopic, message, DeliveryMode.PERSISTENT, Message.DEFAULT_PRIORITY, Message.DEFAULT_TIME_TO_LIVE);
                logMessageId(message);
                messageProducer.close();
                logger.info("Closed Producer");
            }
        }
        finally
        {
            logger.info("Cleaning up producer, session and connection.");
            if (messageProducer != null)
            {
                messageProducer.close();
                logger.info(" Closed Producer");
                if (topicSession != null)
                {
                    topicSession.close();
                    logger.info(" Closed Session");
                    if (connection != null)
                    {
                        connection.stop();
                        logger.info(" Stopped Connection");
                        connection.close();
                        logger.info(" Closed Connection");
                    }
                    else
                    {
                        logger.info(" Connection was null, therefore already closed.");
                    }
                }
                else
                {
                    logger.info(" Session was null, therefore already closed.");
                }
            }
            else
            {
                logger.info(" Producer was null, therefore already closed.");
            }
        }
    }

The logging we get when we publish:

..
..
11:01:08,689 INFO [TPublisher] Publishing [1/1].
11:01:08,700 INFO [TPublisher] ID:JBM-21504
11:01:08,701 INFO [TPublisher] Closed Producer
11:01:08,701 INFO [TPublisher] Cleaning up producer, session and connection.
11:01:08,701 INFO [TPublisher] Closed Producer
11:01:08,703 INFO [TPublisher] Closed Session
11:01:08,704 INFO [TPublisher] Stopped Connection
11:01:08,715 INFO [TPublisher] Closed Connection
11:01:08,715 INFO [TPublisher] Publish Complete

As far as I can tell we’re following best practices with regards to closing everything down, can anyone spot anything we’re doing wrong?

[Martijn Verburg]

We were calling getConnection twice, all good now!

[Rajkumar Selvam]

You created connection twice with same connection reference object. Please create single connection to publish/subscribe messages.

[Peter Johnson]

Rajkumar, please do not wake the zombies! And especially do not wake them to tell them the same solution that was already posted.
Other than that, welcome to Java Ranch!