How to store values in session using struts 2 and then how to retrieve values in a jsp

Hi dear,

I have created the following action class to store values in session. Please tell me if this procedure is correct

package net.astralpharma;
import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Map;

import com.opensymphony.xwork2.ActionSupport;
import com.opensymphony.xwork2.ActionContext;

public class Searchsupplierbyname extends ActionSupport{
	private String suppliername;
	private String productname;
	private String rate1;
	private String rate2;
	private String rate3;
	private String rate4;
	private String rate5;
	private String rate6;
	private String rate7;
	private String rate8;
	private String rate9;
	private String rate10;
	private Map session;
	public Searchsupplierbyname(){};
	public Searchsupplierbyname(
	String productname,
	String rate1,
	String rate2,
	String rate3,
	String rate4,
	String rate5,
	String rate6,
	String rate7,
	String rate8,
	String rate9,
	String rate10)
	{
		this.productname=productname;
		this.rate1=rate1;
		this.rate2=rate2;
		this.rate3=rate3;
		this.rate4=rate4;
		this.rate5=rate5;
		this.rate6=rate6;
		this.rate7=rate7;
		this.rate8=rate8;
		this.rate9=rate9;
		this.rate10=rate10;
	}
	
	public String execute() throws Exception {
		String suppliername=getSuppliername();
		
		String url = "jdbc:mysql://localhost:3306/";
    	String dbname="astraldb";
    	String driverName="org.gjt.mm.mysql.Driver";
    	String userName="root";
    	String password="root";
    	Connection con=null;
    	PreparedStatement stat =null;
    	
    	try
    	{
    		Class.forName(driverName);
    		System.out.println("Driver Loaded");
			con = DriverManager.getConnection("jdbc:mysql://localhost:3306/astraldb","root","root" );
			System.out.println("Database is connected");
			String query="Select * from supplier_proddetails where suppliername=?";
    		stat = con.prepareStatement(query);
			System.out.println(stat);
			stat.setString(1, suppliername);
			ResultSet rs = stat.executeQuery();
			System.out.println("rs"+ rs);
			while(rs.next())
			{
				System.out.println("inside while");
				String Productname = rs.getString("productname");
				String Rate1 = rs.getString("rate1");
				String Rate2 = rs.getString("rate2");
				String Rate3 = rs.getString("rate3");
				String Rate4 = rs.getString("rate4");
				String Rate5 = rs.getString("rate5");
				String Rate6 = rs.getString("rate6");
				String Rate7 = rs.getString("rate7");
				String Rate8 = rs.getString("rate8");
				String Rate9 = rs.getString("rate9");
				String Rate10 = rs.getString("rate10");
				
				Searchsupplierbyname details = new Searchsupplierbyname("Productname","Rate1","Rate2","Rate3","Rate4","Rate5","Rate6","Rate7","Rate8","Rate9","Rate10");
				System.out.println("created bean successfully");
				Map session = ActionContext.getContext().getSession();
				session.put("details", "details");
				System.out.println("session object created successfully");
				return "success";
			 }
		}
    	catch(SQLException sqle)
    	{
    		System.out.println("Exception : " + sqle);
    		sqle.printStackTrace();
    	}
    	return "error";
	    
	}
	    
	    public String getSuppliername() {
	        return suppliername;
	    }

public void setSuppliername(String suppliername) {
	        this.suppliername = suppliername;
	    }
	    
	    public String getProductname() {
	        return productname;
	    }

public void setProductname(String productname) {
	        this.productname = productname;
	    }
	    
	    public String getRate1() {
	        return rate1;
	    }

public void setRate1(String rate1) {
	        this.rate1 = rate1;
	    }
		
	    public String getRate2() {
	        return rate2;
	    }

public void setRate2(String rate2) {
	        this.rate2 = rate2;
	    }
	    
	    public String getRate3() {
	        return rate3;
	    }

public void setRate3(String rate3) {
	        this.rate3 = rate3;
	    }
	    
	    public String getRate4() {
	        return rate4;
	    }

public void setRate4(String rate4) {
	        this.rate4 = rate4;
	    }
	    
	    public String getRate5() {
	        return rate5;
	    }

public void setRate5(String rate5) {
	        this.rate5 = rate5;
	    }
	    
	    public String getRate6() {
	        return rate6;
	    }

public void setRate6(String rate6) {
	        this.rate6 = rate6;
	    }
	    
	    public String getRate7() {
	        return rate7;
	    }

public void setRate7(String rate7) {
	        this.rate7 = rate7;
	    }
	    
	    public String getRate8() {
	        return rate8;
	    }

public void setRate8(String rate1) {
	        this.rate8 = rate8;
	    }
	    
	    public String getRate9() {
	        return rate9;
	    }

public void setRate9(String rate9) {
	        this.rate9 = rate9;
	    }
	    
	    public String getRate10() {
	        return rate10;
	    }

public void setRate10(String rate10) {
	        this.rate10 = rate10;
	    }
	    public Map getSession(){
	    	return session;
	    }
	    public void setSession(Map session){
	    	this.session=session;
	    }
	   
}

Also I am using the following jsp to retrieve values from the session but i am getting null values. Please analyse

<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ page language="java" contentType="text/html"%>
<%@ page import="java.util.Map" / %>
<%@ page import="net.astralpharma.Searchsupplierbyname" %>

<html>
 <head>
 <title>Supplier Details</title>
 <link href="<s:url value="/css/main.css"/>" rel="stylesheet"
 type="text/css"/> 
 </head>
 <body>
 <jsp:useBean id="details" class="net.astralpharma.Searchsupplierbyname"></jsp:useBean>
 <s:form method="post">
 <body>
 Welcome to the Supplier Details Page 
 
 Product Supplied: <%= details.getProductname() %>
 Rate1:<%=details.getRate1() %>
 Rate2:<%=details.getRate2() %>
 Rate3:<%=details.getRate3() %>
 Rate4:<%=details.getRate4() %>
 Rate5:<%=details.getRate5() %>
 Rate6:<%=details.getRate6() %>
 Rate7:<%=details.getRate7() %>
 Rate8:<%=details.getRate8() %>
 Rate9:<%=details.getRate9() %>
 Rate10:<%=details.getRate10() %>
 
 </body>

</s:form>
 </body>
</html>

You've put the string "details" into session (line 95).

You also appear to be putting a new instance of the action itself into session--this is rather unusual. Normally you'd want to use a simple DTO.

It's also not clear to me if this needs to be in session, or just needs to be usable on the JSP--action properties are available in the JSP by default as long as they have a public accessor.

Lastly, in general, it's best to avoid doing that type of database work in the action itself--that logic belongs in a service which can then be use *by* the action.

Hi,

I changed my .jsp logic and now I am able to print the values

<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ page language="java" contentType="text/html"%>

<html>
 <head>
 <title>Supplier Details</title>
 <link href="<s:url value="/css/main.css"/>" rel="stylesheet"
 type="text/css"/> 
 </head>
 <body>
 
 
 <table>
 <s:form method="post">
 
 <tr><th> Welcome to the Product Details Page</th></tr>
 
 <tr><td>Product Supplied: <%=session.getAttribute("productname") %></td>
 <td>Rate1:<%=session.getAttribute("rate1") %></td>
 <td>Rate2:<%=session.getAttribute("rate2") %></td>
 <td>Rate3:<%=session.getAttribute("rate3") %></td>
 <td>Rate4:<%=session.getAttribute("rate4") %></td>
 <td>Rate5:<%=session.getAttribute("rate5") %></td>
 <td>Rate6:<%=session.getAttribute("rate6") %></td>
 <td>Rate7:<%=session.getAttribute("rate7") %></td>
 <td>Rate8:<%=session.getAttribute("rate8") %></td>
 <td>Rate9:<%=session.getAttribute("rate9") %></td>
 <td>Rate10:<%=session.getAttribute("rate10") %></td></tr>
 
 </s:form>
 </table> 
 </body>
</html>