need to transfer productID from url to action class in struts 2

Hi dear,

I am trying to transfer the productId from url to action class and have not been able to do that.

my front end jsp is as follows:

My action class showpdtsuppliers.java is as follows:

package net.astralpharma;
import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;
import org.apache.struts2.ServletActionContext;
import javax.servlet.http.HttpServletRequest;

import java.sql.*;
import java.util.*;

import net.astralpharma.Productdisplay;

public class Showpdtsuppliers extends ActionSupport
	{
	
	private String productId;
	private String productName;
	List<Supplier> supplierName = new ArrayList<Supplier>();
		
	public String populate()
	{
		productName=getProductName();
		return "populate";
	}
		
	public String execute() throws Exception{
		HttpServletRequest  request  = ServletActionContext.getRequest();

String productId = request.getParameter("productId");
		
		//String productId=(String) ActionContext.getContext().getParameters().get("loginname");

System.out.println("Product Id = " + productId);
		String url = "jdbc:mysql://localhost:3306/";
    	String dbname="astraldb";
    	String driverName="org.gjt.mm.mysql.Driver";
    	String userName="root";
    	String password="root";
    	Connection con=null;
    	PreparedStatement stat =null;
    	
    	try
    	{
    		Class.forName(driverName);
    		System.out.println("Driver Loaded");
			con = DriverManager.getConnection("jdbc:mysql://localhost:3306/astraldb","root","root" );
			System.out.println("Database is connected");
			System.out.println("Product Id = " + productId);
			System.out.println("Product Name = " + productName);
			String query="Select suppliername from supplier_proddetails where productid=?";
    		stat = con.prepareStatement(query);
    		stat.setString(1, productId);
			System.out.println(stat);
			ResultSet rs = stat.executeQuery();
			System.out.println("rs"+ rs);
			while(rs.next())
			{
				System.out.println("inside while");
				supplierName.add(new Supplier((rs.getString("supplierName"))));
				System.out.println("item added successfully");
			}				
			return "success";
		}
		catch(Exception ex){
		ex.printStackTrace();
		System.out.println("Exception" + ex.getMessage());
		}
		return "error";
		}
		
		public List<Supplier> getSupplierName() {
	        return  supplierName;
	    }

public void setSupplierName(List<Supplier> supplierName) {
	        this.supplierName = supplierName;
	    }
	        
	    public String getProductId() {
	        return productId;
	    }

public void setProductId(String productId) {
	        this.productId = productId;
	    }
	    
	    public String getProductName() {
	        return productName;
	    }

public void setProductName(String productName) {
	        this.productName = productName;
	    }
}

My Supplier.java class is as follows:

As you can see that I am trying to get the productId and have used:

but its been of no help.

I have also used:

butthis method has also not been able to get the productID from the front end jsp.

I am appending the output.

xxxxxxxxxxxxxx
Product Id =
Driver Loaded
Database is connected
Product Id =
Product Name = null
com.mysql.jdbc.PreparedStatement@8ab08f: Select suppliername from supplier_proddetails where productid=''[B@14d921a
rscom.mysql.jdbc.ResultSet@1b32627
xxxxxxxxxxxxxxxxx

Please help.

...

Use the productId action class property; there's zero reason to use anything from the request in this usecase.

The advice given you on struts-user to move the database code into a service is good advice: it makes the action and service far, far more testable.

Hi Dave,

I have made changes in the action class as you have proposed. But I have still not been able to get the productId from the front end jsp.

package net.astralpharma;
import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;
import org.apache.struts2.ServletActionContext;
import java.sql.*;
import java.util.*;

import net.astralpharma.Connect;
import net.astralpharma.Productdisplay;

public class Showpdtsuppliers extends ActionSupport 
	{
	private String productId;
	private String productName;
	List<Supplier> supplierName = new ArrayList<Supplier>();
	
	public String populate()   
    {   
        productName=getProductName();
        productId=getProductId();
        return "populate";   
    }   
	
	public String execute() throws Exception{
			Connect connect = new Connect();
			Connection con = connect.useConnection();
			String productId=(String) ActionContext.getContext().getParameters().get("loginname");  
			System.out.println("Product Id = " + productId);
			String query="Select suppliername from supplier_proddetails where productid=?";
    		PreparedStatement stat = con.prepareStatement(query);
    		stat.setString(1, productId);
			System.out.println(stat);
			ResultSet rs = stat.executeQuery();
			System.out.println("rs"+ rs);
			while(rs.next())
			{
				System.out.println("inside while");
				supplierName.add(new Supplier((rs.getString("supplierName"))));
				System.out.println("item added successfully");
			}				
			return "success";
		}
	
		
		
		public List<Supplier> getSupplierName() {
	        return  supplierName;
	    }

public void setSupplierName(List<Supplier> supplierName) {
	        this.supplierName = supplierName;
	    }
	        
	    public String getProductId() {
	        return productId;
	    }

public void setProductId(String productId) {
	        this.productId = productId;
	    }
	    
	    public String getProductName() {
	        return productName;
	    }

public void setProductName(String productName) {
	        this.productName = productName;
	    }
}

Here is the output

xxxxxxxxxxxxx
Driver Loaded
Database is connected
Product Id = null
com.mysql.jdbc.PreparedStatement@ad157f: Select suppliername from supplier_proddetails where productid=null[B@15e538e
rscom.mysql.jdbc.ResultSet@1bfa3d3
xxxxxxxxxxxxx

Remove line 28.

Hi dear,

I have been trying to read the productID from the url but it goes into an infinite loop at point 1. I am posting the code below. Please help.

package net.astralpharma;
import java.io.*;
import com.opensymphony.xwork2.ActionContext;
import com.opensymphony.xwork2.ActionSupport;
import org.apache.struts2.ServletActionContext;

import java.io.BufferedReader;
import java.io.IOException;
import java.net.URL;
import java.net.URLConnection;
import java.sql.*;
import java.util.*;

import net.astralpharma.Connect;
import net.astralpharma.Product;
import net.astralpharma.Productdisplay;

public class Showprodsuppliers extends ActionSupport 
	{
	private String productID;
	private String productName;
	List<Supplier> supplierName = new ArrayList<Supplier>();
	
	
	public String execute() throws Exception{
		StringBuffer sb = new StringBuffer("http://localhost:8080/Astralpharma1/astralpharma/astralpharma/showprodsuppliers.action?productID=1");
		
		URL url = new URL(sb.toString());
		URLConnection urlConn = url.openConnection();
		urlConn.setUseCaches(true);
		urlConn.setDoOutput(true);
		urlConn.setDoInput(true);
		System.out.println("reached point 1");
					
		OutputStreamWriter osr = new OutputStreamWriter(urlConn.getOutputStream());
			
		BufferedReader br = new BufferedReader(new InputStreamReader(urlConn.getInputStream()));
		
		String tempStr;
		StringBuffer buffer = new StringBuffer();
		System.out.println("Reached point 2");
		
		while((tempStr = br.readLine())!= null)
			{
				buffer.append(tempStr + "<br>\n");
								
			}
		br.close();
		
		StringTokenizer st = new StringTokenizer(buffer.toString());
		ArrayList<String> output = new ArrayList<String>();
		System.out.println("reached point 3"); 
		while(st.hasMoreTokens())
		{
			String server = st.nextToken();
			try{
				if(st.nextToken().contentEquals("productID"));
				{
					productID=st.nextToken().valueOf("productID");
					System.out.println("Value of productID" + productID);
				}
			}
			catch(Exception e)
			{
				System.out.println("Exception" + e.getMessage());
			}
		}
		System.out.println("Reached point 4");
			
			Connect connect = new Connect();
			Connection con = connect.useConnection();
			String query="Select suppliername from supplier_proddetails where productid=?";
    		PreparedStatement stat = con.prepareStatement(query);
    		stat.setString(1, productID);
			System.out.println(stat);
			ResultSet rs = stat.executeQuery();
			System.out.println("rs"+ rs);
			while(rs.next())
			{
				System.out.println("inside while");
				supplierName.add(new Supplier((rs.getString("supplierName"))));
				System.out.println("item added successfully");
			}				
		return "success";
		}
	
		public List<Supplier> getSupplierName() {
	        return  supplierName;
	    }

public void setSupplierName(List<Supplier> supplierName) {
	        this.supplierName = supplierName;
	    }
	    
	    public String  getProductID() {
	        return  productID;
	    }

public void setProductID(String productID ) {
	        this.productID  = productID ;
	    }
	    
	    
	    public String getProductName() {
	        return productName;
	    }

public void setProductName(String productName) {
	        this.productName = productName;
	    }
	   
}

Continued on struts-user.

Just add <s:hidden name="productId" /> It will pass your productId at URL automatically.

No, that's only if there's a form, and isn't the easiest way to do this--you'd have to create a form and submit for every item.

Putting the productId in the URL is the canonical solution.

I am giving you my example through which i am implementing my all action classes.

Now implement all of your action classes in following way, i am putting one of my action class as for example :

package com.sufalam.presentation.marketing.action;

//~--- non-JDK imports --------------------------------------------------------

import com.opensymphony.xwork2.ActionSupport;

import com.sufalam.business.marketing.model.bean.City;
import com.sufalam.business.marketing.model.bean.State;
import com.sufalam.business.marketing.model.bean.User;
import com.sufalam.business.marketing.service.security.ICitySecurityProcessor;
import com.sufalam.business.marketing.service.security.IStateSecurityProcessor;
import com.sufalam.business.marketing.service.security.IUserSecurityProcessor;
import com.sufalam.presentation.common.action.BaseSaveAction;
import com.sufalam.presentation.marketing.bean.CityViewBean;

//~--- JDK imports ------------------------------------------------------------

import java.util.ArrayList;
import java.util.List;

public class CitySaveAction extends BaseSaveAction {
    private ICitySecurityProcessor  citySecurityProcessor;
    private CityViewBean            cityViewBean;
    private List<State>             stateList;
    private IStateSecurityProcessor stateSecurityProcessor;
    private IUserSecurityProcessor  userSecurityProcessor;

public List<State> getStateList() {
        return stateList;
    }

public void setStateList(List<State> stateList) {
        this.stateList = stateList;
    }

@Override
    public String executeAction() throws Exception {
        try {
            if (cityViewBean.getAction() == null) {
                stateList = new ArrayList<State>();
                stateList = stateSecurityProcessor.findByAll(0, null, null, null, null, null, true, true, null, null,
                        null, null, 0);

return SUCCESS;
            } else {
                if (cityViewBean.getAction().equals("save")) {
                    City  city           = new City();
                    State state          = this.stateSecurityProcessor.getUserById(cityViewBean.getStateId());
                    User  userCreatedBy  = this.userSecurityProcessor.getUserById(cityViewBean.getAuditedBy());
                    User  userModifiedBy = this.userSecurityProcessor.getUserById(cityViewBean.getModifiedBy());
                    User  userDeletedBy  = this.userSecurityProcessor.getUserById(cityViewBean.getDeletedBy());
                    User  userAuditedBy  = this.userSecurityProcessor.getUserById(cityViewBean.getAuditedBy());

city.setName(cityViewBean.getName());
                    city.setState(state);
                    city.setCreatorUser(userCreatedBy);
                    city.setModificationUser(userModifiedBy);
                    city.setDeletionUser(userDeletedBy);
                    city.setAuditorUser(userAuditedBy);
                    this.citySecurityProcessor.save(city);

return ActionSupport.SUCCESS;
                } else {
                    return ActionSupport.ERROR;
                }
            }
        } catch (Exception ex) {
            return ActionSupport.ERROR;
        }
    }

@Override
    public Object getModel() {
        return cityViewBean;
    }

@Override
    public void initViewBean() {
        cityViewBean = new CityViewBean();
    }

public void setCountrySecurityProcessor(ICitySecurityProcessor citySecurityProcessor) {
        this.citySecurityProcessor = citySecurityProcessor;
    }

public void setStateSecurityProcessor(IStateSecurityProcessor stateSecurityProcessor) {
        this.stateSecurityProcessor = stateSecurityProcessor;
    }

public void setUserSecurityProcessor(IUserSecurityProcessor userSecurityProcessor) {
        this.userSecurityProcessor = userSecurityProcessor;
    }
}

You have to create view bean & in which you have to add all the setter & getter method of your front side jsp page. Your setter & getter method will handle all the thing & you will get all the data from jsp to action classes.

Besides that his question has already been answered (on the struts-user mailing list), this doesn't really address the original question, which was how to get a value from a URL into an action. A complete example of that is a few lines of JSP and a few lines of Java. Adding more to it than that obfuscates any solution.