creating multiple rows

[pankaj semwal]

Hi,

Below is my code which creating multiples row.But i want only to create single row.
Can any body tell me where i am wrong .and how to solve this.

String stringQ = "insert into  upload_hr_doc (hr_id,pi_form,medical_form,nda_form,epf)  values(?,?,?,?,?)";
	con = ConnectionFactory.getConnection();
	//int i = 0;
	int j=0;
	boolean bflag = false;
	try {
	    PreparedStatement preparedStatement = con.prepareStatement(stringQ);
	    System.out.println("="+hrId);		
	        preparedStatement.setInt(1, hrId);
	        for (String n : uploadFileNames)  
	        {
		preparedStatement.setString(2, n);
		preparedStatement.setString(3, n);
		preparedStatement.setString(4, n);
		preparedStatement.setString(5, n);
		j = preparedStatement.executeUpdate();
	        }
		

Thanks

[Paul Sturrock]

You are running you insert statement in a loop.

[Leonardo Carreira]

Sir..

is looping insert statements good for implementation?..
any suggestion?...

Thanks in advance...

[Jeanne Boyarsky]

Leonardo Carreira wrote:is looping insert statements good for implementation?..
any suggestion?...

It's not the looping is bad if you want multiple rows. (Although using a batch insert would be better.)

Paul meant that your SQL inserts one row per filename. Since you expressed an interest in only having one row overall, he commented the loop would do more than that.

[pankaj semwal]

Then how to solve this problem.

Please tell me.

Thanks

[Vijitha Kumara]

pankaj semwal wrote:Then how to solve this problem.

What exactly you want to insert (in terms of number of records) apart from what Jeanne & Paul suggested? It depends on your requirement.

[Paul Clapham]

So your "uploadFileNames" is an array of four strings, and you want those four strings to be the last four of the five columns you will insert into one row? Then don't use a loop:

PreparedStatement preparedStatement = con.prepareStatement(stringQ);  
preparedStatement.setInt(1, hrId);  
preparedStatement.setString(2, uploadFileNames[0]);  
preparedStatement.setString(3, uploadFileNames[1]);  
preparedStatement.setString(4, uploadFileNames[2]);  
preparedStatement.setString(5, uploadFileNames[3]);  
j = preparedStatement.executeUpdate();  

[rk palleru]

Paul Clapham said correct answer.