Return object values from ArrayList

[Lori Gardner-Wilson]

Hello -

I am just starting to learn Java and am in a bit over my head.

I have an ArrayList (clientList) with Client objects.

How to I return the clientList with the attributes of the Client objects?

I've included code for the class that handles the serialization/deserialization and the testClass I'm using to return the data.

Test Code

  package services;


import java.util.*;

import domain.Client;

import junit.framework.TestCase;

public class ClientSvcImplTest extends TestCase {

	
	private Factory factory;
	
	protected void setUp()throws Exception {    
			super.setUp();
			factory = Factory.getInstance();
		}   
	
			
	public void testCreateClient()throws ServiceLoadException {
		
		System.out.println("ClientSvcImpl - Test Store Client");
		IClientSvc ics = (IClientSvc)factory.getService(IClientSvc.NAME);
		
		ArrayList<Client> clientList = new ArrayList<Client>();
		
		clientList.add(new Client("John ", "Doe ", 
				9922, null, 0, null, null, 0, 0, 0, null));
		
		ics.createClient(clientList);
		System.out.println(clientList);
	
	}
	

public void testLookupClient() throws ServiceLoadException {
	//should this return Client?
		System.out.println("ClientSvcImpl - Test Lookup Client");
		IClientSvc ics = (IClientSvc)factory.getService(IClientSvc.NAME);
		
		ArrayList<Client> clientList = new ArrayList<Client>();
		clientList.add(new Client("Fred", "Flintstone",
				0, null, 0, null, null, 0, 0, 0, null));
		
		clientList.add(new Client("Barney", "Rubble",
				0, null, 0, null, null, 0, 0, 0, null));
		
		clientList.add(new Client("Pebbles", "Wilson",
				0, null, 0, null, null, 0, 0, 0, null));
		try {
			ics.lookupClient(clientList);
			System.out.println(clientList);
			
		} catch (LookupClientException e) {
			e.printStackTrace();
		}
		
	}
	
	public void testModifyClient(){
		fail("Not yet implemented");
		System.out.println(" Modify Client test not yet implemented");
	}


	
} 

Code for serializing/deserializing - not done with the lookupClient code yet....not sure how to do this exactly

package services;

import java.io.*;
import java.util.*;

import domain.Client;

public class ClientSvcImpl<c> implements IClientSvc {
	
	
	public static ArrayList<Client> clientList = null;
	
	@SuppressWarnings("unchecked")
	public void createClient(Client c) throws CreateClientException {
		System.out.println("Entering method storeClient " + c.getFirstName() + c.getLastName() + c.getStreetNumber());
		
		if (clientList == null){
			clientList = new ArrayList<Client>();
		}
		
		File f = new File("client.ser");
		if(f.exists()) {
			try {
				//read using ObjectInputStream
				ObjectInputStream input = new ObjectInputStream (new
						FileInputStream("client.ser"));
				try {
					clientList = (ArrayList<Client>)input.readObject();
				} catch (ClassNotFoundException e) {
					// TODO Auto-generated catch block
					e.printStackTrace();
				}
				input.close();
				
				//add client to list
				clientList.add(c);
			
								
				//write using ObjectOutStream
				ObjectOutputStream output = new ObjectOutputStream (new
						FileOutputStream("client.ser"));
				output.writeObject(clientList);
				output.flush();
				output.close();
			}catch (IOException e) {
					System.out.println("Client object serialization IOException caught");
			}
		}
			else {
				try {
									
					//add client to list
					clientList.add(c);
					
					//create client.ser and write using ObjectOutputStream
					ObjectOutputStream output = new ObjectOutputStream (new
							FileOutputStream("client.ser"));
					output.writeObject(clientList);
					output.flush();
					output.close();
					
			}catch (IOException e) {
				System.out.println("Client object serialization IOException caught");
			}
	}
}
	
	//need to change all of this
	public Client lookupClient(String firstName, String lastName, int streetNumber)
			throws LookupClientException {
		
		[b]//why is client null here??   Because it hasn't been specified yet?[/b]
		Client c = null;
		try {
			ObjectInputStream input = new
				ObjectInputStream(new
					FileInputStream("client.ser"));
			//when I change client.ser to match serialization file name
			//then lookup client test fails.
			
			c = (Client)input.readObject();
			input.close();
		} catch (IOException e1){
			System.out.println("Client object deserialization IOException caught");
		} catch (ClassNotFoundException e2) {
			System.out.println("Caught ClassNotFound Exception when deserializing Client object");
		}
		return c;
	}
		
	

	
	public void modifyClient(String firstName, String lastName)
			throws ModifyClientException {
		// TODO Auto-generated method stub
	}

	@Override
	public void createClient(ArrayList<Client> clientList) {
		// TODO Auto-generated method stub
		
	}

	@Override
	public Client lookupClient(ArrayList<Client> clientList)
			throws LookupClientException {
		// TODO Auto-generated method stub
		return null;
	}
}
    

Thanks a ton.

[John de Michele]

Lori,

Welcome to JavaRanch!

It looks like you're using JUnit, and IIRC, JUnit tests are required to have a void return value. You may want to just use a normal Java class, so your methods can return ArrayList<Client> values.

John.

[Lori Gardner-Wilson]

Thanks I will try that.

[Campbell Ritchie]

And if you are using Eclipse, get rid of those default "return null;"s