What are the demerits of having datbase acces code in jsp?

[vishnu vyasan]

Hi Friends,

I am now working on a very old j2ee project where most of the project is developed using only jsp pages.
There are number of SQL query statements and database connection calls in each JSP pages.

now i know that its better to use the servlet's for accessing the DB. what are the demerits of having data access code in jsp, apart from code complexity? does this posses any security issues?

how can i move them in to a properties file?






best regards
vishnu

[Pat Farrell]

Sure, its not the current style, and the code maintenance issue is well known. But I don't understand your question.

My rule is:

If its ain't broke, don't fix it.

[David Newton]

Pat Farrell wrote: If its ain't broke, don't fix it.

...

If you never have to work on the code, that (might) be a reasonable approach. If you do, however, the cost of a naive translation into JSP/Servlets is trivially recovered with the first one or two times you have to deal with the code. IMO just having the ability to have JavaDocs (hence discoverability) is already worth the effort, which is very low.

IMO code like that is broken by definition.

vishnu vyasan wrote: how can i move them in to a properties file?

Move what into property files?