JMenu Update

[xavier be]

Hi guy's

i have a question about JMenuBar in Java on Os X
i'm programming a little application just for fun

Explaination about the program and my problem :

I have a login part and a menu part
when i'm not logged in the menu is like "File - New - Profile - ?"
this is in my menuBar

but everything in NEW and in PROFILE are disabled ( because you can only use this option when you'r logged)
my code is :

   public class MenuGui extends JMenuBar{
	
	
	
	private JMenuBar menuBar = new JMenuBar();
	private JMenu fichier= new JMenu("Fichier");
	private JMenu nouveau = new JMenu("Nouveau");
	private JMenu profils = new JMenu("Profils");
	private JMenu help = new JMenu("?");
	
	private JMenuItem quitter = new JMenuItem("Quitter");
	private JMenuItem nouveauC = new JMenuItem("Nouveau Client");
	private JMenuItem nouveauP = new JMenuItem("Nouveau Colaborateur");
	private JMenuItem nouveauEn = new JMenuItem("Nouvelle Entreprise");
	private JMenuItem nouveauComp = new JMenuItem("Nouvelle Fiche Comptable");
	private JMenuItem nouveauAdmin = new JMenuItem("Nouvel Administrateur");
	private JMenuItem modificationAdmin = new JMenuItem("Modifier Mon Profil");
	private JMenuItem aide = new JMenuItem("Aide");
	private JMenuItem propos = new JMenuItem("A propos");
	private boolean passed = false;
	
	static {
	    System.setProperty("apple.laf.useScreenMenuBar", "true"); // this method put mac menu !  ######## ONLY FOR MAC #########
	  }
	
	private JMenuBar initMenuLog(){ // once loggon is OK we can load this menu
		
		if(passed == false){    // first time opening programm 
		nouveau.add(nouveauC);
		nouveau.add(nouveauP);
		nouveau.add(nouveauComp);
		nouveau.add(nouveauEn);
		nouveau.add(nouveauAdmin);
		profils.add(modificationAdmin);
		fichier.add(quitter);
		help.add(aide);
		help.add(propos);
		}
		
		if(InitLogin.logged == 1){  // if logged 
			System.out.println(InitLogin.logged);
			
			nouveauC.setEnabled(true);
			nouveauP.setEnabled(true);
			nouveauComp.setEnabled(true);
			nouveauEn.setEnabled(true);
			nouveauAdmin.setEnabled(true);
			modificationAdmin.setEnabled(true);
			
			
		}
		else{
			System.out.println(InitLogin.logged); // before logged
			
			nouveauC.setEnabled(false);
			nouveauP.setEnabled(false);
			nouveauComp.setEnabled(false);
			nouveauEn.setEnabled(false);
			nouveauAdmin.setEnabled(false);
			modificationAdmin.setEnabled(false);
			passed = true;
			
		}
		
		menuBar.removeAll();
		menuBar.add(fichier);
		menuBar.add(nouveau);
		menuBar.add(profils);
		menuBar.add(help);
		
		
		menuBar.updateUI(); // every case update menu
		return menuBar;
	}
	public JMenuBar setMenuBar(){
		return initMenuLog();
	}
	
}
 

as you can see I disable the items that i don't need before login
but after ... i call this method back and .... in theory this items are ENABLE but ...
it doesn't work

i hope you'll help me

thanks

[Nathan Pruett]

Not sure that this is a Mac issue - probably a general Swing issue....


How are you calling these methods to set up the menu bar? Is it on the event thread? If not, that's why the visual state of the JMenuBar isn't updating correctly.

[xavier be]

actually i just call it like
(thanks for your answer)

   	if(getPseudo().equals(user.getLogin_admin())){
		if(getPass().equals(user.getPassword_admin())){
			System.out.println("System Granted");
			logged++; 
			menuGui.setMenuBar();   // <======== This is my Call
		}
 

how do you call it on the event thread

[Nathan Pruett]

Hmmmm.... still not sure if it's on the event thread.

To call something on the event thread it either gets called from a listener, or through a Runnable that gets invoked through SwingUtilities.invokeLater()/invokeAndWait() (or uses SwingWorker,etc. which uses invokeLater/invokeAndWait).

Instead of embedding all this code directly in a JMenuBar subclass, it would probably be better to write this code as a listener for whatever component the user uses to login - or at least this code should get called from that listener.

[Nathan Pruett]

Going to move this to the Swing/AWT forum, as I think it has more to do with this issue rather than being Mac specific.

[xavier be]

I tried this but

it's not working also
this is my login listener and it check the login and then
call the MenuGui.setMenuBar();

but... nothing i don't get any updates :s

 class LoginListener  implements ActionListener{
	 
    
	public void actionPerformed(ActionEvent e) {
		checkLogin();
		menuGui.setMenuBar();
	}
    
}   

[Michael Dunn]

if the component (frame) is already visible, any time you add or remove components,
you need to validate/revalidate the container and most times also call repaint.

so your code should look something like this

    
 class LoginListener  implements ActionListener{

	public void actionPerformed(ActionEvent e) {
		checkLogin();
		menuGui.setMenuBar();
                menuGui.revalidate();//<--------
                menuGui.repaint();//<--------
	}
    
}   

[xavier be]

I tried like you said ... but not working
actually

in my Gui class i have this

   
	Gui(){
		this.setTitle("Acva Client Manager");
		//this.setSize(1000, 1000);
		this.setExtendedState(MAXIMIZED_BOTH);  // this put the JFrame size at the maximum of the screen size.
		this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		this.setLocationRelativeTo(null);
		this.setContentPane(container);
		this.setJMenuBar(menuGui.setMenuBar());    // <--- here  
		InitMenuLogin();
		this.setVisible(true);
		
	} 

as you can see i call my setJMenuBar ...
and my setMenuBar() method return a JMenuBar

so when i call it from my class Login
( from the eventListener )
i don't use the return ... ( i was thinking that revalidate(); and repaint(); will work ) but no ...
and i really don't get it.

when i open my programm i have a menu ( like i said here above ) by calling a method
some parts of this menu are hidden this is my class :

 
package gui;
import bl.*;
import db.*;
import javax.swing.*;
import java.awt.*;


public class MenuGui extends JMenuBar{
	
	// this menu is never integrated actually ! first i have to load it on windows !
	
	private JMenuBar menuBar = new JMenuBar();
	private JMenu fichier= new JMenu("Fichier");
	private JMenu nouveau = new JMenu("Nouveau");
	private JMenu profils = new JMenu("Profils");
	private JMenu help = new JMenu("?");
	
	private JMenuItem quitter = new JMenuItem("Quitter");
	private JMenuItem nouveauC = new JMenuItem("Nouveau Client");
	private JMenuItem nouveauP = new JMenuItem("Nouveau Colaborateur");
	private JMenuItem nouveauEn = new JMenuItem("Nouvelle Entreprise");
	private JMenuItem nouveauComp = new JMenuItem("Nouvelle Fiche Comptable");
	private JMenuItem nouveauAdmin = new JMenuItem("Nouvel Administrateur");
	private JMenuItem modificationAdmin = new JMenuItem("Modifier Mon Profil");
	private JMenuItem aide = new JMenuItem("Aide");
	private JMenuItem propos = new JMenuItem("A propos");
	private boolean passed = false;
	
	static {
	    System.setProperty("apple.laf.useScreenMenuBar", "true"); // this method put mac menu !  ######## ONLY FOR MAC #########
	  }
	
	private JMenuBar initMenuLog(){ // once loggon is OK we can load this menu
		
		if(passed == false){    // first time opening programm 
		nouveau.add(nouveauC);
		nouveau.add(nouveauP);
		nouveau.add(nouveauComp);
		nouveau.add(nouveauEn);
		nouveau.add(nouveauAdmin);
		profils.add(modificationAdmin);
		fichier.add(quitter);
		help.add(aide);
		help.add(propos);
		
		}
		
		if(InitLogin.logged == 1){  // if logged 
			System.out.println(InitLogin.logged);
			nouveauC.setEnabled(true);
			nouveauP.setEnabled(true);
			nouveauComp.setEnabled(true);
			nouveauEn.setEnabled(true);
			nouveauAdmin.setEnabled(true);
			modificationAdmin.setEnabled(true);
		
			
			
		}
		else{
			System.out.println(InitLogin.logged); // before logged
			
			nouveauC.setEnabled(false);
			nouveauP.setEnabled(false);
			nouveauComp.setEnabled(false);
			nouveauEn.setEnabled(false);
			nouveauAdmin.setEnabled(false);
			modificationAdmin.setEnabled(false);
			passed = true;
			
		}
		
		menuBar.removeAll();
		menuBar.add(fichier);
		menuBar.add(nouveau);
		menuBar.add(profils);
		menuBar.add(help);
	
		
		return menuBar;
	}
	public JMenuBar setMenuBar(){
		 
		return initMenuLog();
	}
	
}
   

when people wanted to login they enter the password and login and click on validate
my class Login is called and the event is checked by

   class LoginListener  implements ActionListener{
	 
    
	public void actionPerformed(ActionEvent e) {
		checkLogin();   
		menuGui.setMenuBar();
		menuGui.revalidate();
		menuGui.repaint();
		
		
	}
    
} 

as we can see i check my loggin here and then ( it comes back above to the event to look to the Method set login )
as we can see above ( in my class ) i checke that i'm logged and ( i have a print in shell that i'm logged ) but
the hidden parts of the menu are appearing

  private void checkLogin(){
	
	user.getInfoAdmin();
	

	if(getPseudo().equals(user.getLogin_admin())){
		if(getPass().equals(user.getPassword_admin())){
			logged = 0; // so if i press two time loggin menu i never get value 2; ( remplace it by boolean !!!) 
			System.out.println("System Granted");
			logged++; // this variable is used to know if i'm already logged
			
				
			
		}
		else{
			System.out.println("Failure Password");
			logged = 0;
		}
	}
	else{
		System.out.println("Failure Pseudo");
		logged = 0;
	}
	
}  

[Michael Dunn]

looks like the basics of the problem is that menuGui is a JMenuBar ("extends JMenuBar"),
but it is not the menubar added to the frame.

the way you are disabling/enabling the menuItems (by remove/add), to me, is totally wrong,
but if you want it to work that way, the below code works

run the code, check items disabled, click 'Login' recheck items - should now be enabled

    
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
class Testing
{
  int loggedIn = 0;
  public void buildGUI()
  {
    final MenuGui menuBar = new MenuGui();
    JButton btn = new JButton("Login");
    JPanel p = new JPanel(new GridBagLayout());
    p.add(btn,new GridBagConstraints());
    final JFrame f = new JFrame();
    f.getContentPane().add(p);
    f.setSize(400,300);
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setJMenuBar(menuBar.setMenuBar());
    f.setVisible(true);
    btn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        loggedIn = 1;
        f.setJMenuBar(menuBar.setMenuBar());//<----------reset menuBar
        f.validate();//<----for frame, validate()
      }
    });
  }
  class MenuGui{ //extends JMenuBar{
    private JMenuBar menuBar = new JMenuBar();
    private JMenu fichier= new JMenu("Fichier");
    private JMenu nouveau = new JMenu("Nouveau");
    private JMenu profils = new JMenu("Profils");
    private JMenu help = new JMenu("?");
    private JMenuItem quitter = new JMenuItem("Quitter");
    private JMenuItem nouveauC = new JMenuItem("Nouveau Client");
    private JMenuItem nouveauP = new JMenuItem("Nouveau Colaborateur");
    private JMenuItem nouveauEn = new JMenuItem("Nouvelle Entreprise");
    private JMenuItem nouveauComp = new JMenuItem("Nouvelle Fiche Comptable");
    private JMenuItem nouveauAdmin = new JMenuItem("Nouvel Administrateur");
    private JMenuItem modificationAdmin = new JMenuItem("Modifier Mon Profil");
    private JMenuItem aide = new JMenuItem("Aide");
    private JMenuItem propos = new JMenuItem("A propos");
    private boolean passed = false;
    private JMenuBar initMenuLog(){
      if(passed == false){
      nouveau.add(nouveauC);
      nouveau.add(nouveauP);
      nouveau.add(nouveauComp);
      nouveau.add(nouveauEn);
      nouveau.add(nouveauAdmin);
      profils.add(modificationAdmin);
      fichier.add(quitter);
      help.add(aide);
      help.add(propos);
      }
      if(loggedIn == 1){  // if logged
        nouveauC.setEnabled(true);
        nouveauP.setEnabled(true);
        nouveauComp.setEnabled(true);
        nouveauEn.setEnabled(true);
        nouveauAdmin.setEnabled(true);
        modificationAdmin.setEnabled(true);
      }
      else{
        nouveauC.setEnabled(false);
        nouveauP.setEnabled(false);
        nouveauComp.setEnabled(false);
        nouveauEn.setEnabled(false);
        nouveauAdmin.setEnabled(false);
        modificationAdmin.setEnabled(false);
        passed = true;
      }
      menuBar.removeAll();
      menuBar.add(fichier);
      menuBar.add(nouveau);
      menuBar.add(profils);
      menuBar.add(help);
      return menuBar;
    }
    public JMenuBar setMenuBar(){
      return initMenuLog();
    }
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}

[xavier be]

( i'll try it in a few moments or maybe tomorow morning depends of my work )

you said that it's totally wrong ... i don't know another type to do it
if you have something better just say it ... i like to learn new ways ;)

[Michael Dunn]

I'm off to golf now so just a quick reply:

all you need is to disable them, then enable them when logged in.
one way might be to put a reference to each menuitem (to be dis/enabled)
in an array, then create a method

public void enableMenuItems(boolean state)
{
   for(...)//iterate array
  {
    comp.setEnabled(state);
  }
}

call this method after you create the menuBar (with false for state)
call it again after login (with true for state)

[Michael Dunn]

simple demo of prior post

note there's no need to remove, then add back the menuItems

   
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
class Testing
{
  public void buildGUI()
  {
    final MenuGui menuBar = new MenuGui();
    JButton btn = new JButton("Login");
    JPanel p = new JPanel(new GridBagLayout());
    p.add(btn,new GridBagConstraints());
    final JFrame f = new JFrame();
    f.getContentPane().add(p);
    f.setSize(400,300);
    f.setLocationRelativeTo(null);
    f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    f.setJMenuBar(menuBar.setMenuBar());
    f.setVisible(true);
    btn.addActionListener(new ActionListener(){
      public void actionPerformed(ActionEvent ae){
        //if(login successful)
        menuBar.enableMenuItems(true);//<--------------all you need to call if login OK
      }
    });
  }
  class MenuGui{ //extends JMenuBar{
    private JMenuBar menuBar = new JMenuBar();
    private JMenu fichier= new JMenu("Fichier");
    private JMenu nouveau = new JMenu("Nouveau");
    private JMenu profils = new JMenu("Profils");
    private JMenu help = new JMenu("?");
    private JMenuItem quitter = new JMenuItem("Quitter");
    private JMenuItem nouveauC = new JMenuItem("Nouveau Client");
    private JMenuItem nouveauP = new JMenuItem("Nouveau Colaborateur");
    private JMenuItem nouveauEn = new JMenuItem("Nouvelle Entreprise");
    private JMenuItem nouveauComp = new JMenuItem("Nouvelle Fiche Comptable");
    private JMenuItem nouveauAdmin = new JMenuItem("Nouvel Administrateur");
    private JMenuItem modificationAdmin = new JMenuItem("Modifier Mon Profil");
    private JMenuItem aide = new JMenuItem("Aide");
    private JMenuItem propos = new JMenuItem("A propos");

    public void enableMenuItems(boolean state)//<----------------------
    {
      JMenuItem[] items = {nouveauC,nouveauP,nouveauComp,nouveauEn,nouveauAdmin,modificationAdmin};
      for(int x = 0, y = items.length; x < y; x++) items[x].setEnabled(state);
    }

    private JMenuBar initMenuLog(){
      nouveau.add(nouveauC);
      nouveau.add(nouveauP);
      nouveau.add(nouveauComp);
      nouveau.add(nouveauEn);
      nouveau.add(nouveauAdmin);
      profils.add(modificationAdmin);
      fichier.add(quitter);
      help.add(aide);
      help.add(propos);
      menuBar.add(fichier);
      menuBar.add(nouveau);
      menuBar.add(profils);
      menuBar.add(help);
      enableMenuItems(false);//<--------------
      return menuBar;
    }
    public JMenuBar setMenuBar(){
      return initMenuLog();
    }
  }
  public static void main(String[] args)
  {
    SwingUtilities.invokeLater(new Runnable(){
      public void run(){
        new Testing().buildGUI();
      }
    });
  }
}
 

[xavier be]

Very sorry for not answering during all this time ...
and thanks for your post


i saw that you run everything in a thread this actually a nice solution ( and workig solution )
i saw also your array wich is a very good idea i'll try it