GUI number guessing game program

[Kathleen Tillman]

Ok, so here's the issue. I can compile and run it fine, but when I load the game, it will only take one guess and will let me go no further. In other words, it asks for my guess and I enter say "45", and it says "Too high." Well, I enter another number, but then it won't go anywhere. Can you look at the code below and help me? Also, if anyone could give me any hints as to how to show the number of guesses a user has made so far, it would be greatly appreciated. Thanks!
I was wrong, it will let me move, but the number is constantly "Too High" and won't change. Any help would be appreciated.

import java.awt.Color;
import java.awt.FlowLayout;
import java.awt.Graphics;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import java.util.Random;
import javax.swing.JFrame;
import javax.swing.JTextField;
import javax.swing.JLabel;
import javax.swing.JButton;
import javax.swing.SwingUtilities;


public class Test extends JFrame
{
    private int GuessOld = 0;   
    private int number; // application's number
    private JTextField guessInputJTextField; // user input field
    private JLabel prompt1JLabel; // first line of instruction
    private JLabel prompt2JLabel; // secon line of instructions
    private JLabel messageJLabel; // displays message of game status
    private JButton newGameJButton; // creates new game
    private Color background; // background color of application

        // set up GUI and initialize values
        public Test()
        {
            super( "Guessing Game" );


                setLayout(new FlowLayout());
                background = Color.LIGHT_GRAY; // set background to light gray

                prompt1JLabel = new JLabel( "I have a number between 1 and 1000." ); // describe game
                add(prompt1JLabel);
                prompt2JLabel = new JLabel( "Can you guess my number? Enter your Guess:" ); // prompt user
                add(prompt2JLabel);

                guessInputJTextField = new JTextField( 5 ); // to enter guesses
                guessInputJTextField.addActionListener( new GuessHandler( ) );
                add(guessInputJTextField);
       
                messageJLabel = new JLabel( "" );
                add(messageJLabel);


                newGameJButton = new JButton( "New Game" ); // create "New Game" button
                add ( newGameJButton ); // add newGame button to JFrame
               
                Random generator = new Random();
                int number = generator.nextInt(1001);//create random number
               
                newGameJButton.addActionListener(

                        new ActionListener() // anonymous inner class
                        {
                        public void actionPerformed( ActionEvent e )
                        {
                                               
                            guessInputJTextField.setText("");
                            Random generator = new Random();
                            messageJLabel.setText("");
                            guessInputJTextField.setEditable(true);


                           
                           
                        } // end method actionPerformed
                        } // end anonymous inner class
                        ); // end call to addActionListener
               
   
                theGame(); // start new game
                } // end GuessGameFrame constructor

       

               

            // choose a new random number
        public void theGame()
        {
   
        } // end method theGame

        // change background color
        public void paint( Graphics g )
        {
                super.paint( g );
                getContentPane().setBackground( background ); // set background
        } // end method paint
   		class GuessHandler implements ActionListener{    
		   public void actionPerformed( ActionEvent e )
            {
               
            int Guess;
               
               Guess = Integer.parseInt(guessInputJTextField.getText());
               
              if ( Math.abs( number - Guess ) < Math.abs( number - GuessOld) ){
                // Hotter
                getContentPane().setBackground(Color.RED);
            }
            else{
                                   
                // Colder
                getContentPane().setBackground(Color.BLUE);
            }
                GuessOld = Guess;
                if ( Guess >= number )
                {
                    messageJLabel.setText( "Too High." );
                    SwingUtilities.updateComponentTreeUI(messageJLabel);
                }
               
                if( Guess <= number )
                    {
                                   
                        messageJLabel.setText( "Too Low." );
                        SwingUtilities.updateComponentTreeUI(messageJLabel);
                   
                } // end if
                   
                       
               
                if ( Guess < number + 1 && Guess > number-1 ) // guess is too low
                        {
                            messageJLabel.setText( "Correct!" );
                            SwingUtilities.updateComponentTreeUI(messageJLabel);
                            guessInputJTextField.setEditable(false);
                           
                               
                               

                        }
                           
                   
                   
                }

            }

Add the section that makes the program run...

import javax.swing.JFrame;

public class GuessgameTest{
	public static void main(String args[]) throws Exception{
		Test guessgame = new Test();
		guessgame.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
		guessgame.setSize(550, 150);
		guessgame.setVisible(true);
		}
	}

[Rob Spoor]

Usually you would use a loop for something like this. Seeing as you're executing your code on the Event Dispatcher thread, that may cause some painting problems, so you could also trigger another button press from code:

newGameJButton.doClick();

Also, there are two small errors in your code:

if ( Guess >= number )
...
if( Guess <= number )   

Shouldn't that be > and < respectively, not >= and <=? Because if Guess == number, the bodies of both if-statements are executed - but the guess is right!

Also,

 if ( Guess < number + 1 && Guess > number-1 )

is equal to

if (Guess == number)

since both Guess and number are ints.

[Kathleen Tillman]

Ok, so I changed the guess problems. Thanks for the help on that!!
The problem I seem to be having though is that the program won't recognize that I've put a different number in. (i.e. I'll put the number 45 in and the program will say "Too High", so I'll put the number 33 in and it'll again say "Too High", all the way down to number 1, which will again say "Too High". Obviously my program is not working correctly somewhere, but I cannot for the life of me figure out where.

Also, I'm not quite sure I understand what you mean with the button

newGameJButton.doClick();

What would that be used for and where?

Thanks,
Kat

[Michael Dunn]

the main problem seems to be that 'number' is always 0
private int number; // application's number

put in some System.out.println's to confirm (put them in the actionListener)
then go through the constructor to find out why.

[David Sharpe]

I think Michael has already helped with why your program isn't working, so I'm not going to comment on that.

However, I do wonder why you're calling "SwingUtilities.updateComponentTreeUI(Component)". Your program seems to work fine without it. It'll definitely slow you down if you use mysterious functions: "I don't know what it does, but it seems to be working." (Also known as "programming by coincidence," or more simply, voodoo.)

The API for that method is here, by the way. If you don't understand its description, that's a clue to not use it.

[Kathleen Tillman]

Thank you all for your help!

I finally got the program working meaning that it actually recognizes the different numbers.

I have only one more problem and I'm hoping someone can lead me in the right direction:
I need to post how many guesses the person has attempted and I'm kind of at a loss as to how to do that.

Any insight would be great, thanks!

Kat

[David Sharpe]

Well, you're using "private int number" to keep track of the "secret number," so you need something similar to keep track of the number of guesses.

You're using labels, e.g. "messageJLabel.setText('Too High.')" to display hints, so you can use a label to display the number of guesses so far.


p.s. Since "JLabel.setText(String)" expects a String and not an "int", you'll need to convert to display the number of guesses.

[Kathleen Tillman]

Ok, I added the Guesses = 0 and the Guesses++ to my program. The problem I'm having (at least I think) is I can't figure out where to put the JLabel so that the integer "Guesses" will actually move up. Right now, it just shows Number of Guesses = 0 when I run the program and the number never changes. Here's what I have.
Constructor portion:

import java.awt.Color;
import java.awt.FlowLayout;
import java.awt.Graphics;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import java.util.Random;
import javax.swing.JFrame;
import javax.swing.JTextField;
import javax.swing.JLabel;
import javax.swing.JButton;
import javax.swing.SwingUtilities;


public class GuessTheNumber extends JFrame
{
  	 private int Guesses = 0;  
	 private int GuessOld = 0;   
    private int number; // application's number
    private JTextField guessInputJTextField; // user input field
    private JLabel prompt1JLabel; // first line of instruction
    private JLabel prompt2JLabel; // second line of instructions
    private JLabel messageJLabel; // displays message of game status
	 private JLabel message2JLabel; //display number of guesses
	 private JLabel random1 = new JLabel("");
    private JButton newGameJButton; // creates new game
    private Color background; // background color of application

        // set up GUI and initialize values
        public GuessTheNumber()
        {
            super( "Guessing Game" );


                setLayout(new FlowLayout());
                background = Color.LIGHT_GRAY; // set background to light gray

                prompt1JLabel = new JLabel( "I have a number between 1 and 1000." ); // describe game
                add(prompt1JLabel);
                prompt2JLabel = new JLabel( "Can you guess my number? Enter your Guess:" ); // prompt user
                add(prompt2JLabel);

                guessInputJTextField = new JTextField( 5 ); // to enter guesses
                guessInputJTextField.addActionListener( new GuessHandler( ) );
                add(guessInputJTextField);
       
                messageJLabel = new JLabel( "" );
                add(messageJLabel);
					 
					 message2JLabel = new JLabel( "" );
					 add(message2JLabel);


                newGameJButton = new JButton( "New Game" ); // create "New Game" button
                add ( newGameJButton ); // add newGame button to JFrame
	
               
                Random generator = new Random();
                number = generator.nextInt(1001);//create random number
					
                newGameJButton.addActionListener(

                        new ActionListener() // anonymous inner class
                        {
                        public void actionPerformed( ActionEvent e )
                        {
                                               
                            guessInputJTextField.setText("");
                            Random generator = new Random();
          						 int number = generator.nextInt(1001);
									 random1.setText("" + number );
									 SwingUtilities.updateComponentTreeUI(random1);                  
									 messageJLabel.setText("");
                            guessInputJTextField.setEditable(true);
									 Guesses++;
								
                           

                           
                           
                        } // end method actionPerformed
                        } // end anonymous inner class
                        ); // end call to addActionListener
               
   
                theGame(); // start new game
                } // end GuessGameFrame constructor

       

               

            // choose a new random number
        public void theGame()
        {
   
        } // end method theGame

        // change background color
    
   		class GuessHandler implements ActionListener{    
		   public void actionPerformed( ActionEvent e )
            {
               
				int Guess;
			
               
               Guess = Integer.parseInt(guessInputJTextField.getText());
		      if ( Math.abs( number - Guess ) < Math.abs( number - GuessOld) ){
                // Hotter
                getContentPane().setBackground(Color.RED);

            }
            else{
                                   
                // Colder
                getContentPane().setBackground(Color.BLUE);
            }
                GuessOld = Guess;
                if ( Guess > number )
                {
                    messageJLabel.setText( "Too High." );
                    SwingUtilities.updateComponentTreeUI(messageJLabel);
  
					 }
            
                if( Guess < number )
                    {
                                   
                        messageJLabel.setText( "Too Low." );
                        SwingUtilities.updateComponentTreeUI(messageJLabel);
                   
                }
				
					  // end if
                   
                       
               
                if ( Guess == number ) // guess is too low
                        {
                            messageJLabel.setText( "Correct!" );
                            SwingUtilities.updateComponentTreeUI(messageJLabel);
                            guessInputJTextField.setEditable(false);
									 	
                               
                               

                        }
                           
                 	 message2JLabel.setText("Number of Guesses: " + Guesses);  
                   
                }

            }
}

Program portion:

import javax.swing.JFrame;

public class GameGuessTheNumber{
	public static void main(String args[]) throws Exception{
		GuessTheNumber game = new GuessTheNumber();
		game.setDefaultCloseOperation( JFrame.EXIT_ON_CLOSE );
		game.setSize(550, 150);
		game.setVisible(true);
		}
	}

Any help given would be appreciated! Thanks!
Kat

[David Sharpe]

The "newGameJButton" action listener is run everytime the user clicks "New Game".

The "guessInputJTextField" action listener ("GuessHandler") is run everytime the user makes a guess (i.e. hits "Enter" with the cursor in the text field).

[Vinay Berry]

 
package guessinggame;

import java.awt.Color;
import java.awt.FlowLayout;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import java.util.Random;
import javax.swing.JFrame;
import javax.swing.JTextField;
import javax.swing.JLabel;
import javax.swing.JButton;
import javax.swing.SwingUtilities;

public class Test extends JFrame {
	private int Guesses = 1;
	private int GuessOld = 0;
	private int number;   
	private JTextField guessInputJTextField;   
	private JLabel prompt1JLabel;
	private JLabel prompt2JLabel; 
	private JLabel messageJLabel;   
	private JLabel message2JLabel; 
	private JLabel random1 = new JLabel("");
	private JButton newGameJButton;   
	private Color background;   

	
	public Test() {
		super("Guessing Game");

		setLayout(new FlowLayout());
		background = Color.LIGHT_GRAY;   
		prompt1JLabel = new JLabel("I have a number between 1 and 1000.");  
		add(prompt1JLabel);
		prompt2JLabel = new JLabel("Can you guess my number? Enter your Guess:"); 
		add(prompt2JLabel);
		guessInputJTextField = new JTextField(5); 
		guessInputJTextField.addActionListener(new GuessHandler());
		add(guessInputJTextField);
		messageJLabel = new JLabel("");
		add(messageJLabel);
		message2JLabel = new JLabel("");
		add(message2JLabel);
		newGameJButton = new JButton("New Game");   
		add(newGameJButton);

		Random generator = new Random();
		number = generator.nextInt(1001);  
		
		newGameJButton.addActionListener(
		new ActionListener()  
				{
					public void actionPerformed(ActionEvent e) {

						guessInputJTextField.setText("");
						Random generator = new Random();
						number = generator.nextInt(1001);
						random1.setText("" + number);
						SwingUtilities.updateComponentTreeUI(random1);
						messageJLabel.setText("");
						guessInputJTextField.setEditable(true);
						Guesses = 0;
						message2JLabel.setText("Number of Guesses: " + Guesses);
						Guesses++;
					}   
				} 
				);
		theGame();  
	}  
	
	public void theGame() {

	} 

	class GuessHandler implements ActionListener {
		public void actionPerformed(ActionEvent e) {

			int Guess;

			Guess = Integer.parseInt(guessInputJTextField.getText());
			
			if (Math.abs(number - Guess) < Math.abs(number - GuessOld)) {
				
				getContentPane().setBackground(Color.RED);

			} else {

				 
				getContentPane().setBackground(Color.BLUE);
			}
			GuessOld = Guess;
			if (Guess > number) {
				messageJLabel.setText("Too High.");
				SwingUtilities.updateComponentTreeUI(messageJLabel);

			}
			if (Guess < number) {

				messageJLabel.setText("Too Low.");
				SwingUtilities.updateComponentTreeUI(messageJLabel);

			}			  
			if (Guess == number) {
				messageJLabel.setText("Correct!");
				SwingUtilities.updateComponentTreeUI(messageJLabel);
				guessInputJTextField.setEditable(false);

			}
			message2JLabel.setText("Number of Guesses: " + Guesses++);
		}

	}
}   

 
package guessinggame;

import javax.swing.JFrame;

public class GuessGame {
	public static void main(String args[]) throws Exception {
		Test guessgame = new Test();
		guessgame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		guessgame.setSize(550, 150);
		guessgame.setVisible(true);
	}
}

I changed a few things and everything works