Pattern Matching Question

[Tariq Ahsan]

Hello,

The code below works for doing pattern matching. Wondering if there would be a better way where I do not have to create separate Pattern and Matcher objects the way I have it now.
Here's the code -

...
public boolean validation(String var){

boolean boolVal = true;
String errorCode = "C";
String validationMessage;

// Patterns

Pattern codePattern1 = Pattern.compile("[ALWX]");
Pattern codePattern2 = Pattern.compile("[DEMXY]");
Pattern errorCodePattern = Pattern.compile("[CTSU]");

// Matchers
		
Matcher codeMatcher1 = codePattern1.matcher(var);;
Matcher codeMatcher2 = codePattern2.matcher(var);
Matcher errorCodeMatcher = errorCodePattern.matcher(errorCode);
		
// Validations

if(codeMatcher1.matches()) {
			
      validationMessage = "INVALID CODE";
      return boolVal = false;
			
}
		
if((codeMatcher2.matches()) && (errorCodeMatcher.matches())) {
			
      validationMessage = "INVALID ERROR CODE FOR INPUT VALUE";
      return boolVal = false;
			
}
		
...

Thanks!

[Henry Wong]

Wondering if there would be a better way where I do not have to create separate Pattern and Matcher objects the way I have it now.

The string class has some convenience methods for regex. Under the covers, it still does create the pattern and matcher objects, but it will make your code shorter -- for example, the string class has a matches() method that will take a regex.

Henry

[Tariq Ahsan]

Hi Henry,

Thanks for your suggestion. In the line of using Pattern do you think the following code change would be an alternative of what I wanted?

...   
public boolean validation(String var){

boolean boolVal = true;
String errorCode = "C";
String validationMessage;

// Patterns

Pattern errorCodePattern = Pattern.compile("[CTSU]");

// Matchers
		
Matcher errorCodeMatcher = errorCodePattern.matcher(errorCode);
		
// Validations

if(Pattern.matches("[ALWX]", var)) {
			
      validationMessage = "INVALID CODE";
      return boolVal = false;
			
}
		
if(Pattern.matches("[DEMXY]", var) && errorCodeMatcher.matches()) {
			
      validationMessage = "INVALID ERROR CODE FOR INPUT VALUE";
      return boolVal = false;
			
}
		
...