aspose file tools*
The moose likes Beginning Java and the fly likes If statement please help Big Moose Saloon
  Search | Java FAQ | Recent Topics | Flagged Topics | Hot Topics | Zero Replies
Register / Login


Win a copy of Spring in Action this week in the Spring forum!
JavaRanch » Java Forums » Java » Beginning Java
Bookmark "If statement please help " Watch "If statement please help " New topic
Author

If statement please help

Fifi Akt
Greenhorn

Joined: Jul 09, 2009
Posts: 10
Hi everyone,

I am new at learning Java. I really need your help. Actually, I know it is easy for most of you, but I just really lost, can not figure that out. I am supposed to write a code which The program asks the user to enter two integers. Then it asks three questions: what's the product of the two integers, what's the quotient of the two integers, and what's the remainder of the division of the two integers. It inputs the answers to each of the question from the user, tells the user whether the answer was correct or worng, and finally prints a message that depends on how many correct answers the user provided.

I did the beginning, but I can not see the logic of if statements. The program supposed to say wrong or write in accordance with the users' answer. I can not provide wrong or right. How can I fix it? Thank you so much

Ulf Dittmer
Marshal

Joined: Mar 22, 2005
Posts: 42276
    
  64
Welcome to JavaRanch.

There may be other issues with the code, but these few lines are problematic:

int score1;
score1=a*b;
score1=in.nextInt();
if (score1!=true)

"score1" is an int - you can't compare it with a boolean (which is what "true" is); you can only compare it to another int. Also, the value of score1 is changed by two successive statements, so the first value (a*b) will be lost. I think you mean something like this:

int score1 = in.nextInt();
if (score1 != a *b)


As an aside, this forum is specifically for question about threads and synchronization (see its title). I'll move it to a more appropriate forum.


Ping & DNS - my free Android networking tools app
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39395
    
  28
Welcome to JavaRanch

Your code is difficult to read because you didn't notice the code button. I shall edit your post so you can see how much better it looks.

No, it is not easy for us; we had all sorts of problems when we started.

I would suggest you implement the changes Ulf has suggested, then tell us what happens.
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39395
    
  28
And never write != true or == true or != false or == false. They are all prone to nasty errors if you mistakenly write =.
fred rosenberger
lowercase baba
Bartender

Joined: Oct 02, 2003
Posts: 11406
    
  16

To elaborate on Campbell's last note... writing this is unnecessary:

all you have to write is

assuming that 'something' is a boolean (and if it's not, you'll get an error). The problem with writing it out is that if you forget one of the two '=' characters, you ASSIGN the literal value to your variable, and the if condition will ALWAYS evaluate to your literal.


There are only two hard things in computer science: cache invalidation, naming things, and off-by-one errors
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39395
    
  28
fred rosenberger wrote:To elaborate on Campbell's last note... writing this is unnecessary:
. . .
And to elaborate on Fred's last note . . . If you want something to be false you never writeAlways write
fred rosenberger
lowercase baba
Bartender

Joined: Oct 02, 2003
Posts: 11406
    
  16

and to elaborate on Campbell's elaboration of my elab.... oh... nevermind...

Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39395
    
  28
fred rosenberger wrote:
Fifi Akt
Greenhorn

Joined: Jul 09, 2009
Posts: 10
Thank you so much for your help. There is no enough word to explain my appreciation.
Campbell Ritchie
Sheriff

Joined: Oct 13, 2005
Posts: 39395
    
  28
You're welcome
 
I agree. Here's the link: http://aspose.com/file-tools
 
subject: If statement please help