jframe not accepting sql query..

[kunal vermaa]

i have a project in which i have created an object of "showrecord" jframe inside the "collect" jframe.. the "showrecord" class display all the record from the database.. but it is showing an SQL error.. please help me solve the problem..

collect class

  import javax.swing.*;
import javax.swing.border.*;
import java.lang.String;
import java.awt.*;
import java.sql.*;
import javax.swing.event.*;
import java.awt.event.*;
import java.util.*;
import java.text.*;

public class Collect extends JFrame 
{
            JTextField t1,t2,t3,t4,t5,t6,t8;
			JTextArea ta,ta1;
		    JLabel j1,j2,j3,j4,j5,j6,j9;
	        JButton b1,b2,b3;
			JPanel jp,jp1,jp2;
			ImageIcon icon = new ImageIcon("image3.gif");

      public Collect()
	          {
	            setTitle("B H E L");
                setSize(600,425);
                setLocation(370,150);
                setResizable(false);
				
				j9=new JLabel("",icon,JLabel.LEFT);
				j1=new JLabel("   Bharat Heavy Electricals Limited");
				j1.setForeground(Color.black);
				j2=new JLabel("    ________________________________________________________");
				j2.setForeground(Color.black);
				j3=new JLabel("        Machine Collection");
				j3.setForeground(Color.black);
				Font f=new Font("Cosmic sans", Font.PLAIN , 22);
                j3.setFont(f);
				Font f1=new Font("Cosmic sans", Font.BOLD , 24);
				j1.setFont(f1);
				j4=new JLabel("Machine no");
				j5=new JLabel("Receiver's Name");
				j6=new JLabel("Date of Collection");
				
				Font f2=new Font("Cosmic sans", Font.PLAIN , 18);
			
				
				b1=new JButton("Show");
				b2=new JButton("Cancel");

				
		
				t4=new JTextField(20);
				t5=new JTextField(20);
				t6=new JTextField(20);
				
				
 				b1.addActionListener(new ActionListener(){
 	            public void actionPerformed(ActionEvent ae)
                        { 
				
			 try
				  {
				  
				  	 String str = t4.getText();
					 Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
					 Connection con=DriverManager.getConnection("jdbc:odbc:Machines","","");
		             PreparedStatement st=con.prepareStatement("Update Table1 set Receiver's Name=?,Date of Complaint=? where Machine No = str");
					 st.setString(1,t5.getText());
					 st.setString(2,t5.getText());
					
					 st.executeUpdate();
					 
					 ShowRecord s = new ShowRecord();
					 
				     con.close();
				
				  }
				catch(Exception e)
	   				{
			          System.out.println("Error "+e.getMessage());
					}
		}});
                           
		
		 b2.addActionListener(new ActionListener()
		 	{
 	             public void actionPerformed(ActionEvent ae)
                        { 
							 dispose();
						}
			});	
			
			
				Container c=getContentPane();
                c.setLayout(null);
				c.setBackground(Color.white);
                
				jp=new JPanel();
				jp.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp.setBackground(Color.white);
				jp.setBorder(BorderFactory.createEtchedBorder(getBackground().brighter(),getBackground().darker()));
				jp.add(j1);jp.add(j2);jp.add(j3);jp.add(j9);
				
						
				jp1=new JPanel();
				jp1.setBackground(Color.white);
				jp1.setBorder(BorderFactory.createEtchedBorder(getBackground().darker(),getBackground().brighter()));
				jp1.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp1.add(j4);jp1.add(j5);jp1.add(j6);
				jp1.add(t4);jp1.add(t5);jp1.add(t6);
				
				
				jp2=new JPanel();
				jp2.setBackground(Color.white);
				jp2.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp2.setBorder(BorderFactory.createEtchedBorder(getBackground().darker(),getBackground().brighter()));
				jp2.add(b1);jp2.add(b2);

				jp.setLayout(null);
				jp1.setLayout(null);
                jp2.setLayout(new BorderLayout());
				

				c.add(jp);c.add(jp1);c.add(jp2);

				jp.setBounds(5,5,580,100);
				jp1.setBounds(5,110,580,220);
				jp2.setBounds(5,335,580,50);

				
				j1.setBounds(120,20,500,25);
				j2.setBounds(120,25,500,35);
				j3.setBounds(150,45,3000,45);
				j4.setBounds(20,28,100,30);t4.setBounds(125,30,100,30);
				j5.setBounds(280,28,150,30);t5.setBounds(385,30,100,30);
				j6.setBounds(20,88,100,30);t6.setBounds(125,90,100,30);
				j9.setBounds(15,12,420,80);
				
			

				b1.setBounds(60,14,100,23);
				b2.setBounds(400,14,100,23);
				
			addWindowListener(new WindowAdapter()
			{
				public void windowClosing(WindowEvent e)
					{
						dispose();
					}
       		});
  		}
  
  
			public static void main(String args[])
   	         {		
	            Collect c=new Collect();
	            c.setVisible(true);		
	          }  
			  
			
}
		
  

showrecord class

   import javax.swing.*;
import javax.swing.border.*;
import java.lang.String;
import java.awt.*;
import java.sql.*;
import javax.swing.event.*;
import java.awt.event.*;
import java.util.*;
import java.text.*;

public class ShowRecord extends JFrame 
{
            JTextField t1,t2,t3,t4,t5,t6,t7,t8,t10;
			JTextArea ta,ta1;
		    JLabel j1,j2,j3,j4,j5,j6,j7,j8,j9,j10;
	        JButton b1;
			JPanel jp,jp1,jp2;
			ImageIcon icon = new ImageIcon("image3.gif");

      public ShowRecord()
	          {
	            setTitle("B H E L");
                setSize(600,425);
                setLocation(400,150);
                setResizable(true);
				
				j9=new JLabel("",icon,JLabel.LEFT);
				j1=new JLabel("   Bharat Heavy Electricals Limited");
				j1.setForeground(Color.black);
				j2=new JLabel("    ________________________________________________________");
				j2.setForeground(Color.black);
				j3=new JLabel("        Machine Record");
				j3.setForeground(Color.black);
				Font f=new Font("Cosmic sans", Font.PLAIN , 22);
                j3.setFont(f);
				Font f1=new Font("Cosmic sans", Font.BOLD , 24);
				j1.setFont(f1);
				j4=new JLabel("Machine no");
				j5=new JLabel("Vendor");
				j6=new JLabel("Date of Complaint");
				j7=new JLabel("Issuer's name");
				j8=new JLabel("Date of Collection");
				j10=new JLabel("Receiver's Name");
				
				
				b1=new JButton("Close");

				
		
				t4=new JTextField(15);
				t5=new JTextField(15);
				t6=new JTextField(15);				
				t7=new JTextField(15);
				t8=new JTextField(15);
				t10=new JTextField(15);
			
			try
				  {
					 Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
					 Connection con=DriverManager.getConnection("jdbc:odbc:Machines","","");
		             Statement st=con.createStatement();
					 ResultSet rs = st.executeQuery("Select * from Table1");
					 
					 while (rs.next()) 
					 {
					 t4.setText(rs.getString(2));
					 t5.setText(rs.getString(3));
					 t6.setText(rs.getString(4));
					 t7.setText(rs.getString(5));
					 t8.setText(rs.getString(6));
					 t10.setText(rs.getString(7));
					 }
					 
					 con.close();
				
				  }
				catch(Exception e)
	   				{
			          System.out.println("Error "+e.getMessage());
					}
		
                           
		
		 b1.addActionListener(new ActionListener()
		 	{
 	             public void actionPerformed(ActionEvent ae)
                        { 
							 dispose();
						}
			});	
			
			
				Container c=getContentPane();
                c.setLayout(null);
				c.setBackground(Color.white);
                
				jp=new JPanel();
				jp.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp.setBackground(Color.white);
				jp.setBorder(BorderFactory.createEtchedBorder(getBackground().brighter(),getBackground().darker()));
				jp.add(j1);jp.add(j2);jp.add(j3);jp.add(j9);
				
						
				jp1=new JPanel();
				jp1.setBackground(Color.white);
				jp1.setBorder(BorderFactory.createEtchedBorder(getBackground().darker(),getBackground().brighter()));
				jp1.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp1.add(j4);jp1.add(j5);jp1.add(j6);jp1.add(j7);jp1.add(j8);jp1.add(j10);
				jp1.add(t4);jp1.add(t5);jp1.add(t6);jp1.add(t7);jp1.add(t8);jp1.add(t10);
				
				
				jp2=new JPanel();
				jp2.setBackground(Color.white);
				jp2.setBorder(BorderFactory.createLineBorder(Color.black,1));
				jp2.setBorder(BorderFactory.createEtchedBorder(getBackground().darker(),getBackground().brighter()));
				jp2.add(b1);

				jp.setLayout(null);
				jp1.setLayout(null);
                jp2.setLayout(new BorderLayout());
				

				c.add(jp);c.add(jp1);c.add(jp2);

				jp.setBounds(5,5,580,100);
				jp1.setBounds(5,110,580,220);
				jp2.setBounds(5,335,580,50);

				
				j1.setBounds(120,20,500,25);
				j2.setBounds(120,25,500,35);
				j3.setBounds(150,45,3000,45);
				j4.setBounds(20,28,100,30);t4.setBounds(125,30,100,30);
				j5.setBounds(280,28,150,30);t5.setBounds(385,30,100,30);
				j6.setBounds(20,88,100,30);t6.setBounds(125,90,100,30);
				j7.setBounds(280,88,150,30);t7.setBounds(385,90,100,30);
				j8.setBounds(20,148,500,30);t8.setBounds(125,150,100,30);
				j9.setBounds(15,12,420,80);
				j10.setBounds(280,148,150,30);t10.setBounds(385,150,100,30);
				
				b1.setBounds(240,14,100,23);
				
				
			addWindowListener(new WindowAdapter()
			{
				public void windowClosing(WindowEvent e)
					{
						dispose();
					}
       		});
  		}
  
  
			public static void main(String args[])
   	         {		
	            ShowRecord r=new ShowRecord();
	            r.setVisible(true);		
	          }  
			  
			
}
		
 

please help..

[Rob Camick]

> but it is showing an SQL error..

1) Well, then that would be an SQL problem, not a Swing problem

2) And we are not mind readers. We can't exeucte your code since we can't access your database, so we have no idea what the "SQL error message" is.

[Rob Spoor]

Please http://faq.javaranch.com/java/TellTheDetails but also http://faq.javaranch.com/java/IsolateTheProblem

You have an SQL error, yet (as Rob C noticed) you haven't told us what SQL error. Either way, you can limit the code posted to the actual SQL code:

try
{
    String str = t4.getText();
    Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
    Connection con=DriverManager.getConnection("jdbc:odbc:Machines","","");
    PreparedStatement st=con.prepareStatement("Update Table1 set Receiver's Name=?,Date of Complaint=? where Machine No = str");
    st.setString(1,t5.getText());
    st.setString(2,t5.getText());
    st.executeUpdate();
    ShowRecord s = new ShowRecord();
    con.close();
}
catch(Exception e)
{
    System.out.println("Error "+e.getMessage());
}

try
{
    Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
    Connection con=DriverManager.getConnection("jdbc:odbc:Machines","","");
    Statement st=con.createStatement();
    ResultSet rs = st.executeQuery("Select * from Table1");
    while (rs.next()) 
    {
        t4.setText(rs.getString(2));
        t5.setText(rs.getString(3));
        t6.setText(rs.getString(4));
        t7.setText(rs.getString(5));
        t8.setText(rs.getString(6));
        t10.setText(rs.getString(7));
    }
    con.close();
}
catch(Exception e)
{
    System.out.println("Error "+e.getMessage());
}

Now we have less code to read, I think I see the error:

Update Table1 set Receiver's Name=?,Date of Complaint=? where Machine No = str

If a column name has spaces in it, you must put grouping characters around it. For ODBC, Access and MS SQL that's brackets:

Update Table1 set [Receiver's Name]=?,[Date of Complaint]=? where [Machine No] = str

Moving to JDBC.