Problem When Compressing Directory

Hi,

I am using the following code for compressing the content of the given folder--

private void zipFolder(final String dir, final String zipfile) {
		// Check that the directory is a directory, and get its contents
		File directory = new File(dir);
	
		if (!directory.isDirectory()) {
			LOG.error(directory.getName() + " Is Not A directory.");
		}
		
		ZipOutputStream out = null;
		FileInputStream fInputStream = null;
		
		String[] entries = directory.list();
		// Create a buffer for copying
		byte[] buffer = new byte[4096]; 
		int bytesRead;
	
		try {
			out = new ZipOutputStream(new FileOutputStream(zipfile));

for (int i = 0; i < entries.length; i++) {
				File file = new File(directory, entries[i]);
				if (file.isDirectory()) {
					// Ignore directory
					continue; 
				}
				
				fInputStream = new FileInputStream(file); 
				ZipEntry entry = new ZipEntry(file.getPath()); 
				out.putNextEntry(entry); 
				while ((bytesRead = fInputStream.read(buffer)) != -1) {
					out.write(buffer, 0, bytesRead);
				}
			}
			
		} catch (IOException ioe) {
		
			System.out.println("Exception During Compressing The Directory : " + directory.getName());
		
		} finally {
			
			if (fInputStream != null) {
				try {
					fInputStream.close();
				} catch (IOException e) {
					System.out.println("Error Occured When Closing fInputStream : " + e);
				}
			}
			
			if (out != null) {
				try {
					out.close();
				} catch (IOException e) {
					System.out.println("Error Occured When Closing ZipOutputStream : " + e);
				}
			}
		}
	}

Now suppose the folder to be zipped is -- c:\\ziptest\\zipdir

the output comes in this for way -- zipdir.zip and wen i unzip this the structure comes like c:\\ziptest\\zipdir, same as given dir.

Now what my need is that wen i unzip the zipdir.zip it just have the file , no directory structure.

Can you please help me out?

Thanks,
Kaya.

I haven't play with ZipXStream and stuff but think how you would zip dirs/files using WinZip directly.

If you right-click on the directory and click winzip - the whole directory gets added to the zip file. And this is apparently what you got so far. So I think you now need to get inside the directory level then add those files.

You just need to play around with the ZipEntry.

Change this from:

to:

Too difficult a question for beginners. Moving.

Thanks a lot Freddy Wong.

A technique I often* use when zipping a folder recursively is the following:

private void zipFolder(final String dir, final String zipfile)
{
    File directory = new File(dir);   
       
    if (!directory.isDirectory())
    {   
        LOG.error(directory.getName() + " Is Not A directory.");   
        return;
    }

try
    {
        ZipOutputStream out = new ZipOutputStream(new FileOutputStream(zipfile));   
        try
        {
            addToZip(out, directory, directory.getName());
        }
        finally
        {
            out.close();
        }
    }
    catch (IOException e)
    {
        System.out.println("Exception During Compressing The Directory : " + directory.getName());   
    }
}

private void addToZip(ZipOutputStream stream, File file, String name) throws IOException
{
    if (file.isFile())
    {
        FileInputStream in = new FileInputStream(file);
        try
        {
            // copy data; use name for the ZipEntry
        }
        finally
        {
            in.close();
        }
    }
    else if (file.isDirectory())
    {
        File[] entries = file.listFiles();
        if (entries != null) // prevent a NullPointerException if you can't read the folder contents
        {
            for (File f: entries)
            {
                String childName = name + "/" + f.getName();
                zip(out, f, childName);
            }
        }
    }
}

This recursive call will build a full path for the ZIP entry names; for example "root/folder/subfolder/file.ext". That way, the full directory structure will remain intact in the ZIP file.

* Well actually once. I've simply put the code in a common utility class

Hi Rob,
Many thanks, for your prompt reply. But i am still not getting it worked as per my need,
Have been trying to tweak the API for a long time now. Can you please be a little more elaborate.

Hi Rancher,
http://www.mkyong.com/java/how-to-compress-files-in-zip-format/comment-page-1/#comment-81940
this works perfectly as needed.

sadanand munswamy wrote:Hi Rob,
Many thanks, for your prompt reply. But i am still not getting it worked as per my need,
Have been trying to tweak the API for a long time now. Can you please be a little more elaborate.

If I take your example of zipping folder C:\dir1\dir2\dir3 from this thread.

Assume that inside dir3 there are files file1 and file2, and sub directory dir4 with files file3 and file4.
I will then start by calling addToZip with a File object for C:\dir1\dir2\dir3 and a name of "".
The method will see that the file argument is a directory. It will then iterate over its sub folders and files (let's call these f). This will cause method calls addToZip(stream, f, "file1"), addToZip(stream, f, "file2") and addToZip(stream, f, "dir4").
The first two method calls will end because the file argument will not be a directory.
The third one will see that the file argument is a directory, and iterate over its contents again. It will now call addToZip(stream, f, "dir4/file3") and addToZip(stream, f, "dir4/file4").

As a result, the ZIP file will contain the following files:
- file1
- file2
- dir4/file3
- dir4/file4