Whille loop

[Fifi Akt]

Hi everyone

I want to ask something. I wrote a code. But when I run it, it never stops. I do not know where I did wrong. If you have time, could you check it.
This is the question.
The program performs the following actions:

1. Generate a secret random number between 1 and 100 (see below how to do that), and print a message to communicate that to the user;

2. Repeatedly ask the user for a guess, and tell the user whether the guess is too big or too small compared to the secret number;

3. When the user finally guesses the correct number, print a message stating how many guesses were needed, and a message assessing the user's performance according to the following table:
This is the code I wrote;


i

mport java.util.Scanner;
public class lab4Part2 {

	public static void main(String[] args) {
		
	
		Scanner keyboard = new Scanner(System.in); //User input
		int userInt = (int)(100 * Math.random()) + 1; //Generates random number
		int x = (int)(100 * Math.random ()) + 1;
		int counter = 0;
		System.out.print("I am thinking of a number between 1 and 100.Try to guess it. ");
		System.out.println("What is your guess?");
		String userAns1 = keyboard.nextLine();
		while(userInt!=x){
			if(userInt<x){
				System.out.println("Your guess is too small.");
				System.out.println("What is your guess?");
			}
				else{
					System.out.println("Your guess is too big.");
					System.out.println("What is your guess?");	
				}
			counter++;
			}
		if(counter==1){
        System.out.println("You've got it in"+ counter+ "That was lucky!"); 

		}
		else if (counter >= 2 && counter <= 4){
			System.out.println("You've got it in"+ counter+ "That was amazing!");
				
		}
		else if(counter >= 5 && counter <= 6){
			System.out.println("You've got it in"+ counter+ "That was really good!");
		}
		else if(counter == 7)	{
			System.out.println("You've got it in " + counter + " guesses. That was ok!");
		}
		else if(counter >= 8 && counter <= 9){
			System.out.println("You've got it in " + counter + " guesses. That was pretty bad!");
		}
		else{
			System.out.println("You've got it in " + counter + " guesses. This is not your game!");
		}
		}
	}

[Jeanne Boyarsky]

Fifi,
"userAns1" isn't used inside the loop. Which means you are checking the value of userInt (which is the same) on each iteration through the loop.

[Andrew Monkhouse]

Aww, beat me by a few minutes. If I hadnt gone to see what the vacuum cleaner was stuck on I would have answered this already.



Also - think about where in the program you should be reading the input line. Right now you have it read once before you go into the loop - is that really desirable?

[Fifi Akt]

Thank you for your answer, I changed but It still does not seem correct. Where I am missing?

import java.util.Scanner;
public class lab4Part2 {

	public static void main(String[] args) {
		System.out.print("I am thinking of a number between 1 and 100.Try to guess it. ");
		System.out.println("What is your guess?");
			
		Scanner keyboard = new Scanner(System.in); //User input
		int x = (int)(100 * Math.random()) + 1; //Generates random number
		int userInt = keyboard.nextInt();
		int counter = 0;
		
		while(userInt!=x)
		{
			if(userInt<x){
				System.out.println("Your guess is too small.");
				System.out.println("What is your guess?");
			}
				else{
					System.out.println("Your guess is too big.");
					System.out.println("What is your guess?");	
				}
			counter++;
			keyboard.nextInt();
			}
	
		if(counter==1){
        System.out.println("You've got it in"+ counter+ "That was lucky!"); 

		}
		else if (counter >= 2 && counter <= 4){
			System.out.println("You've got it in"+ counter+ "That was amazing!");
				
		}
		else if(counter >= 5 && counter <= 6){
			System.out.println("You've got it in"+ counter+ "That was really good!");
		}
		else if(counter == 7)	{
			System.out.println("You've got it in " + counter + " guesses. That was ok!");
		}
		else if(counter >= 8 && counter <= 9){
			System.out.println("You've got it in " + counter + " guesses. That was pretty bad!");
		}
		else{
			System.out.println("You've got it in " + counter + " guesses. This is not your game!");
		}
		}
	}

[Andrew Monkhouse]

Where do you re-assign userInt?

[Fifi Akt]

Andrew Monkhouse wrote:Where do you re-assign userInt?

I am really new java. Really thank you for your patience.

# while(userInt!=x)
# {
# if(userInt<x){
# System.out.println("Your guess is too small.");
# System.out.println("What is your guess?");
# }
# else{
# System.out.println("Your guess is too big.");
# System.out.println("What is your guess?");
# }
# counter++;
# keyboard.nextInt();
# }

Do you mention the bold area? If not I think I do not understand >

[Andrew Monkhouse]

Yep - that is the right area. In particular, line 24: what are you assigning the result of keyboard.nextInt() to?

[Fifi Akt]

Thank you so much. I think I got it

[Samrat Som]

hi ..

Your program should look like this

while(userAns1!=x){
if(userAns1<x){
System.out.println("Your guess is too small.");
System.out.println("What is your guess?");
}
else{
System.out.println("Your guess is too big.");
System.out.println("What is your guess?");
}
counter++;
userAns1=keyboard.nextInt();
}

I feel now it shouls work fine ...because you were not validatng the user input in the loop

[David Newton]

@Samrat: we try not to provide explicit answers, but rather steer people in the right direction.

[Campbell Ritchie]

David Newton wrote:@Samrat: we try not to provide explicit answers, but rather steer people in the right direction.

We often delete such material, but by the time we noticed, it was too late to do anything about it.

[Samrat Som]

I am extremely sorry for this...My intention was not of that sort

[Campbell Ritchie]

Apologies accepted We have all done that sort of thing, myself included ( ). I am sure you won't do it again