Javamail: Problem sending attachments

have the following code for sending emails

Although the email content is absolutely fine, the attachement is not gettig attached. The email comes without an attachment. Can someone please let me know how to attach a file to this email

public static void main(String[] args) {
 
 String to = "ansha@lop.in";
 String from = "rvations <rs@els.com>";
 String host = "127.0.0.1";
 Properties props = new Properties();
 props.put("mail.smtp.host", host);
 props.put("mail.debug", "true");
 
 Session session = Session.getInstance(props);
 
 try {
 Transport bus = session.getTransport("smtp");
 bus.connect();
 Message msg = new MimeMessage(session);
 msg.setFrom(new InternetAddress(from)); 
 InternetAddress[] address = {new InternetAddress(to)};
 msg.setRecipients(Message.RecipientType.TO, address);
 msg.setRecipients(Message.RecipientType.BCC, InternetAddress.parse("ash@yahoo.com", true));
 msg.setSubject("Re irmation");
 msg.setSentDate(new Date());
 
 setFileAsAttachment(msg, "C:/2008.pdf");
 msg.saveChanges();
 
 setHTMLContent(msg);
 msg.saveChanges();
 bus.sendMessage(msg, address);
 
 bus.close();
 }
 catch (MessagingException mex) {
 mex.printStackTrace();
 while (mex.getNextException() != null) {
 Exception ex = mex.getNextException();
 ex.printStackTrace();
 if (!(ex instanceof MessagingException)) break;
 else mex = (MessagingException)ex;
 }
 }
 }
 
 public static void setFileAsAttachment(Message msg, String filename)
 throws MessagingException {
 
 MimeBodyPart p1 = new MimeBodyPart();
 MimeBodyPart p2 = new MimeBodyPart();
 
 FileDataSource fds = new FileDataSource(filename);
 p2.setDataHandler(new DataHandler(fds));
 p2.setFileName(fds.getName());
 
 Multipart mp = new MimeMultipart();
 mp.addBodyPart(p1);
 mp.addBodyPart(p2);
 
 msg.setContent(mp);
 }
 
public static void setHTMLContent(Message msg) throws MessagingException {
 
 String html = "<HTML><head><style><!-- @font-face{font-family:Latha;panose-1:2 11 6 4 2 2 2 2 2 4;
mso-font-charset:0;mso-generic-font-family:swiss;mso-font-pitch:variable;mso-font-signature:-2146435069 0 0 0 1 0;}
@font-face{font-family:'Cambria Math';panose-1:2 4 5 3 5 4 6 3 2 4;mso-font-charset:0;
mso-generic-font-family:roman;mso-font-pitch:variable;mso-font-signature:-1610611985 1107304683 0 0 159 0;}
@font-face{font-family:Calibri;panose-1:2 15 5 2 2 2 4 3 2 4;mso-font-charset:0;mso-generic-font-family:swiss;
mso-font-pitch:variable;mso-font-signature:-1610611985 1073750139 0 0 159 0;}
@font-face{font-family:Tahoma;panose-1:2 11 6 4 3 5 4 4 2 4;mso-font-charset:0;mso-generic-font-family:
swiss;mso-font-pitch:variable;mso-font-signature:1627400839 -2147483648 8 0 66047 0;}
@font-face{font-family:Consolas;panose-1:2 11 6 9 2 2 4 3 2 4;o book or for further information visit www.globom 
 this e-mail in error and that any use, dissemination, forwarding, printing or copying of this e-mail
is strictly prohibited. If you have received this e-mail in error, please delete it immediately.";
 
 msg.setDataHandler(new DataHandler(new HTMLDataSource(html)));
 }

I updated my code a bit.

If I do the following, I get only the attachment without the HTML body (html body part is commented)

the following gives me HTML body wihtout attachment

I need both. HTML body as well as an attachment.

Can someone please let me know how to solve this problem.

Thank you

In your first example, you add all attachments, but then you overwrite them with the body.

You must use a MimeMultiPart, and create one body part for the HTML and one for each attachment. The file body part will work just as the one you have now; the HTML body part will be similar to how you set the HTML contents for your message.

A similar problem, I have my body part working, if I comment the code to the the filename, attachment. I have created MultiMimePart for body and for attachment but still get the error. Any suggestions for this please

import javax.activation.DataHandler;
import javax.activation.FileDataSource;
import javax.mail.*;
import javax.mail.internet.*;
import java.util.*;
import java.io.*;

public class SendMailUsingAuthentication
{
	protected final String SMTP_AUTH_USER = "san";
    protected final String SMTP_AUTH_PWD  = "j@v@00";

public void postMail( String recipients[ ], String subject,
                            String message , String from,String emailSubjectTxt,String emailMsgTxt,String emailFromAddress,String filename) throws Exception
  {
      boolean debug = false;

//Set the host smtp address
     Properties props = new Properties();
     props.put("mail.smtp.host", "smtp.aaa.com");
     props.put("mail.smtp.auth", "true");
     props.put("mail.smtp.port", "25");

Authenticator auth = new SMTPAuthenticator();
    Session session = Session.getDefaultInstance(props, auth);

session.setDebug(debug);

// create a message
    javax.mail.Message msg = new MimeMessage(session);

// set the from and to address
    InternetAddress addressFrom = new InternetAddress(from);
    msg.setFrom(addressFrom);

InternetAddress[] addressTo = new InternetAddress[recipients.length];
 for (int i = 0; i < recipients.length; i++)
 {
 addressTo[i] = new InternetAddress(recipients[i]);
 }
 msg.setRecipients(javax.mail.Message.RecipientType.TO, addressTo);
 // Setting the Subject and Content Type
 msg.setSubject(emailSubjectTxt);
 msg.setSentDate(new Date());
 MimeBodyPart messagePart = new MimeBodyPart();
 messagePart.setText(emailMsgTxt);
 
 MimeBodyPart attachmentPart = new MimeBodyPart();
 FileDataSource fileDataSource = new FileDataSource(filename) {
 @Override
 public String getContentType() {
 return "application/octet-stream";
 }
 };	
 
 System.out.println("FIlename is" +filename);
 attachmentPart.setFileName(filename);
 Multipart multipart = new MimeMultipart();
 multipart.addBodyPart(messagePart);
 multipart.addBodyPart(attachmentPart);
 msg.setContent(multipart);
 try {
 Transport.send(msg);
 }
 catch (Exception e)
 {
 	throw (e);
 }
 }
 /**
 * SimpleAuthenticator is used to do simple authentication
 * when the SMTP server requires it.
 */
 private class SMTPAuthenticator extends javax.mail.Authenticator
 {

public PasswordAuthentication getPasswordAuthentication()
      {
          String username = SMTP_AUTH_USER;
          String password = SMTP_AUTH_PWD;
          return new PasswordAuthentication(username, password);
      }
  }

}

got the answer to my question, was setting the filename incorrectly, Its amazing how much you could learn by looking at the code of others...

truely amazing !

thanks !