Servlet Fileter issues

Hi,

I am working on servlet filter example. My filter CountryStopper.java servlet code looks like

which supposed to say
'only american spanish people can view this filetert '

otherwise if locale language is something else like chinese etc it should say
'we love people who speak : chinese '

etc

The AmericaFilter.java filter looks like

package com.american.web.filter;

import javax.servlet.Filter;
import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.FilterChain;
import java.io.IOException;

public class AmericanFilter implements Filter {
      /* (non-Java-doc)
       * @see javax.servlet.Filter#init(FilterConfig arg0)
       */
      public void init(FilterConfig arg0) throws ServletException {
            // TODO Auto-generated method stub
      }

/* (non-Java-doc)
       * @see javax.servlet.Filter#doFilter(ServletRequest arg0, ServletResponse arg1, FilterChain arg2)
       */
      public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
            String language=request.getLocale().getDisplayLanguage();
            if (language!= "spansih"){
                  response.getWriter().println("only american spanish people can view this filetert");
            }
            else{
                  response.getWriter().println("we love people who speak :"+ request.getLocale().getCountry());
                  
            }
            System.out.println("time ater serveltt is full"+System.currentTimeMillis());
      }

/* (non-Java-doc)
       * @see javax.servlet.Filter#destroy()
       */
      public void destroy() {
            // TODO Auto-generated method stub
      }

}

I am changing within the IE, google chrome etc browser tools options to chinese etc language
Even after refreshing or rerunning servlet
but it always displays like
'only american spanish people can view this filetert '

never i could see output like

we love people who speak : chinese etc

irrespective of change in browser locale setting in IE as well as google chrome

my web.xml looks like

<?xml version="1.0" encoding="UTF-8"?>
<web-app id="WebApp_ID" version="2.4" xmlns="http://java.sun.com/xml/ns/j2ee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd">
      <display-name>
      FilterProject</display-name>
      <filter>
            <description>
            </description>
            <display-name>
            AmericanFilter</display-name>
            <filter-name>AmericanFilter</filter-name>
            <filter-class>com.american.web.filter.AmericanFilter</filter-class>
      </filter>
      <filter-mapping>
            <filter-name>AmericanFilter</filter-name>
            <url-pattern>/AmericanFilter</url-pattern>
      </filter-mapping>
      <filter-mapping>
            <filter-name>AmericanFilter</filter-name>
            <servlet-name>CountryStopper</servlet-name>
            <dispatcher>REQUEST</dispatcher>
      </filter-mapping>
      <servlet>
            <servlet-name>action</servlet-name>
            <servlet-class>
            org.apache.struts.action.ActionServlet</servlet-class>
            <init-param>
                  <param-name>config</param-name>
                  <param-value>/WEB-INF/struts-config.xml</param-value>
            </init-param>
            <init-param>
                  <param-name>debug</param-name>
                  <param-value>2</param-value>
            </init-param>
            <init-param>
                  <param-name>detail</param-name>
                  <param-value>2</param-value>
            </init-param>
            <init-param>
                  <param-name>validate</param-name>
                  <param-value>true</param-value>
            </init-param>
            <load-on-startup>2</load-on-startup>
      </servlet>
      <servlet>
            <description>
            blah blah</description>
            <display-name>
            CountryStopper</display-name>
            <servlet-name>CountryStopper</servlet-name>
            <servlet-class>
            CountryStopper</servlet-class>
      </servlet>
      <servlet-mapping>
            <servlet-name>action</servlet-name>
            <url-pattern>*.do</url-pattern>
      </servlet-mapping>
      <servlet-mapping>
            <servlet-name>CountryStopper</servlet-name>
            <url-pattern>/CountryStopper</url-pattern>
      </servlet-mapping>
      <welcome-file-list>
            <welcome-file>index.html</welcome-file>
            <welcome-file>index.htm</welcome-file>
            <welcome-file>index.jsp</welcome-file>
            <welcome-file>default.html</welcome-file>
            <welcome-file>default.htm</welcome-file>
            <welcome-file>default.jsp</welcome-file>
      </welcome-file-list>
</web-app>

My goal is to see

we love people who speak : chinese etc

as well. i am bit confused about the flow.When we run the servlet it supposed to hit the filter and based on the browser local it supposed to display values from filter right. Please advise

Any ideas, suggestions, sample code, links highly appreciated.Thanks in advance

Hi,

# if (language!= "spansih"){
# response.getWriter().println("only american spanish people can view this filetert");
# }
# else{
# response.getWriter().println("we love people who speak :"+ request.getLocale().getCountry());
#
# }

Is the If condition correct?

Your servlet code is never executed. In your filter, you never call chain.doFilter(request, response);. So the request never reaches your servlet. Moreover I think you'll get an IllegalStateException since you are writing some response in your filter and then again in your servlet...

Furthermore, the statement:

will never do what you expect. String comparisons MUST use the equals method. When used with object references, == and related operators compare references, not contents.

This is a common beginner mistake.

Bill

wonderful it worked fine now...after i changed the filter code to

package com.american.web.filter;

import javax.servlet.Filter;
import javax.servlet.FilterConfig;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
import javax.servlet.FilterChain;
import java.io.IOException;

public class AmericanFilter implements Filter {
	/* (non-Java-doc)
	 * @see javax.servlet.Filter#init(FilterConfig arg0)
	 */
	public void init(FilterConfig arg0) throws ServletException {
		// TODO Auto-generated method stub
	}

/* (non-Java-doc)
	 * @see javax.servlet.Filter#doFilter(ServletRequest arg0, ServletResponse arg1, FilterChain arg2)
	 */
	public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
		String language=request.getLocale().getDisplayLanguage();
		 if ("spanish". equalsIgnoreCase(language)){
			 response.getWriter().println("only american spanish people can view this filetert");
		}
		else{
			chain.doFilter(request, response);
			
		}
		System.out.println("time ater serveltt is full"+System.currentTimeMillis());
	}

/* (non-Java-doc)
	 * @see javax.servlet.Filter#destroy()
	 */
	public void destroy() {
		// TODO Auto-generated method stub
	}

}

through IE 6.0 where i kept default locale it showed output like

only american spanish people can view this filetert

where as in google chrome when i change the locale to some different language it showed output like

we love people who speak :US

as in attachments.

I am confused about the flow, output , filter function on how it is integrated with this servlet example in this particular scenario based on locale. Please advise