JFrame + windowClosed event is not getting fired.

[Sagar Rohankar]

Hi all,
on button click event, I'm creating the new JFrame instance for showing some Java 3D output.
But the code for windowClosed() method doesn't get executed at all,
but if I provided

frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

for the same frame instance, then there is no problem

logger.info("Showing the J3D Panel for optimized Container View");
try
{
	JFrame frame = new JFrame();

	frame.addWindowListener(new WindowAdapter()
	{
		public void windowClosed(WindowEvent e)
		{
			System.out.println("Window Closing.........");
			// Remove all component
			
			System.exit(0);
		}
	});

	if (isOptimized()) // Show newly optimized container
	{
		boxOpt = new J3DContainerFrame(this);

		logger.info("The Container is optimized for boxes");
		boxOpt.show3DProductBox(box_vectorMap, containerBox);
		frame.setLayout(new BorderLayout());

		frame.getContentPane().add(boxOpt, BorderLayout.CENTER);

	}
	//frame.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE);
	frame.pack();
	// frame.setLocation(120, 80);
	// frame.setIconImage(Toolkit.getDefaultToolkit().getImage("resources/icon.PNG"));
	frame.setVisible(true);
}

Note: J3DContainerFrame extends JPanel
Any pointers ?

[Michael Dunn]

try using the method hinted at by your sys.out.println

//public void windowClosed(WindowEvent e)
public void windowClosing(WindowEvent e)

[Rob Spoor]

The windowClosed event is fired when the window has already closed. But it will not close if you allow it to close. You can do this by setting a proper default close operation. When you click the X it will fire the windowClosing event instead.

[Sagar Rohankar]

OK, that was a silly mistake, Next time I should look more carfully in Java Docs
Thanks Michael & Rob for the quick and correct reply.

But my little knowledge of JFC forces me to ask this:
Why we need (separate) "windowClosed" event, can't we simply write all the code/logic related to "window closing/ed" thing in one method ?

[Rob Spoor]

Because you may want to be informed of both when the window is about to be closed (windowClosing), perhaps so you can block it, and when the window is actually closed (windowClosed), perhaps so you can do some clean-up.

[Sagar Rohankar]

hmm, convincing.. I got it.

[Rob Camick]

windowClosing is always fired.

windowClosed will be fired when you use:

frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);  

I tend to use windowClosing as suggested in the Closing An Application entry.

[Sagar Rohankar]

Thanks