i get null expression when trying to call from another class

[Sid James]

m

[James Ward]

Change this line inside the constructor of Dice class (the class level variable mRandom will remain null otherwise):

Random mRandom = new Random(20);

to this:

mRandom = new Random(20);

[Sid James]

Hello,

It still says NullPointerException when i call AttackValue (after i changed the Random mRandom to just mRandom)
Please let me know if you can see something else that could be the problem.

[D. Ogranos]

Same mistake with Dice in the constructor of class Hero...you declare a local variable of type Dice there, but probably want to assign it to your instance variable.

[Himanshu Kansal]

One problem I see is about the missing code tags.

Next, you instead of refereing to instance variables in the constructors, create new automatic ones.

  Dice mDice = new Dice(20); 
  

[Sid James]

D Ogranos - do you mean mSides?

like Dice mDice = new Dice(mSides)? (in the constructor of Hero)

or should i change the type of Dice?

[Sid James]

Himanshu - like this?

(constructor)
Dice mDice = new Dice()

Im sorry that may be the way i already written. How do you mean?

[James Ward]

In the constructor of Hero class.

Change this line:

Dice mDice = new Dice(20); 

to this:

mDice = new Dice(20); 

[Sid James]

I think ive fixed it!!! Thank you so much. I made the method create a new Dice. Allthough now it is returning the same numbers, but that isnt a big problem. Thank you!!