Beginner Struts Problem (Solved)

[John Sears]

Hi,
I am trying to learn some struts2, and am running into the following problem making a trivial web application: I want to use one jsp as a form, then pass the data on to an action class and have it available to print on a second jsp. My struts.xml file is:


struts.xml

<package name="hello" namespace="/" extends="struts-default">
	<default-interceptor-ref name="defaultStack"/>
		<action name="Name_input">
			<result>
				jsp/NameInput.jsp
			</result>
		</action>
		
		<action name="Name_display" class="world.hello.Person">
			
			<result name="success" type="dispatcher">
				jsp/NameDisplay.jsp
			</result>
			<result name="failure" type="dispatcher">
				jsp/NameInput.jsp
			</result>
		</action>
	</package>

Here is the form code from the input class:
NameInput.jsp

	<form method="post" action="Name_display">
	<table>
	<tr>
		<td>
			Name:
		</td>
		<td>
			<input type="text" name="name"/>
		</td>		
	</tr>
	<tr>
		<td>
			Number:
		</td>
		<td>
			<input type="text" name="number"/>
		</td>		
	</tr>
	<tr>
		<td colspan="2">
			<input type="submit" value="Submit"/>
		</td>
	</tr>
	</table>
	
	</form>

Here is a relevant excerpt from the display class:
NameDisplay.jsp

    
	<tr>
		<td>
			Name:
		</td>
		<td>
			<b>
				<s:property value="name"/>
			</b>
		</td>	
	</tr>
	<tr>
		<td>
			Number:
		</td>
		<td>
			<b>
				<s:property value="number"/>
			</b>
		</td>	
	</tr>

However, when I submit data from my form it doesn't get carried over. I have a check in my action class (world.hello.Person) that makes sure that the name and number values were set (and I can print them to the console). They are getting through--and so the success result is displaying.

Here is the code from the action class
Person.java

package world.hello;

import java.io.Serializable;
public class Person implements Serializable 
{
	private String name, number;

	public String getName() {
		return name;
	}

	public void setName(String name) {
		this.name = name;
	}

	public String getNumber() {
		return number;
	}

	public void setNumber(String number) {
		this.number = number;
	}
	
	public String execute()
	{
		
		if (getName() != null && getNumber() != null)
			return "success";
		else
			return "failure";
	}

}

If anyone has any input as to what I'm doing wrong, that would be incredible. My gut says that I need to somehow bind the Person to the http request (like how you would with a standard filter). Also, I switched to the <s:property> tag from just ${person.name} style because I didn't have a name for the parmater. Anyway, thanks in advance!

John

[John Sears]

Never mind, I realized I needed to add

<%@ taglib prefix="s" uri="web-inf/struts-tags.tld" %>

It works fine now.

[Ankit Garg]

Did you manually add struts-tags.tld fine in the WEB-INF directory?? You don't need to do that. You need to use a taglib directive like this

<%@ taglib  uri="/struts-tags" prefix="s"%>

The struts tld file is in the struts jar file so it is not needed again in WEB-INF folder...

[David Newton]

I marked as solved in the subject.

But Ankit is correct; it shouldn't be necessary to extract the TLD file.

[John Sears]

ah, thank you. I will give that a shot.