Help with Println and Scanner

[Mike Atoms]

I would like for this EmployeeTest app to receive from the user 2 sets of information. Each includes the first name, last name and monthly salary for an employee. Then I want the program to calculate the employees yearly salary and then give them a 10% raise. My coding is only taking information for 1 employee and the raise is not being properly calculated nor displayed back to me.

  import java.util.Scanner;
public class EmployeeTest {

public static void main(String[] args)
    {
        Employee employee1 = new Employee();
        Employee employee2 = new Employee();
        double yearlySalary1, yearlySalary2;


        yearlySalary1 = employee1.getMonthlySalary() * 12;
        yearlySalary2 = employee2.getMonthlySalary() * 12;

        Scanner scanner = new Scanner(System.in);
        System.out.println(employee1.getFirstName()+
                " "+ employee1.getLastName()+" "+
                employee1.getMonthlySalary());

        System.out.println(employee2.getFirstName()+
                " "+ employee2.getLastName()+" "+
                employee2.getMonthlySalary());

        System.out.print("Enter employee first name: ");
        String fName  = scanner.nextLine();
        System.out.print("Enter employee last name: ");
        String lName  = scanner.nextLine();
        System.out.print("Enter monthly salary: ");
        double mSalary = scanner.nextDouble();

        employee1.setFirstName(fName);
        employee1.setLastName(lName);
        employee1.setMonthlySalary(mSalary);
        employee2.setFirstName(fName);
        employee2.setLastName(lName);
        employee2.setMonthlySalary(mSalary);


        System.out.println("Employee Named: " +" "+ employee1.getFirstName() +
                " Yearly Salary = " + yearlySalary1);
        System.out.println("Employee Named: " +" "+ employee2.getFirstName() +
                " Yearly Salary = " +" "+ yearlySalary2);

        System.out.println("Lets give them a ten percent raise!!");
        double newYearlySalary1, newYearlySalary2;
        newYearlySalary1 = yearlySalary1 * 1.10;
        newYearlySalary2 = yearlySalary2 * 1.10;

        System.out.println("Employee named " + employee1.getFirstName() + "New Salary = " + newYearlySalary1);
        System.out.println("Employee named " + employee2.getFirstName() + "New Salary = " + newYearlySalary2);
    }

}
  

I've tried several things but to no avail. Please help me understand why this isn't working as I would like it to. Below is an example of the output I am receiving.

run:
0.0
0.0
Enter employee first name: Mike
Enter employee last name: Atoms
Enter monthly salary: 1000
Employee Named: Mike Yearly Salary = 0.0
Employee Named: Mike Yearly Salary = 0.0
Lets give them a ten percent raise!!
Employee named MikeNew Salary = 0.0
Employee named MikeNew Salary = 0.0
BUILD SUCCESSFUL (total time: 10 seconds)

Thanks for the help!

[pete stein]

When you calculate the yearly salary, you do so before setting the Employee object's monthly salary. Thus when you ask the Employee object for its monthly salary, I bet that it's returning 0 for a default value. Solution: only do the calculation after you've set both Employee monthly salaries.

[Mike Atoms]

Pete,

I appreciate the help. I changed how I attacked the problem. I removed the scanner and just set the employees info manually in the code. The code is below.

   public class EmployeeTest {

public static void main(String[] args)
    {
        Employee employee1 = new Employee("Bill","Hicks",4500.25);
        Employee employee2 = new Employee("Tom","Cruise",5000.34);
        double yearlySalary1, yearlySalary2;


        yearlySalary1 = employee1.getMonthlySalary() * 12;
        yearlySalary2 = employee2.getMonthlySalary() * 12;

        System.out.println("Employee Named: " +" "+ employee1.getFirstName() +
                " Yearly Salary = " + yearlySalary1);
        System.out.println("Employee Named: " +" "+ employee2.getFirstName() +
                " Yearly Salary = " +" "+ yearlySalary2);

        System.out.println("Lets give them a ten percent raise!!");
        double newYearlySalary1, newYearlySalary2;
        newYearlySalary1 = yearlySalary1 * 1.10;
        newYearlySalary2 = yearlySalary2 * 1.10;

        System.out.println("Employee Named " +" "+ employee1.getFirstName() + "New Salary = " + newYearlySalary1);
        System.out.println("Employee Named " +" "+ employee2.getFirstName() + "New Salary = " + newYearlySalary2);
    }

}
 

[Campbell Ritchie]

You ought to have a toString method in your Employee class. Then you simply write System.out.println(emp1);

[Greg Stevens]

Is this raise temporary? The new salary is never assigned to an instance variable.

EDIT: I see the salary is stored as a monthly salary. Still, you could do your output display with the local variables
newYearlySalary1 and newYearlySalary2, but, if you don't change the monthlySalary instance variables the raise
will not take effect.