List from Action to JSP in Struts 1

[Kartik Talasu]

Hello All,

Am having a JSP where I was suppose to show a dropdown box, where the values of dropdown are in a list which is in request attribute.

So in JSP I had written a scriplet and got the list, and working fine.

   
<%
		ArrayList data =new ArrayList();
		data=(ArrayList)request.getAttribute("mainCombo");
%>
<select name="mainCombo" id="mainCombo" onchange="populateFromDiscreteList(this)">
<%
 	for(int i=0;i<data.size();i++)
               	{
%>
 <option value="<%=data.get(i)%>"><%=data.get(i)%></option>
 <% } %>
</select>

But I heard the getting the results from scriplet is not a good practise, so is there any other way to get them?
NOTE: Am using Struts 1

[David Newton]

Use the <html:select> and <html:options> or <html:optionsCollection> tags.