need help to find the right path to images

[miguel lisboa]

this topic is in a way the continuation of this one

the diference is this: i added each class to a package (gui and util)

in first place i had to change the path to the frame icon image from:
"thisImage" to
"/thisImage"

the others didnt need this fix

now, if i run, i get it all ok, but, if i jar, only the tab images appear; the frame icon and the panel background dont show up

so here´s the reason for this topic: i tried gazillions paths to images, but couldnt find a proper solution

i suspect the path to images is related to the way the code searches for the images in the classpath, but i'v not enough java knowleadge to sort it out



can anyone help me, please?

just in case, here's the running code:

 package gui;

import javax.swing.*;
import java.awt.*;
import util.*;

public class Teste {
	private JFrame jFrame = null;
	private static final String CAMINHO_ICONE = "/criarLancamento.png";
	private static final String NOME_FUNDO = "jr2.jpg";
	private static final String TAB_1 = "clear.png";
	private static final String TAB_2 = "radar.jpg";
	private static final int COMPRIMENTO = 300;
	private static final int LARGURA = 300;
	private JPanel jContentPane = null;
	private JTabbedPane tabbedPane = null;
	private JPanel panel = null;

	private JFrame getJFrame() {
		if (jFrame == null) {
			jFrame = new JFrame();
			jFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
			jFrame.setSize(COMPRIMENTO, LARGURA);
			jFrame.setContentPane(getJContentPane());
			jFrame.setTitle("Teste");

			Image imagem = ImageUtil.create(CAMINHO_ICONE);
			jFrame.setIconImage(imagem);
		}
	return jFrame;
	}

	private JPanel getJContentPane() {
		if (jContentPane == null) {
			jContentPane = new JPanel();
			jContentPane.setLayout(null);
			jContentPane.add(getTabbedPane(), null);
		}
		return jContentPane;
	}

	private JTabbedPane getTabbedPane() {
		if (tabbedPane == null) {
			tabbedPane = new JTabbedPane();
			tabbedPane.setBounds(new Rectangle(0, 0, COMPRIMENTO, LARGURA));
			ImageIcon criar = createImageIcon(TAB_1);
			tabbedPane.addTab("Um", criar, getPanel(), null);
			ImageIcon radar = createImageIcon(TAB_2);
			tabbedPane.addTab("Dois", radar, null, null);
		}
		return tabbedPane;
	}

	private JPanel getPanel() {
		if (panel == null) {
			panel = new JPanel(){;
			private static final long serialVersionUID = 1057518020357501188L;
				public void paintComponent(Graphics g) {
					super.paintComponent(g);
					ImageUtil util = new ImageUtil();
					g.drawImage(util.obtemFundo(NOME_FUNDO), 0, 0, this);
				}
			};
		}
		return panel;
	}

	  private static ImageIcon createImageIcon(String caminho) {
	      java.net.URL imgURL = Teste.class.getResource(caminho);
	      if (imgURL != null) {
	          return new ImageIcon(imgURL);
	      }
	      else {
	          System.err.println("ficheiro não encontrado: " + caminho);
	          return null;
	      }
	}

	public static void main(String[] args) {
		SwingUtilities.invokeLater(new Runnable() {
			public void run() {
				Teste app = new Teste();
				app.getJFrame().setVisible(true);
			}
		});
	}
}


package util;

import javax.swing.*;
import java.awt.*;
import javax.imageio.ImageIO;

public class ImageUtil {
   public static Image create(String caminho) {
      java.net.URL imageURL = ImageUtil.class.getResource(caminho);
      if (imageURL == null) {
        System.err.println("ficheiro não encontrado: " + caminho);
         return null;
      }
      return new ImageIcon(imageURL).getImage();
   }

   public Image obtemFundo(String nomeFundo) {
   		try {
   			return ImageIO.read(new java.net.URL(getClass().getClassLoader().getResource(nomeFundo), nomeFundo));
   		}
   		catch(Exception e) {
			System.err.println("ficheiro não encontrado: " + nomeFundo);
   			return null;
   		}
	}
}   

and the ant build file:

<?xml version = "1.0" encoding = "ISO-8859-1" ?>
<project name = "Teste" default = "run" basedir = ".">
	<property name = "src.dir" value = "${basedir}\source" />
	<property name = "build.dir" value = "${basedir}\classes" />
	<property name = "img.dir" value = "${basedir}\img" />  
	<property name = "jar.dir" value = "${basedir}\jars" />  

	<path id = "classpath">
		<pathelement location = "${build.dir}" />
		<pathelement location = "${img.dir}" /> 
<!--		<pathelement location = "${jar.dir}" /> -->
	</path>

	<target name = "clean"> 
		<delete dir = "${build.dir}" /> 
		<delete dir = "${jar.dir}" />
	</target>

	<target name = "init">
		<mkdir dir = "${build.dir}" />
		<mkdir dir = "${jar.dir}" />
	</target>

	<target name = "build" depends = "clean, init" description = "build all">
		<javac srcdir = "${src.dir}" destdir = "${build.dir}" source = "1.6"> 
			<classpath refid = "classpath" /> 
		</javac>
		<copy todir = "${build.dir}/gui">
		   <fileset dir = "${img.dir}">
<!--			  <include name = "**/*img/*"/> -->
		   </fileset>
		</copy>
	</target>

	<target name = "run" depends = "build"> 
		<java classname = "gui.Teste" fork = "yes"> 
			<classpath refid = "classpath" /> 
		</java> 
	</target>
	
	<target name = "imgjar" depends = "build">       
		<jar destfile = "jars/img.jar"  update = "true" excludes = "*.db" > 
        		<fileset dir = "img" />
		</jar>
	</target>

	<target name = "jar" depends = "build">          
		<jar 
			destfile = "jars/Teste.jar" 
			basedir = "${basedir}" 
			manifest = "META-INF/MANIFEST.MF" 
			excludes = "**/*.java **/*.tws **/*.db **/*.xml **/*.txt **/*.jar*"
			update = "true">  
			<fileset dir = "${basedir}\classes" />  
		</jar>       
	</target>
  
</project>    

[Peter Johnson]

Post the contents of the img.jar file. To do that, run this:

jar -tf jars/img.jar

It appears that you are attempting to load the images as resources form the classpath. I assume that img.jar is in your classpath and that all of the images are in the base directory of the jar file.

By the way, I found the code you posted extremely difficult to read because of the extra blank lines. I deleted them for you this time, but if you want answers to your questions you need to make it as easy for the readers of the forum as possible, otherwise those readers might skip your post. This is especially true if you post a lot of code.

[miguel lisboa]

Peter Johnson wrote:Post the contents of the img.jar file. To do that, run this:

jar -tf jars/img.jar

It appears that you are attempting to load the images as resources form the classpath. I assume that img.jar is in your classpath and that all of the images are in the base directory of the jar file.

By the way, I found the code you posted extremely difficult to read because of the extra blank lines. I deleted them for you this time, but if you want answers to your questions you need to make it as easy for the readers of the forum as possible, otherwise those readers might skip your post. This is especially true if you post a lot of code.

hi Peter, thanks for helping
i indeed thought spaced code was more readable , but no problem
i'm extremely happy because i found a working and perfect solution, based on this marvelous book i was lucky enough to win here at javaranch book promotions: Agile java, by Jeff Langr
but before i drop the solution, let me properly answer you:

It appears that you are attempting to load the images as resources form the classpath.

yes! - and that's the point (i guess) - im trying to load the images as resources from the classpath -that pointed me to the right solution: using the very same code (as possible) to display the images

I assume that img.jar is in your classpath

i've that jar commented out from classpath, for now only (jar.dir)
yet i'm (still) not using the jared images folder (that will be my next goal) - i'm using the images folder (img) placed inside "source" folder and moving it to the "classes" folder
here's the content of the imgjar:
C:\javagranel\Teste>jar -tf jars/img.jar
META-INF/
META-INF/MANIFEST.MF
Thumbs.db
clear.png
criarLancamento.png
jr2.jpg
radar.jpg

(half an hour later)
now i'm ever happier, because i can run a jar getting it perfectly, using either the img folder or the imgjar.jar as well
in the code i show i have the imgjar in the classpath and the img folder out if it (anyway it works both ways)
(the build file isnt perfect yet because i need a jarimg created in order to run the application and now i'm not seizing the correct solution, but anyway i'm sure all works fine - got a family life too, so in the next days i'll fix it)

ok, so, time for revealing the code:

package gui;

import javax.swing.*;
import java.awt.*;
import util.*;

public class Teste {
	private JFrame jFrame = null;
	private static final String CAMINHO_ICONE = "/img/criarLancamento.png";  // agile java p 611
	private static final String TAB_1 = "/img/clear.png";
	private static final String TAB_2 = "/img/radar.jpg";
	private static final String NOME_FUNDO = "/img/jr2.jpg";
	private static final int COMPRIMENTO = 300;
	private static final int LARGURA = 300;
	private JPanel jContentPane = null;
	private JTabbedPane tabbedPane = null;
	private JPanel panel = null;

	private JFrame getJFrame() {
		if (jFrame == null) {
			jFrame = new JFrame();
			jFrame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
			jFrame.setSize(COMPRIMENTO, LARGURA);
			jFrame.setContentPane(getJContentPane());
			jFrame.setTitle("Teste");

			Image imagem = ImageUtil.create(CAMINHO_ICONE);
			jFrame.setIconImage(imagem);
		}
	return jFrame;
	}

	private JPanel getJContentPane() {
		if (jContentPane == null) {
			jContentPane = new JPanel();
			jContentPane.setLayout(null);
			jContentPane.add(getTabbedPane(), null);
		}
		return jContentPane;
	}

	private JTabbedPane getTabbedPane() {
		if (tabbedPane == null) {
			tabbedPane = new JTabbedPane();
			tabbedPane.setBounds(new Rectangle(0, 0, COMPRIMENTO, LARGURA));
			ImageIcon criar = ImageUtil.createImageIcon(TAB_1);
			tabbedPane.addTab("Um", criar, getPanel(), null);
			ImageIcon radar = ImageUtil.createImageIcon(TAB_2);
			tabbedPane.addTab("Dois", radar, null, null);
		}
		return tabbedPane;
	}

	private JPanel getPanel() {
		if (panel == null) {
			panel = new JPanel(){;
			private static final long serialVersionUID = 1057518020357501188L;
				public void paintComponent(Graphics g) {
					super.paintComponent(g);
					g.drawImage(ImageUtil.create(NOME_FUNDO), 0, 0, this);
				}
			};
		}
		return panel;
	}

	public static void main(String[] args) {
		SwingUtilities.invokeLater(new Runnable() {
			public void run() {
				Teste app = new Teste();
				app.getJFrame().setVisible(true);
			}
		});
	}
}

package util;

import javax.swing.*;
import java.awt.*;
import javax.imageio.ImageIO;

public class ImageUtil {
   public static Image create(String caminho) {
      java.net.URL imageURL = ImageUtil.class.getResource(caminho);
      if (imageURL == null) {
      System.err.println("ficheiro não encontrado: " + caminho);
         return null;
	}
      return new ImageIcon(imageURL).getImage();
   }

      public static ImageIcon createImageIcon(String caminho) {
         java.net.URL imageURL = ImageUtil.class.getResource(caminho);
         if (imageURL == null) {
         System.err.println("ficheiro não encontrado: " + caminho);
            return null;
   	}
         return new ImageIcon(imageURL);
   }
}    

ant the ant build file:

 <?xml version = "1.0" encoding = "ISO-8859-1" ?>

<project name = "Teste" default = "run" basedir = ".">
	<property name = "src.dir" value = "${basedir}\source" />
	<property name = "build.dir" value = "${basedir}\classes" />
	<property name = "img.dir" value = "${src.dir}\img" />  <!-- agile java p 611 -->
	<property name = "jar.dir" value = "${basedir}\jars" />  

	<path id = "classpath">
		<pathelement location = "${build.dir}" />
<!--		<pathelement location = "${img.dir}" /> -->
		<pathelement location = "${build.dir}" />
		<pathelement location = "${jar.dir}" /> 
	</path>

	<target name = "clean"> 
		<delete dir = "${build.dir}" /> 
		<delete dir = "${jar.dir}" />
	</target>

	<target name = "init">
		<mkdir dir = "${build.dir}" />
		<mkdir dir = "${jar.dir}" />
	</target>

	<target name = "build" depends = "clean, init" description = "build all">
		<javac srcdir = "${src.dir}" destdir = "${build.dir}" source = "1.6"> 
			<classpath refid = "classpath" /> 
		</javac>
		<!--<copy todir = "${build.dir}">
		   <fileset dir = "${src.dir}">
			  <include name = "**/*img/*"/> 
		   </fileset>		       
		</copy>-->
	</target>

	<target name = "run" depends = "build"> 
		<java classname = "gui.Teste" fork = "yes"> 
			<classpath refid = "classpath" /> 
		</java> 	
	</target>
	
	<target name = "imgjar" depends = "build">       
		<jar destfile = "jars/img.jar"  update = "true" excludes = "*.db" > 		
			<fileset dir = "img" />			
		</jar>
	</target>

	<target name = "jar" depends = "build, imgjar">          		
		<jar 		
			destfile = "jars/Teste.jar" 			
			basedir = "${basedir}" 			
			manifest = "META-INF/MANIFEST.MF" 			
			excludes = "**/*.java **/*.tws **/*.db **/*.xml **/*.txt **/*.jar*"			
			update = "true">  
			<fileset dir = "${basedir}\classes" />  
		</jar>       
	</target>
 
</project>   

so it's a case sloved!

have a nice weekend!