initialising db connection

[nikil shar]

hi all,
have got a servlet which calls a utilities class to initialize db connection. inside the utilities class my method looks like this :

 public class dbUtilities {

//private class variables
 private Connection con = null;
 private DataSource ds = null;

 public void establishDBConnection() throws SQLException, NamingException {

        Logger.getLogger(dbUtilities.class.getName()).log(Level.INFO, "inside establishDBConnection()");

        try {

            if (ds == null) {
                ds = getDataSource();
            } else {
                con = ds.getConnection();
            }


            Logger.getLogger(dbUtilities.class.getName()).log(Level.INFO, "successfully got a connection to DB");

        } catch (SQLException e) {
            throw new SQLException("SQLException while establishing db connection: " + e.getMessage());
        }

    }

.
.
.

when i call this method from my servlet :

//private class var
 private Connection con = null;

doPost( ..... ){

dbUtilities  dbUtil = new dbUtilities();

con =  dbUtil.establishDBConnection();

i get a null pointer returned. i can see that "dbUtil.establishDBConnection()" returns an object but for some reason it never gets assigned to 'con' object in my servlet !!


any help would be much appreciated.

ta.

[Deepak Bala]

public void establishDBConnection()

The return type is void, so I doubt if your code compiles

[Somnath Mallick]

Where is the return statement in establishDBConnection()??

[Sri Dharan]

It should be return Connection object :

   
public Connection establishDBConnection() ....
 

[Deepak Bala]

You are probably getting the DS on the first try and assigning the connection when the DS is not null on the second try. The second call probably does not return null, but we can only speculate since the code and the problem at hand do not match each other

[Seetharaman Venkatasamy]

Importantly Change your class name from dbUtilities to DBUtilities