FileReader / BufferedReader will only read the first line from the file

[Ådne Brunborg]

Hi,

I have a problem with the following code, only the first line of text in the file is read and returned.

Code:

	public String readStringFromFile(String fileName) throws IOException {

		File file = new File(fileName);
		FileReader fileReader = new FileReader(file);
		BufferedReader bufferedReader = new BufferedReader(fileReader);
		StringBuffer stringBuffer = new StringBuffer(256);

		String line = bufferedReader.readLine();
		int i = 0;// TODO remove , for test only
		boolean done = false;

		while (!done) {
			if (line != null) {
				System.out.println(i + ": " + line);
				i++;
				if (i > 3)
					done = true;
				stringBuffer.append(line).append("\n");
			} else
				done = true;
		}

		System.out.println("done=" + done);
		System.out.print(stringBuffer);

		bufferedReader.close();
		fileReader.close();

		return stringBuffer.toString();
	}
  

Output:

0: First Line In File
1: First Line In File
2: First Line In File
3: First Line In File
done=true
First Line In File
First Line In File
First Line In File
First Line In File   

[K. Tsang]

The reason why you are only reading the first line is your while loop. You read the line in then what happens? Loop through it until i reaches 3? Try putting that line variable inside the while declaration. You will see a whole lot of lines read.

[Campbell Ritchie]

Seems an odd while-loop; why not this?

. . . while (i < 3 && (line = myReader.nextLine()) != null) . . .

Where are you reading the line? You only appear to read one line once. You will have to read it again. Using conventional forms of loops will tend to reduce errors, because the conventional forms have been tried millions of times before and seen to work correctly.

[Ådne Brunborg]

duh... thanks