multidimensional array

[phani ravinutala]

I have two string arrays like below.

String[] employee = new String[2];
String[] empDET  = new String[4];
empDET [1] = "jhon";
empDET[2]  ="IT",
empDET[3] ="micheal";
empDET[4] = "Engineering";
 
I need to add like below
employee[0]= empDET[0]; (jhon)
employee[0] = empDET[1];(IT)
employee[1] = empDET[2] (micheal)
employee[2] = empDET[3](Engineering)

Here is my code:

Emp emp = new Emp();
int leng = Employee.length;
int leng1  = EmpDET[leng].length;

leng = 2;
leng1 = 4;

ArrayList list = new ArrayList();

for(int i=0; i<leng; i++)
{
for(int j=0;j<leng1; j++)
{

emp.setname(empDet[j]);
emp.setdept(empDET[j]);


list.add(emp);


}




}

But I'm getting the below output:

employee[0] = EmpDET[0];
Employee[1] = EmpDET[0];
Employee[1] = EmpDET[1]

Expected output should be like below

Employee[0] = EmpDET[0];
Employee[0] = EmpDET[1];
Employee[1] = EmpDET[2];
Employee[1] = EmpDET[3];

Could please anyone help me?
thanks

[Rajeev Ravindran]

i dont really understand your question but i did a quick test and this is what i got !! you don't need to keep Emp as inner class as i have defined.

   

import java.util.ArrayList;
import java.util.Iterator;

/**
 * Hello world!
 * 
 */
public class App {
	public static final Object IN_QUEUE = "In Queue";

	public static void main(String[] args) {
		System.out.println("Hello World!" + IN_QUEUE.toString());

		String[] Employee = new String[2];
		String[] EmpDET = new String[2];

		Employee[0] = "jhon";
		Employee[1] = "micheal";

		EmpDET[0] = "IT";
		EmpDET[1] = "Engineering";

		
		int leng = Employee.length;
		int leng1 = EmpDET.length;

		ArrayList list = new ArrayList();

		for (int i = 0; i < leng; i++) {
			
			for (int j = 0; j < leng1; j++) {
				Emp emp = new App().new Emp();
				emp.setName(Employee[i]);
				emp.setDept(EmpDET[j]);
				list.add(emp);
			}
		}
		
		for (Iterator iter = list.iterator(); iter.hasNext();) {
			Emp emp1 = (Emp) iter.next();
			System.out.println(" name : " + emp1.getName() + " dept : " + emp1.getDept());
		}
	}

	class Emp {

		public String name;
		public String dept;

		public String getName() {
			return name;
		}

		public void setName(String name) {
			this.name = name;
		}

		public String getDept() {
			return dept;
		}

		public void setDept(String dept) {
			this.dept = dept;
		}

	}
}
 

[phani ravinutala]

Thanks, for your rply,

suppose If I have second array EmpDET as below.

    String[] Employee = new String[2];   
        String[] EmpDET = new String[4];   

Employee[0] = "jhon";   
        Employee[1] = "micheal";   
  
        EmpDET[0] = "IT";   
        EmpDET[1] = "JAVA"; 
        EmpDET[2] = "Engineering";   
        EmpDET[3] = "CHEMICAL";   
  

Excepted output should be like below

EMPLOYEE[0]= ( EmpDET[0], EmpDET[1] );
EMPLOYEE[0]= ( EmpDET[2], EmpDET[3] );

[Rajeev Ravindran]

LOL are you gonna pay me for doing your job ? try it yourself and if you get into issues, someone will help you. Hope i don't sound rude !!

Thanks,

[phani ravinutala]

thanks for your help.

I'm new this programming.


Can anyone please help me?

how would I set the object Employee?

what is the best way?

  String[] Employee = new String[2];   
        String[] EmpDET = new String[4];   

      Employee[0] = 1;  
        Employee[1] = 2;   
  
        EmpDET[0] = "IT";   
        EmpDET[1] = "JAVA"; 
        EmpDET[2] = "Engineering";   
        EmpDET[3] = "CHEMICAL";   
EMPLOYEE[0]= ( EmpDET[0], EmpDET[1] );
EMPLOYEE[1]= ( EmpDET[2], EmpDET[3] );

thanks

[Campbell Ritchie]

You appear to be very confused about arrays. Have a look at the Java™ Tutorials for a start.

[Rob Spoor]

phani ravinutala wrote:

Emp emp = new Emp();
...
for(int i=0; i<leng; i++)
{
    for(int j=0;j<leng1; j++)
    {
        emp.setname(empDet[j]);
        emp.setdept(empDET[j]);
        list.add(emp);
    }
}

Do you realize that you are using the very same Emp instance and just update that one? In the end, your list will contain several references to that very same instance, which will contain the values of the last array elements. Move the "Emp emp = new Emp();" line into the loop, just before you set the name.