struts 2 validator problem

[Ben sassi mohammed]

hello
i have problem white struts 2 validator

Tags <s:fielderror> you told me works well. Except that
Now I have duplicate messages (I thought the message "by
Default "no longer present).

please looks attchments

thank you in advance

[Ankit Garg]

Can you show us the code which you are using. Its hard to tell anything just by looking at the image...

[David Newton]

If you're using an attribute-free <s:fielderror/> tag you'll get the validation messages both from it, and from the Struts 2 form tags--if you're using the default "xhtml" theme.

[Ben sassi mohammed]

  
/**
 * 
 */
package com.fdar.apress.s2;

import java.util.Map;

import javax.servlet.ServletContext;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.struts2.interceptor.ApplicationAware;
import org.apache.struts2.interceptor.ServletRequestAware;
import org.apache.struts2.interceptor.ServletResponseAware;
import org.apache.struts2.interceptor.SessionAware;
import org.apache.struts2.util.ServletContextAware;
import org.springframework.context.ApplicationContext;
import org.springframework.web.context.WebApplicationContext;
import org.springframework.web.context.support.WebApplicationContextUtils;

import com.opensymphony.xwork2.ActionSupport;

/**
 * @author simo
 *
 */
public class loginAction extends ActionSupport implements SessionAware,ServletRequestAware,ServletContextAware{
	  /**
	 * 
	 */
	private static final long serialVersionUID = 1L;
	private static final Log sLogger=LogFactory.getLog(loginAction.class);
	private String userId;
	private String password;
	private Map session;
	private HttpServletRequest mServletRequest;
	private HttpServletResponse mServletResponse;
	private ServletContext mServletContext;
	private WebApplicationContext mApplicationContext;
	public String execute() throws Exception{

	    if ("admin".equals(userId) && "admin".equals(password)) {
	    	
	      session.put("login","admin");
	            return SUCCESS;
	        }
	    else{
	    	
	    	  this.addActionError("Invalid user name or password! Please try again!");
	       return ERROR;
	    }
	}
	public String logout() throws Exception {

	   
	    session.remove("login");
	        return SUCCESS;
	    }
	public String getUserId() {
		return userId;
	}
	public void setUserId(String userId) {
		this.userId = userId;
	}
	public String getPassword() {
		return password;
	}
	public void setPassword(String password) {
		this.password = password;
	}
	
	/* (non-Javadoc)
	 * @see org.apache.struts2.interceptor.SessionAware#setSession(java.util.Map)
	 */
	public void setSession(Map psession) {
		sLogger.info("*******setSession**********");
		sLogger.info("session :"+psession);
		this.session = psession;  
		sLogger.info("session :"+this.session.values());
		// TODO Auto-generated method stub

	}
	public void setServletRequest(HttpServletRequest pServletRequest) {
		// TODO Auto-generated method stub
		sLogger.info("*******setServletRequest**********");
		sLogger.info("ServletRequest :"+pServletRequest.getAttributeNames());
		this.mServletRequest=pServletRequest;
		
		
	}
	public void setServletResponse(HttpServletResponse pServletResponse) {
		// TODO Auto-generated method stub
		sLogger.info("*******setServletResponse**********");
		sLogger.info("ServletRequest :"+pServletResponse);
		this.mServletResponse=pServletResponse;
	}
	public void setServletContext(ServletContext pServletContext) {
		// TODO Auto-generated method stub
		sLogger.info("*******setServletContext**********");
		sLogger.info("ServletRequest :"+pServletContext.getServletContextName());
		this.mServletContext=pServletContext;
		this.mApplicationContext=WebApplicationContextUtils.getWebApplicationContext(pServletContext);
		sLogger.info("mApplicationContext :"+this.mApplicationContext);
		sLogger.debug("loginclass :"+(loginAction)this.mApplicationContext.getBean("loginAction"));
	}
	public void setApplication(Map arg0) {
		// TODO Auto-generated method stub
		
	}
	@Override
	public String toString() {
		return "loginAction [mApplicationContext=" + mApplicationContext
				+ ", mServletContext=" + mServletContext + ", mServletRequest="
				+ mServletRequest + ", mServletResponse=" + mServletResponse
				+ ", password=" + password + ", session=" + session
				+ ", userId=" + userId + "]";
	}


}

  
<%@ taglib prefix="s" uri="/struts-tags" %>
<%@ page language="java" contentType="text/html"%>

<html>
    <head>
        <title>Insert Data here!</title>
     <link href="<s:url value="/css/main.css"/>" rel="stylesheet"
          type="text/css"/>  
          	<s:head />
  </head>
    <body>
    <s:fielderror />
    <s:actionerror />
    <s:form action="login" method="POST" >
      <s:textfield name="userId" label="Login Id"/><br>
      <s:password name="password" label="Password"/><br>
         <s:submit value="Login" align="center" />
    </s:form>
  </body>
</html>

  
<?xml version="1.0" encoding="UTF-8"?>

<!DOCTYPE struts PUBLIC 
    "-//Apache Software Foundation//DTD Struts Configuration 2.0//EN"
    "http://struts.apache.org/dtds/struts-2.0.dtd">

<struts>
	<package name="myPackage" extends="struts-default">
		<global-results>
			<result name="error">/jsp/error1.jsp</result>
			<result name="error2">/jsp/error2.jsp</result>
		</global-results>

		<global-exception-mappings>
			<exception-mapping exception="java.lang.Exception"
				result="error1" />
			<exception-mapping exception="java.lang.RuntimeException"
				result="error2" />
		</global-exception-mappings>


		<action name="index" class="com.fdar.apress.s2.IndexAction">
			<result>/jsp/Login.jsp</result>
		</action>
		<action name="helloWorld" class="helloWorldAction">
			<result name="input">/jsp/index.jsp</result>
			<result>/jsp/helloWorld.jsp</result>
		</action>
		<action name="helloWorld2" class="helloWorldAction">
			<interceptor-ref name="defaultStack" />
			<interceptor-ref name="execAndWait">
				<param name="delay">1500</param>
			</interceptor-ref>
			<result name="wait">/jsp/index.jsp</result>
			<result>/jsp/helloWorld.jsp</result>
		</action>

		<action name="login" class="loginclass">
			<interceptor-ref name="servlet-config" />
			<interceptor-ref name="basicStack" />
	
			 <interceptor-ref name="validation">
                    <param name="excludeMethods">input,back,cancel,logout</param>
                </interceptor-ref>
			<result name="success" type="dispatcher">/jsp/success.jsp</result>
			<result name="error"  >/jsp/Login.jsp</result>
		</action>

		<action name="logout" class="loginclass">
			<result name="success" type="redirect-action">login</result>
		</action>
	</package>
</struts>

  
<!DOCTYPE validators PUBLIC "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
"http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">
<validators>
	<field name="userId">
		<field-validator type="requiredstring" >
			<param name="trim" >true</param>
			<message  >Please enter a user id </message>
		</field-validator>
	</field>
	<field name="password">
		<field-validator type="requiredstring">
		<param name="trim" >true</param>
			<message>Please enter a password</message>
		</field-validator>
	</field>
</validators>

thank you in advance

[David Newton]

I already answered the question.

Please UseCodeTags for *all* code and configuration, not just bits of it.

[Ben sassi mohammed]

thank you for you reply , There is no other solution the The form will now be not good formatting

[David Newton]

So create your own theme, do it manually, etc. You're the one using the default "xhtml" theme and the attribute-less field error tag; there are other options.

[Ben sassi mohammed]

thank you