'class' or 'interface' expected

[Joel Allison]

Getting this error

Prog8.java:57: 'class' or 'interface' expected
static int readData(String[] c, double[] p)

import java.util.*;

public class Prog8
{
	static Scanner sc = new Scanner(System.in);
	public static void main(String args[])
	{
		final int MAX = 1000;

		String[] cityName = new String[MAX];
		double[] population = new double[MAX];

		int numCities;

		numCities = readData(cityName,popultion);

		System.out.println("The original data");
		printData(cityName,popultion,numCities);
		
		sortByName(cityName,popultion,numCities);
		System.out.println("Data sorted by name");
		printData(cityName,popultion,numCities);

		sortByPopulation(cityName,popultion,numCities);
		System.out.println("Data sorted by population");
		printData(cityName,popultion,numCities);

		printPopulation(name,cityName,popultion,numCities);
	}
}

//Reads data from input into given arrays until marker "qqqq" is 
//foun.  Returns the number of items read.

static int readData(String[] c, double[] p)
{
	int n;
	String name;
	double pop;

	n = 0;

	name = sc.next();
	
	while(!name.equals("qqqq"))
	{
		pop = sc.nextDouble();

		c[n] = name.toLowerCase();
		p[n] = pop;

		n++;
		
		name = sc.next();
	}
	
	return n;
}

//Reads data from lists and prints them in an easy to read format.

static void printData(String[] c,double[] p,int n)
{
	int k;

	for(k = 0; k < n; k++)
		System.out.println(c[k] + " " + p[k]);
}

//Sorts data from lists by name.

static void sortByName(String[] c, double[] p,int n)
{
	int last, k, m;
	String name;
	for(last = n-1; last > 0; last--)
	{
		m = 0;
		for(k = 1; k <= last; k++)
		{
			if(c[k].compareTo(c[m]) > 0)
			swap(c, m, last);
			swap(p, m, last);
			last--;
		}
	}
}

//Sorts data from lists by population.

static void sortByPopulation(String[] c, double[] p,int n)
{
	int last, k, m;
	String name;
	for(last = n-1; last > 0; last--)
	{
		m = 0;
		for(k = 1; k <= last; k++)
		{
			if(p[k] > p[m])
			swap(c, m, last);
			swap(p, m, last);
			last--;
		}
	}
}

//This will take the second part and read the names, it will then
//search for the name in the list of names and if it finds it,
//it will print the population and if it does not encounter the
//name it will print "Not known".

static void printPopulation(String n,String[] s,double[] p,int num)
{
	int k;

	for(k=0; k < num; k++)
		if(s[k].equals(n))
			break;
	if(k < num)
		System.out.print(p[k]);
	else
		System.out.print("Not known");
}

//This function will exchange a[i] and a[j] in a list of strings.

static void swap(String[] a,int i,int j)
{
	String tmp;
	tmp.equals(a[i]);
	a[i].equals(a[j]);
	a[j].equals(tmp);
}

//This function will exchange a[i] and a[j] in a list of doubles.

{
	double tmp;
	tmp = (a[i]);
	a[i] = (a[j]);
	a[j] = (tmp);
}	

[Jeanne Boyarsky]

See my comments at the end of this code block.

import java.util.*;

public class Prog8
{
	static Scanner sc = new Scanner(System.in);
	public static void main(String args[])
	{
		final int MAX = 1000;

		String[] cityName = new String[MAX];
		double[] population = new double[MAX];

		int numCities;

		numCities = readData(cityName,popultion);

		System.out.println("The original data");
		printData(cityName,popultion,numCities);
		
		sortByName(cityName,popultion,numCities);
		System.out.println("Data sorted by name");
		printData(cityName,popultion,numCities);

		sortByPopulation(cityName,popultion,numCities);
		System.out.println("Data sorted by population");
		printData(cityName,popultion,numCities);

		printPopulation(name,cityName,popultion,numCities);
	} // closes main method
} // mistakenly closes class

// this is there the compiler gets confused.  it thinks you are done
static int readData(String[] c, double[] p)
	

[Joel Allison]

Ahh I see yeah that makes sense. But when I remove that bracket, it says '}' is expected, more specifically it says:

~ $ javac Prog8.java
Prog8.java:167: '}' expected

I tried adding a bracket at the end of the code, but then it gave me a ton of other errors:

~ $ javac Prog8.java
Prog8.java:38: cannot find symbol
symbol : variable popultion
location: class Prog8
numCities = readData(cityName,popultion);
^
Prog8.java:41: cannot find symbol
symbol : variable popultion
location: class Prog8
printData(cityName,popultion,numCities);
^
Prog8.java:43: cannot find symbol
symbol : variable popultion
location: class Prog8
sortByName(cityName,popultion,numCities);
^
Prog8.java:45: cannot find symbol
symbol : variable popultion
location: class Prog8
printData(cityName,popultion,numCities);
^
Prog8.java:47: cannot find symbol
symbol : variable popultion
location: class Prog8
sortByPopulation(cityName,popultion,numCities);
^
Prog8.java:49: cannot find symbol
symbol : variable popultion
location: class Prog8
printData(cityName,popultion,numCities);
^
Prog8.java:51: cannot find symbol
symbol : variable name
location: class Prog8
printPopulation(name,cityName,popultion,numCities);
^
Prog8.java:51: cannot find symbol
symbol : variable popultion
location: class Prog8
printPopulation(name,cityName,popultion,numCities);
^
Prog8.java:106: swap(java.lang.String[],int,int) in Prog8 cannot be applied to (double[],int,int)
swap(p, m, last);
^
Prog8.java:125: swap(java.lang.String[],int,int) in Prog8 cannot be applied to (double[],int,int)
swap(p, m, last);
^
Prog8.java:163: cannot find symbol
symbol : variable a
location: class Prog8
tmp = (a[i]);
^
Prog8.java:163: cannot find symbol
symbol : variable i
location: class Prog8
tmp = (a[i]);
^
Prog8.java:164: cannot find symbol
symbol : variable a
location: class Prog8
a[i] = (a[j]);
^
Prog8.java:164: cannot find symbol
symbol : variable i
location: class Prog8
a[i] = (a[j]);
^
Prog8.java:164: cannot find symbol
symbol : variable a
location: class Prog8
a[i] = (a[j]);
^
Prog8.java:164: cannot find symbol
symbol : variable j
location: class Prog8
a[i] = (a[j]);
^
Prog8.java:165: cannot find symbol
symbol : variable a
location: class Prog8
a[j] = (tmp);
^
Prog8.java:165: cannot find symbol
symbol : variable j
location: class Prog8
a[j] = (tmp);


So is there just something small I'm missing? I feel like the code is just about right but I'm not sure.

[Joel Allison]

Well I rewrote some stuff, but I still can't seem to find my problem. Here is the error I get, followed by the current complete code I have. Hopefully you pinpoint it, thanks in advance for any help and thanks for the help so far!

~ $ javac Prog8.java
Prog8.java:164: '}' expected

import java.util.*;

public class Prog8

{
  static Scanner sc = new Scanner(System.in);
  public static void main(String args[])
    {
      final int MAX = 1000;

      String[] cityName = new String[MAX];
      double[] population = new double[MAX];

      int numCities;

      numCities = readData(cityName,popultion);

      System.out.println("The original data");
      printData(cityName,popultion,numCities);

      sortByName(cityName,popultion,numCities);
      System.out.println("Data sorted by name");
      printData(cityName,popultion,numCities);

      sortByPopulation(cityName,popultion,numCities);
      System.out.println("Data sorted by population");
      printData(cityName,popultion,numCities);

      printPopulation(name,cityName,popultion,numCities);
    }


//Reads data from input into given arrays until name "qqqq" is
//input.  Returns number of items read.

static int readData(String[] a, double[] b)

{
  int x;
  String name;
  double pop;

  x = 0;

  name = sc.next();

  while(!name.equals("qqqq"))
    {
      pop = sc.nextDouble();

      a[x] = name.toLowerCase();
      b[x] = pop;

      x++;

      name = sc.next();
    }

  return x;
}

//Reads data from lists and prints them.

static void printData(String[] a,double[] b,int x)
{
  int y;

  for(y = 0; y < n; y++)
      System.out.println(a[y] + " " + b[y]);
}

//Sorts data from lists by name alphabetically.

static void sortByName(String[] a, double[] b,int n)
{
  int last, x, y;
  String name;
  for(last = n-1; last > 0; last--)
    {
      y = 0;
      for(x = 1; x <= last; x++)
      {
        if(a[x].compareTo(a[y]) > 0)
        swap(a, y, last);
        swap(b, y, last);
        last--;
      }
    }
}

//Sorts data from lists by population.

static void sortByPopulation(String[] a, double[] b,int n)
{
  int last, x, y;
  String name;
  for(last = n-1; last > 0; last--)
  {
    y = 0;
    for(x = 1; x <= last; x++)
    {
      if(b[x] > b[y])
      swap(a, y, last);
      swap(b, y, last);
      last--;
    }
  }
}

//This will take the second part and read the names, it will then
//search for the name in the list and if it finds it,
//it will print the population. If it does not find the
//name it will print "Not known".

static void printPopulation(String n,String[] s,double[] a,int num)
{
  int x;

  for(x=0; x < num; x++)
    if(s[x].equals(n))
      break;
  if(x < num)
    System.out.print(a[x]);
  else
    System.out.print("Not known");
}

//This function exchanges a[i] and a[j] in a list of strings.

static void swap(String[] a,int i,int j)
{
  String tmp;
  tmp.equals(a[i]);
  a[i].equals(a[j]);
  a[j].equals(tmp);
}

//This function exchanges a[i] and a[j] in a list of doubles.

static void swap(String[] a, int i, int j)
{
  double tmp;
  tmp = (a[i]);
  a[i] = (a[j]);
  a[j] = (tmp);
}

[Rob Spoor]

That } you removed should still close the class, but after all the methods, not just after the first one like you initially had.