Help: problem with EasyMock

[Daniel D. Guo]

Hello,

I tried to learn a mocking framework for testing with JUnit. EasyMock seems to be a good one, but I keep having problems with it. I am attaching the code as follows:

    
import java.io.IOException;
import java.io.InputStream;
import java.net.HttpURLConnection;
import java.net.URL;

public class WebClient {
	
	public String getContent(InputStream is){
		StringBuffer content = new StringBuffer();
		// allocating buffer for inputting
		byte[] buffer = new byte[2048];
		try{
						
			// keeping reading via connection, at most 2048 bytes at a time
			int count;
			
			while(-1 != (count=is.read(buffer))){
				content.append(new String(buffer,0,count));
			}	
		}catch(IOException e){
			return null;
		}
		
		return content.toString();
	}
	
}

import java.io.IOException;

import java.io.InputStream;
import org.easymock.classextension.ConstructorArgs;
import org.easymock.classextension.EasyMock;
import org.junit.*;

import chap6.easymock.ConstructorCalledMockTest.TaxCalculator;

import static org.easymock.classextension.EasyMock.createMock;
import static org.easymock.classextension.EasyMock.replay;
import static org.easymock.classextension.EasyMock.verify;
import static org.easymock.classextension.EasyMock.expect;
import static org.easymock.classextension.EasyMock.expectLastCall;

import static org.junit.Assert.*;

public class TestWebClientEasyMock {
	private InputStream stream;
	
	@Before
	public void setUp(){
		ConstructorArgs args = new ConstructorArgs(InputStream.class.getConstructors()[0]);
		stream = createMock(InputStream.class, args);
	}
	
	@Test
	public void testGetContentOk() throws IOException{

		// defining the behavior of mock object
		expect(stream.read()).andReturn(new Integer((byte)'W'));
		expect(stream.read()).andReturn(new Integer((byte)'o'));
		expect(stream.read()).andReturn(new Integer((byte)'r'));
		expect(stream.read()).andReturn(new Integer((byte)'k'));
		expect(stream.read()).andReturn(new Integer((byte)'s'));
		expect(stream.read()).andReturn(new Integer((byte)'!'));
		expect(stream.read()).andReturn(-1);
		EasyMock.expectLastCall().times(2, 100);
		stream.close(); [u]// supposed to call stream.close()[/u]

		// switch to the replay mode
		replay(stream);
			
		// testing logic
		WebClient client = new WebClient();
		String result = client.getContent(stream); // does not call close() on stream
		assertEquals("Works!", result);
	}

	@After
	public void tearDown(){
		verify(stream); // this method does not any error even though
					// stream.close() is never called.
	}
}

Basically, verify in tearDown cannot catch that stream.close() not being called, while it is supposed to be because "stream.close()" is specified before replay(stream) in testGetContentOk. Any idea is greatly appreciated.

Thanks a lot!

Daniel

[Jeanne Boyarsky]

Daniel,
I've moved on to jMock, but aren't you supposed to call stream.close() from within an expect method like you do for the read methods?

[Daniel D. Guo]

Jeanne,

Thanks for your post!

Actually, I was trying to create an error by not calling close.

May I ask why you switched to JMock?

Thanks,
Daniel

[Jeanne Boyarsky]

I used EasyMock pre-Java 5. Some collegues used jMock which was more powerful, but I didn't want my project to be using 2 mock frameworks and people have to switch back and forth. I did use jMock on JavaRanch proejcts and liked it better. It was easier to control and more powerful.

When we migrated to Java 5, there was an opportunity to change to something different. (easyMock and jMock both changed a lot with Java 5.) I took that as an opportunity to switch to jMock. EasyMock is a lot better now, but I still like the matchers in jMock more.