files are not delete

[Rajesh vamisetti]

i hava some file in diffrent folder in that files are not delete in windows o/s The same code is woking file in linex Please help me if any one Knows

package com.wicore.cms.test.test;

import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.FileWriter;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import java.net.SocketException;
import java.util.Properties;
import java.util.ResourceBundle;

import org.apache.commons.net.ftp.FTPClient;
import org.apache.commons.net.ftp.FTPFile;

public class UploadFtp {

	public static void main(String[] args)  {

		// Properties clientProps =
		// ResourceLoader.getAsProperties("client.properties");
		// System.out.println(clientProps.getProperty("ftpserverIP")+clientProps.getProperty("username")+clientProps.getProperty("password"));
		File fileobj = null;
		boolean flag=false;
		File folder=null;
		ResourceBundle clientProps = ResourceBundle.getBundle("ftpconfig");
		// String actualpath = "D:/TestingFolder/2009_11_20";
		/*
		 * Locale l=Locale.getDefault(); ResourceBundle messages1 =
		 * ResourceBundle.getBundle("Message",l);
		 */
		String server="",user="",password="",ftpdestfolder="",actualpath="",backupRequried="";
		try{
		server= clientProps.getString("ftpserverIP"); // Ftp Server ip
		 user = clientProps.getString("username");
		 password = clientProps.getString("password");
		 ftpdestfolder = clientProps.getString("Client"); // Folder in Ftp
																// side
		 actualpath = clientProps.getString("localFoderLocation");
		 backupRequried = clientProps.getString("backupRequired");
		
		  System.out.println("server----------------"+server);
		  System.out.println("user----------------"+user);
		  System.out.println("password----------------"+password);
		  System.out.println("ftpdestfolder----------------"+ftpdestfolder);
		  System.out.println("actualpath----------------"+actualpath);
		  System.out.println("backupRequried--------------"+backupRequried);
		}catch (Exception e) {
			// TODO: handle exception
			System.out.println(" Configuration file not configured. Please configure.");
			
		}
		server=(server==null)?"":server.trim();
		user=(user==null)?"":user.trim();
		password=(password==null)?"":password.trim();
		ftpdestfolder=(ftpdestfolder==null)?"":ftpdestfolder.trim();
		actualpath=(actualpath==null)?"":actualpath.trim();
		backupRequried=(backupRequried==null)?"":backupRequried.trim();
		  
	if(server!=null && !server.equals("")&& user!=null && !user.equals("")&& password!=null && !password.equals("") &&  password!=null && !password.equals("") )
	{	  
		actualpath =actualpath.replace("\\", "/");
		System.out.println("val --"+actualpath);
		String backupFoleder = "BACKUPFOLEDER";
		//String logFile = "D:/ftp.log";
		String theTime = "";
		String destinationPath = "";
		FTPClient ftp = new FTPClient();
		FileWriter fw = null;
		
		String FoldersName = "", ftpFolderName = "", sourceFolderPath = "", ftpFolderPath = "", ftpBackFolderPath = "";
		UploadFtp FtpUploadObj = new UploadFtp();
		try {
			ftp.connect(server);
			if (!(ftp.isConnected()))
			{
				System.out.println("Not Connected to ftp. Some configaration are not valid.");
				

			} else 
			{
				// Connection FTP Server
				ftp.login(user, password);
				System.out.println("Connected to server");
				System.out.println(ftp.getReplyString());
				System.out.println(ftp.getSystemName());
				System.out.println(ftp.printWorkingDirectory());
				String parentDir = ftp.printWorkingDirectory();
				// String ftpPrasentWokingDir=ftp.printWorkingDirectory();
				ftp.changeWorkingDirectory(ftpdestfolder);
				//System.out.println("ftp.printWorkingDirectory()"+ftp.printWorkingDirectory());
				String ftpPrasentWokingDir = ftp.printWorkingDirectory();
				
				//fw =  new FileWriter(logFile, true);
				folder = new File(actualpath);
				// Get List Of file From Local Folder.
				System.out.println("folder"+folder.getAbsolutePath());
				File[] listOfFiles = folder.listFiles();
				//System.out.println("listOfFiles.length"+listOfFiles.length);
				int size=(listOfFiles==null)?0:listOfFiles.length;
				//System.out.println("size----"+size);
				if(size>0)
				{	
				for (int i = 0; i < listOfFiles.length; i++) 
				{
					if (listOfFiles[i].isDirectory()) 
					{
						FoldersName = listOfFiles[i].getName();
						//System.out.println("FoldersName"+FoldersName);
						if (FoldersName.equalsIgnoreCase("games"))
						{
							ftpFolderName = "GAMES";
							sourceFolderPath = FtpUploadObj.sourcePath(actualpath, FoldersName);
							fileobj = new File(sourceFolderPath);
							ftpFolderPath = FtpUploadObj.ftpLocationPath(ftpPrasentWokingDir, ftpFolderName, ftp);
							ftp.changeWorkingDirectory(ftpFolderPath);
							System.out.println("CHANGED DIR=====" + ftp.printWorkingDirectory());
						} else if (FoldersName.equalsIgnoreCase("wallpapers")) 
						{
							ftpFolderName = "WALLPAPERS";
							sourceFolderPath = FtpUploadObj.sourcePath(actualpath, FoldersName);
							fileobj = new File(sourceFolderPath);
							ftpFolderPath = FtpUploadObj.ftpLocationPath(ftpPrasentWokingDir, ftpFolderName, ftp);
							ftp.changeWorkingDirectory(ftpFolderPath);
							System.out.println("CHANGED DIR=====" + ftp.printWorkingDirectory());
						} else if (FoldersName.equalsIgnoreCase("ringtones")) 
						{
							ftpFolderName = "RINGTONES";
							sourceFolderPath = FtpUploadObj.sourcePath(actualpath, FoldersName);
							fileobj = new File(sourceFolderPath);
							ftpFolderPath = FtpUploadObj.ftpLocationPath(ftpPrasentWokingDir, ftpFolderName, ftp);
							ftp.changeWorkingDirectory(ftpFolderPath);
							System.out.println("CHANGED DIR=====" + ftp.printWorkingDirectory());

						}
					 if(FoldersName.equalsIgnoreCase("games")|| FoldersName.equalsIgnoreCase("wallpapers")||FoldersName.equalsIgnoreCase("ringtones"))
					 {	
						File[] listFiles = fileobj.listFiles();
						int sizeVal=(listFiles==null)?0:listFiles.length;
						if(sizeVal>0)
						{	
							 for (int j = 0; j < listFiles.length; j++) 
							{
	
								if (listFiles[j].isFile()) 
								{
									flag = ftp.storeFile(listFiles[j].getName(), new FileInputStream(listFiles[j]));
									if (flag) 
									{
										System.out.println(listFiles[j].getName() + " is Success fully Uploaded");
									} else 
									{
										System.out.println(listFiles[j].getName() + " is Not Uploaded");
									}
								}
							}
					   }
					   else
					   {
							System.out.println("Source "+FoldersName+" have no files");
					   }	
						
					 }
					}
					
				}
				
				if(flag)
				{
					//SendMail.sendMail("Status of upload content","Successfully Uploaded ");
				}
				if (backupRequried.equalsIgnoreCase("yes"))
				{
					boolean flagval=false;
					String tempFolderName="";
					File sourceDir = null;
					File destinationDir=null;
				    String destinationFolder=FtpUploadObj.sourcePath(actualpath, backupFoleder);
				    destinationDir=new File(destinationFolder);
				    sourceDir=new File(actualpath);
				///    File ffs=new File(sourceDir.getAbsolutePath());
				    System.out.println("destinationDir"+destinationDir.getAbsolutePath());
				    System.out.println("sourceDir"+sourceDir.getAbsolutePath());
				    
				    System.out.println("----------------------backupstarted--------------------------------");
				    flagval=FtpUploadObj.copyDirectory(sourceDir, destinationDir);
				 if(flagval){
						  
					 //sourceDir=null;  
					 	System.out.println("File or directory moved successfully.");
					     delete(sourceDir);
					 
					    
					 
					   }
					    else{
					  
					    //System.exit(0);
					    	System.out.println("Source have no files");
					   
					 }
				    
				 
				  }	 
				
				
				 

					
				
				
				

				
			}
		    else
		    {
		    	System.out.println("Source folder have no files");
		    	
		    }	
				

				

			}
		} catch (SocketException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (FileNotFoundException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		} catch (IOException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		finally{
			
			try {
				ftp.logout();
				ftp.disconnect();
				//fw.close();
			} catch (IOException e) {
				// TODO Auto-generated catch block
				e.printStackTrace();
			}

			
		}

	}
	else{
		
		System.out.println("No Data in Configaration file");
		
	}
}

	private String sourcePath(String actualpath, String folderName) {
		String path = actualpath + File.separator + folderName;
		File fileString = new File(path);
		if (!fileString.exists()) {
			fileString.mkdirs();
			//fileString=null;
		}

		return path;
	}

	private String ftpLocationPath(String actualpath, String folderName, FTPClient ftpObj) {
		// TODO Auto-generated method stub
		String fileName = "", path = "", ftpPath = "";
		try {
			FTPFile[] listFiles = ftpObj.listFiles();
			int len = (listFiles == null) ? 0 : listFiles.length;
			// String path=actualpath+File.separator+folderName;
			if (listFiles != null && len > 0) {
				for (int i = 0; i < listFiles.length; i++) {

					if (fileName.equalsIgnoreCase(listFiles[i].getName())) {

						path = actualpath + "/" + listFiles[i].getName();

						// ftpObj.changeWorkingDirectory(path);
						// ftpPath=ftpObj.printWorkingDirectory();

					} else {
						path = actualpath + "/" + folderName;
						ftpObj.makeDirectory(path);
						// ftpObj.changeWorkingDirectory(path);
						// ftpPath=ftpObj.printWorkingDirectory();

					}
				}

			} else {
				path = actualpath + "/" + folderName;
				ftpObj.makeDirectory(path);

				// ftpObj.changeWorkingDirectory(path);
				// ftpPath=ftpObj.printWorkingDirectory();
			}

		} catch (Exception e) {
			// TODO: handle exception
		}
		return path;

	}
public  boolean copyDirectory(File sourceDir, File destDir)
     throws IOException{
	
	boolean falgs=false;
System.out.println("sourceDir"+sourceDir.getAbsolutePath());
System.out.println("destDir"+destDir.getAbsolutePath());
try{
if(!destDir.exists()){

destDir.mkdir();

}
File destChild=null;
File[] children = sourceDir.listFiles();
int sizes=(children==null)?0:children.length;
System.out.println("children"+children.length);
if(sizes>0)
{	
for(File sourceChild : children){

	String name = sourceChild.getName();
	System.out.println("name"+name);
	if(!name.equalsIgnoreCase("BACKUPFOLEDER"))
	{	
		destChild = new File(destDir.getAbsolutePath());
	//System.out.println("destChild---------"+destChild);
	if(sourceChild.isDirectory()){
		
		destChild = new File(destDir+File.separator+name);	
	copyDirectory(sourceChild, destChild);

	}
 else{
	  
	 
      copyFile(sourceChild, destChild);
     
     }
	
	falgs=true;
	}
	else{
		falgs=false;
	}
	
}

}else
{
	falgs=false;
}	

}catch (Exception e) {
	// TODO: handle exception
	falgs=false;
}
return falgs;
}
/*for(File sourceChild : children){

String name = sourceChild.getName();

File destChild = new File(destDir, name);

if(sourceChild.isDirectory()){

copyDirectory(sourceChild, destChild);

}

else{

copyFile(sourceChild, destChild);

}

}*/



public  synchronized void copyFile(File source, File dest) throws IOException {
	 
	String fileString= source.getName(); 
	File ff= new File (dest+File.separator+fileString);
	if(!ff.exists()){
	  
	    //dest.createNewFile();
		   System.out.println(" dosent exits....");
	  
	    }
	   
	InputStream in = null;
	  
	    OutputStream out = null;
	    
	  
	    try{
	    	System.out.println("source---"+source.getAbsolutePath());
	    	System.out.println("destination---"+dest.getAbsolutePath());
	    	//Thread.currentThread().sleep(2000);
	    	/*if(source.renameTo(new File(dest, source.getName()))){
	    		
	    		System.out.println("success fully Uploaded ");
	    		
			}*/
	    	//Thread.currentThread().sleep(2000);
	     in = new FileInputStream(source);

	        out = new FileOutputStream(ff);
	  
	      byte[] buf = new byte[1024];

	        int len;
	  
	      while((len = in.read(buf)) > 0){
	  
	        out.write(buf, 0, len);

	            }
	      //boolean delete = delete(source);
	      System.out.println("source-----"+source);
	   
	    } catch (Exception e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
	  finally{
	 
	           in.close();
	           out.close();
	  
	        }
	  
	  }


/*public static boolean delete(File dir) {
	System.out.println("rajesh-----------");
	File dir2 = dir;
	
	if (dir2.isDirectory()) {
		if(!dir2 .getName().equalsIgnoreCase("BACKUPFOLEDER"))
		{		
	String[] children = dir2.list();
	for (int i=0; i<children.length; i++) {
	boolean success = delete(new File(dir2, children[i]));
	System.out.println("success---------"+success);
	if (!success) {
	return false;
	}
	}
		}
	}
	System.out.println("dir2======="+dir2.getAbsolutePath());
	System.gc();
	boolean delete = dir2.delete();
	System.out.println("delete----------"+delete);
	// The directory is now empty so delete it
	return delete;
	} */

public static void delete(File resource) throws IOException{ 
	
	System.out.println("resource"+resource.getAbsolutePath());	
	boolean delete;
	if(resource.isDirectory()){
		  
	      File[] childFiles = resource.listFiles();
	  
	      for(File child : childFiles){

		if(!child .getName().equalsIgnoreCase("BACKUPFOLEDER"))
	{	
	  	 System.out.println("------"+child.getAbsolutePath());
			
			if(child.isFile())
			{	
				System.out.println("child^^^^^^^^^^"+child.getName());
				System.out.println("....///"+child.canExecute());
			//	System.out.println("....///"+child.);
				delete = child.delete();
				System.out.println(" delete.........."+delete);
				//deleteFile(child.getAbsolutePath());
			}
			else{
				
				delete(child);
				
			}

	}
	}
	   
	 }
	   


	      
}  
	 
	  
	  
		 
		 /*if(child.isDirectory())
		{
			delete(child);
			
			
		}
		else{
			if(child.isFile());
			
			System.out.println("child----"+child.getName());
			System.out.println("child*****"+child.getAbsolutePath());
			boolean delete = child.delete();
			System.out.println("delete"+delete);
			//String fileString=child.getAbsolutePath();
			//System.out.println("fileString"+fileString);
			
			//deletfile=new File(fileString);
			if(deletfile.exists())
			{
				boolean delete = deletfile.delete();
				System.out.println("delete"+delete);
				//System.out.println(deletfile.getName());
			}
			//child.deleteOnExit();
			//System.out.println("delete"+delete);
		}
	 }*/
   // delete(child);
}

[Christophe Verré]

Welcome to the Ranch ! Next time, don't forget to UseCodeTags to make your source more readable. I've added them for you.

[Pat Farrell]

Yes, welcome to the Java Ranch. It would help us to help you if you can cut your code down to a much smaller size. For a file opening error, can you get it down to ten lines or so of real code directly relating to the problem?

[Rob Spoor]

If a file cannot be deleted it means it is still in use. That can be by an external program, or you may have forgotten to close a Reader, Writer, InputStream or OutputStream for the file.

You can check which process still holds locks on the file using the free tool Process Explorer. Start it up, select Find -> Find Handle or DLL..., type in the name of your file and press Search. You then get a full list of all processes that have a lock on any file that matches your search criteria. If this list is empty after you close the JVM then the problem must be in a remaining open reader, writer or stream.