java.lang.ArrayIndexOutOfBoundsException: 1

[Farakh khan]

"<table border=0  
		"    >"+
		
		"<tr>"+
		"<td  class=question >Question</td>"+
		"<td><textarea name='question' class='question' cols=70 rows=5></textarea></td>"+
		"</tr>"+		
		"<tr>"+
		"<td ><input type=radio name='correctAnswer' value='1'></td>"+
		"<td><input type=text name='answer' class=input size=61></td>"+
		"</tr>"+		
		"<tr>"+
		"<td ><input type=radio name='correctAnswer' value='1'></td>"+
		"<td><input type=text name='answer' class=input size=61></td>"+
		"</tr>"+		
		"<tr>"+
		"<td ><input type=radio name='correctAnswer' value='1'><br><br><br></td>"+
		"<td><input type=text name='answer' class=input size=61><br>"+
		"<font color=red size=1 face='verdana'>Please select correct answer</font><br><br></td>"+
		"</tr>");		


String query2="insert into HRTestAnswers(question_id,answers,correct_answer) values(?,?,?)";

	PreparedStatement ps5=cnn.prepareStatement(query2);
			for (int i=0;i<answer.length;i++){
  				if(!answer[i].equals("")){
					
				if(correctAnswer[i]==null || correctAnswer[i].equals("")){
				correctAnswer[i]="0";
				}

					ps5.clearParameters();
					ps5.setInt(1, questionId);
					ps5.setString(2, answer[i]);
					ps5.setString(3, correctAnswer[i]);
					ps5.addBatch();    
					}
				ps5.executeBatch();
				}
			ps5.close();				

(1) The parameter "answer[i]" have 3 parameters values
(2) The "correctAnswer[i]" also have 3 parameters values i.e. one parameter value as 1 and two are null. I tried to assign "0" to null values but my code is inserting into DB only "answer[i]" that has not null "correctAnswer[i]" i.e. one field out of three whereas I want to insert whole 3 fields as 'if they null then 0 and if not null then 1'

Thanks in advance>

[Jeanne Boyarsky]

Consider what the code looks like with indentation that matches it.

PreparedStatement ps5=cnn.prepareStatement(query2);
for (int i=0;i<answer.length;i++){
    if(!answer[i].equals("")){
        if(correctAnswer[i]==null || correctAnswer[i].equals("")){
		correctAnswer[i]="0";
	}
	ps5.clearParameters();
	ps5.setInt(1, questionId);
	ps5.setString(2, answer[i]);
	ps5.setString(3, correctAnswer[i]);
	ps5.addBatch();    
    }
    ps5.executeBatch();
}

As you can see, this doesn't set the three values with anything. What if you ended the if statement earlier?

[edited to end code block properly]

[Farakh khan]

Jeanne Boyarsky wrote:Consider what the code looks like with indentation that matches it.

As you can see, this doesn't set the three values with anything. What if you ended the if statement earlier?

[edited to end code block properly]

Thanks for your reply.

I edited as you directed but now not inserting any record. My new code

PreparedStatement ps5=cnn.prepareStatement(query2);
for (int i=0;i<answer.length;i++){
    if(!answer[i].equals("")){
        if(correctAnswer[i]==null || correctAnswer[i].equals("")){
		correctAnswer[i]="0";
		ps5.clearParameters();
	ps5.setInt(1, questionId);
	ps5.setString(2, answer[i]);
	ps5.setString(3, correctAnswer[i]);
	ps5.addBatch();    
    }}
    ps5.executeBatch();
}

I think its not a if block problem but related to inserting two arrays at a time. I think when cursor is comming to answer[i] then i=0 but when its comming to correctAnswer[i] then it skipping correctAnswer[0] and working as correctAnswer[1]. This is the real problem. Is that what I think?

Thanks again and profound regards

[Farakh khan]

Can anybody please help me as this is 2nd day I stuck and not able to solve the problem.

Thanks again & best regards

[Jeanne Boyarsky]

Farakh khan wrote:I edited as you directed but now not inserting any record.

As it shouldn't - your code skips the whole block. That wasn't quite the edit I had in mind.

String answerToSet;
String correctAnswerToSet;
if(conditionsForDefault){  
  answerToSet = "0";
  correctAnswerToSet = "0";
} else {
  answerToSet = answer[i];
  correctAnswerToSet = correctAnswer[i];
}
ps5.clearParameters();  
ps5.setInt(1, questionId);  
ps5.setString(2, answerToSet );  
ps5.setString(3, correctAnswerToSet );  
ps5.addBatch();      
}  

This assumes the arrays are the same length. If not, you have a more fundamental design problem that needs more custom logic.

[Jeanne Boyarsky]

Farakh khan wrote:Can anybody please help me as this is 2nd day I stuck and not able to solve the problem.

Thanks again & best regards

Please keep in mind we are all volunteers and PatienceIsAVirtue

[Farakh khan]

I never disappointed at this forum. Always got positive & accurate replies

The problem fixed. Thanks from the core of my heart. Appreciated