Struts1: Nested/Indexed properties issue

[shai ban]

Hi all,
I am facing the below exception...

javax.servlet.ServletException: BeanUtils.populate
	org.apache.struts.util.RequestUtils.populate(RequestUtils.java:1098)
	org.apache.struts.action.RequestProcessor.processPopulate(RequestProcessor.java:816)
	org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:254)
	org.apache.struts.action.ActionServlet.process(ActionServlet.java:1420)
	org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:520)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

root cause 
java.lang.NullPointerException
	org.apache.commons.beanutils.PropertyUtils.getIndexedProperty(PropertyUtils.java:515)
	org.apache.commons.beanutils.PropertyUtils.getIndexedProperty(PropertyUtils.java:428)
	org.apache.commons.beanutils.PropertyUtils.getNestedProperty(PropertyUtils.java:770)
	org.apache.commons.beanutils.PropertyUtils.getProperty(PropertyUtils.java:801)
	org.apache.commons.beanutils.BeanUtils.setProperty(BeanUtils.java:881)
	org.apache.commons.beanutils.BeanUtils.populate(BeanUtils.java:808)
	org.apache.struts.util.RequestUtils.populate(RequestUtils.java:1096)
	org.apache.struts.action.RequestProcessor.processPopulate(RequestProcessor.java:816)
	org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:254)
	org.apache.struts.action.ActionServlet.process(ActionServlet.java:1420)
	org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:520)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:717)

Below is the code....

JSP snippet:

<logic:iterate id="orderItem" name="OrderIndexedForm" property="orderList" indexId="index" >
            <html:hidden name="orderItem" property="productId" indexed="true" />
            <tr>
                <td><bean:write name="orderItem" property="productId"  /></td>
                <td><html:text name="orderItem" property="productName" indexed="true" /></td>
                <td><html:text name="orderItem" property="quantity" size="30" indexed="true" /></td>
            
	            <logic:iterate id="add" name="orderItem" property="orderAddress" indexId="index1" >
	            	<td>
	            	<html:text name="orderItem" property='<%= "orderAddress[" + index1 + "].address" %>' indexed="true"/>
	            	</td>
	            </logic:iterate>
            
            </tr>
        </logic:iterate>

ActionForm and Beans:

public class OrderIndexedForm extends ActionForm {

	private List orderList; // list of OrderItem objects

	public void setOrderList(List orderList) {
		this.orderList = orderList;
	}

	public List getOrderList() {
		return this.orderList;
	}

	public OrderItem getOrderItem(int index) {
		System.out.println("------------- getOrderItem() is called");
		if (this.orderList == null) {
			this.orderList = new ArrayList();
		}

		while (index >= this.orderList.size()) {
			this.orderList.add(new OrderItem());
		}
		return (OrderItem) orderList.get(index);
	}
		
	public void setOrderItem(int index){
		System.out.println("------------- setOrderItem() is called");
	}

}


public class OrderItem {
	private String productId;
	private String productName;
	private String quantity;

	private List orderAddress;

	public OrderItem() {

	}

	public OrderItem(String productId, String productName, String quantity,
			List orderAddress) {
		this.productId = productId;
		this.productName = productName;
		this.quantity = quantity;
		this.orderAddress = orderAddress;
	}

	public String getProductId() {
		return productId;
	}

	public void setProductId(String productId) {
		this.productId = productId;
	}

	public String getProductName() {
		return productName;
	}

	public void setProductName(String productName) {
		this.productName = productName;
	}

	public String getQuantity() {
		return quantity;
	}

	public void setQuantity(String quantity) {
		this.quantity = quantity;
	}

	public List getOrderAddress() {
		return orderAddress;
	}

	public void setOrderAddress(List orderAddress) {
		this.orderAddress = orderAddress;
	}

	public OrderAddress getOrderAddress(int index) {

		System.out
				.println("------------- OrderItem.getOrderAddress() is called");
		// make sure that orderList is not null
		if (this.orderAddress == null) {
			this.orderAddress = new ArrayList();
		}

		// indexes do not come in order, populate empty spots
		while (index >= this.orderAddress.size()) {
			this.orderAddress.add(new OrderAddress());
		}

		// return the requested item
		return (OrderAddress) orderAddress.get(index);
	}
	
	@Override
	public String toString() {

		StringBuilder str = new StringBuilder();
		str.append("[productId: ").append(this.productId).append(
				", productName: " + this.productName).append(
				", quantity: " + this.quantity).append(
				"address: " + this.orderAddress + "]");
		return str.toString();
	}
}


public class OrderAddress {
	private String address;
	//private String billingAddress;
	
	public OrderAddress(){}
	
	public OrderAddress(String add){
		this.address = add;
		//this.billingAddress = billingAdd;
	}

	

	public String getAddress() {
		return address;
	}

	public void setAddress(String address) {
		this.address = address;
	}

	@Override
	public String toString() {

		StringBuilder str = new StringBuilder();
		str.append("[Address: ").append(this.address).append("]");

		return str.toString();
	}

}

When we see the html source, there is property named "orderItem[0].orderAddress[0].address". I think first it will call getOrderItem(index) then getOrderAddress(index) and then setAddress... but I am not able to debug.
Let me know if you need any other snippet of my code.

Please provide some solution.

[shai ban]

Will anybody reply here

[Sara El-Kady]

Hi Shai,

I'm new to struts too but I'll try to help ..

I think you should write it as follow

   <logic:iterate id="add" name="orderItem" property="orderAddress" >  
                     <td>  
                     <html:text name="orderItem" property="address"/>  
                     </td>  
                 </logic:iterate>     

[shai ban]

Thanks for replying Sara but I don't think it is correct. Because

address

property is in

orderaddress

not into

orderitem

?
Am I wrong?

Sara El-Kady wrote:Hi Shai,

I'm new to struts too but I'll try to help ..

I think you should write it as follow

   <logic:iterate id="add" name="orderItem" property="orderAddress" >  
                     <td>  
                     <html:text name="orderItem" property="address"/>  
                     </td>  
                 </logic:iterate>     

[Khalil Salman]

Hi Shai,
I got the same issue..

Did you solve that problem finally?