BeanInstantiationException

[syruss kumar]

Hi all,
I have created a simple Bean which will insert the values in to the database. While executing that i got this error:
javax.faces.FacesException: Problem in renderResponse: Error creating bean with name 'dbBean' defined in ServletContext resource [/WEB-INF/springapp-servlet.xml]: Instantiation of bean failed; nested exception is org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [org.openi.web.ui.jsf.bean.reports.analysis.DBBean]: Constructor threw exception; nested exception is java.lang.NullPointerException
com.icesoft.faces.facelets.D2DFaceletViewHandler.renderResponse(D2DFaceletViewHandler.java:294)
com.icesoft.faces.application.D2DViewHandler.renderView(D2DViewHandler.java:161)
com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:107)
com.sun.faces.lifecycle.LifecycleImpl.phase(LifecycleImpl.java:245)
com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:137)
com.icesoft.faces.webapp.http.core.JsfLifecycleExecutor.apply(JsfLifecycleExecutor.java:18)
com.icesoft.faces.webapp.http.core.PageServer$1.respond(PageServer.java:25)
com.icesoft.faces.webapp.http.servlet.ServletRequestResponse.respondWith(ServletRequestResponse.java:161)
com.icesoft.faces.webapp.http.servlet.ThreadBlockingAdaptingServlet$ThreadBlockingRequestResponse.respondWith(ThreadBlockingAdaptingServlet.java:36)
com.icesoft.faces.webapp.http.core.PageServer.service(PageServer.java:30)
com.icesoft.faces.webapp.http.core.SingleViewServer.service(SingleViewServer.java:48)
com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer$Matcher.serviceOnMatch(PathDispatcherServer.java:50)
com.icesoft.faces.webapp.http.common.standard.PathDispatcherServer.service(PathDispatcherServer.java:19)
com.icesoft.faces.webapp.http.servlet.ThreadBlockingAdaptingServlet.service(ThreadBlockingAdaptingServlet.java:19)
com.icesoft.faces.webapp.http.servlet.EnvironmentAdaptingServlet.service(EnvironmentAdaptingServlet.java:63)
com.icesoft.faces.webapp.http.servlet.MainSessionBoundServlet.service(MainSessionBoundServlet.java:139)
com.icesoft.faces.webapp.http.servlet.SessionDispatcher.service(SessionDispatcher.java:53)
com.icesoft.faces.webapp.http.servlet.PathDispatcher$Matcher.serviceOnMatch(PathDispatcher.java:52)
com.icesoft.faces.webapp.http.servlet.PathDispatcher.service(PathDispatcher.java:29)
com.icesoft.faces.webapp.http.servlet.MainServlet.service(MainServlet.java:82)
javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
org.openi.security.AuthorizationFilter.doFilter(AuthorizationFilter.java:98)


My Bean code is:

 package org.openi.web.ui.jsf.bean.reports.analysis;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.SQLException;
import java.util.Calendar;
import java.util.GregorianCalendar;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.jsp.PageContext;
import javax.sql.DataSource;

import org.openi.analysis.Analysis;
import org.openi.jdbc.ConnectionFactory;
import org.openi.project.JdbcDatasource;
import org.openi.project.ProjectContext;
import org.openi.project.cms.ContentItem;

public class DBBean {

	private String comments;
	private String reportName;
	private String reporter;
	private Analysis analysis;
	private ProjectContext projectContext;
	private ContentItem selectedReport = null;
	Connection connection;
	PreparedStatement ptsmt;
	ConnectionFactory connectionfactory=new ConnectionFactory();

	public String getComments() {
		return comments;
	}
	public void setComments(String comments) {
		this.comments = comments;
	}
	public String getReportName() {
		return reportName;
	}
	public void setReportName(String reportName) {
		analysis=new Analysis();
		this.reportName =analysis.getAnalysisTitle() ;
	}
	public String getReporter() {

		return reporter;
	}
	public void setReporter(String reporter) {
		projectContext=new ProjectContext();
		this.reporter = projectContext.getUser().getFullName();
	}
	public void insertValues(){
		boolean result=false;
		Calendar cal= new GregorianCalendar();
		String query="Insert into reportFeedback values('"+getReporter()+"','"+getReportName()+"','"+getComments()+"',"+cal.getTime()+")";
		JdbcDatasource datasource=(JdbcDatasource) projectContext.getReportDatasource(selectedReport.getPath());

		try {
			connectionfactory.getConnection(datasource);
			if(ptsmt.execute(query)==true){
				result=true;
			}

		} catch (ClassNotFoundException e) {

			e.printStackTrace();
		} catch (SQLException e) {

			e.printStackTrace();
		}		
		finally{
			connectionfactory.cleanupConnection(connection);
		}


	}


}
   

Can anyone suggest me to resolve this issue?
Thanks in advance.

[Costi Ciudatu]

Can you also post the code for ConnectionFactory ?

(By the way, you should consider using dependecny injection for referencing a ConnectionFactory, since you're making use of Spring, but that's a whole different matter).

[Costi Ciudatu]

Sorry, I now realized that ConnectionFactory is not one of your classes, it's from an API However, I still suspect that NPE is thrown by the 'new ConnectionFactory()' line.

[syruss kumar]

Thanks for your reply Costi.
Here is the code for connectionFactory

 
package org.openi.jdbc;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.SQLException;
import java.util.Properties;

import org.apache.log4j.Logger;
import org.openi.project.JdbcDatasource;

/**
 * Factory class, returns a java.sql.Connection, should also be modified to wrap a 
 * connection pool datasource. 
 * 
 * sqlserver 	
 * net.sourceforge.jtds.jdbc.Driver 
 * jdbc:jtds:sqlserver://server:1433/db;user=userName;password=password
 * 
 * mysql 
 * com.mysql.jdbc.Driver
 * jdbc:mysql://your_server:3306/your_database
 * 
 * postgres 
 * org.postgresql.Driver
 * jdbc:postgresql://host:5432/database?user=userName&password=pass 
 * 
 */
public class ConnectionFactory{
	private static Logger logger = Logger.getLogger(ConnectionFactory.class); 
	
	/**
	 * TODO: modify to retrieve from connection pool
	 * @param driver
	 * @param url
	 * @param props
	 * @return
	 * @throws ClassNotFoundException
	 * @throws SQLException
	 */
	public static Connection getConnection(String driver, 
			String url, 
			Properties props) throws ClassNotFoundException, SQLException{
		
		// props.put("DATABASENAME", "stage_apple");
        Class.forName(driver);
        return DriverManager.getConnection(url, props);
	}

	/**
	 * utility method that cleans up the connection, while trapping
	 * and logging only the messages
	 */
	public static void cleanupConnection(Connection conn){
		if (conn == null)
			return;
		logger.debug("cleaning up connection");
		try{
			conn.close();
		}catch(SQLException e){
			logger.error(e);
		}
		finally{
			conn = null;
		}
	}

	public static Connection getConnection(JdbcDatasource datasource) throws ClassNotFoundException, SQLException {
		Class.forName(datasource.getDriverClassName());
		return DriverManager.getConnection(datasource.getUrl(), 
				datasource.getUsername(), 
				datasource.getPassword());
	}
}

   

[syruss kumar]

Hi costi ,

springapp-servlet.xml entry is .

<!--New Bean Entry-->
<bean id="DBBean" class="org.openi.web.ui.jsf.bean.reports.analysis.DBBean" scope="session"/>

<!--Entry ends here-->

If i want to instaniate another bean i have to given that in property attribute .am i right ?
I dont have any dependency bean with DBBean.

Please suggest me to resolve this .

Thanks in advance.

[Joe Harry]

syruss kumar wrote:Hi costi ,

springapp-servlet.xml entry is .

<!--New Bean Entry-->
<bean id="DBBean" class="org.openi.web.ui.jsf.bean.reports.analysis.DBBean" scope="session"/>

<!--Entry ends here-->

If i want to instaniate another bean i have to given that in property attribute .am i right ?
I dont have any dependency bean with DBBean.

Please suggest me to resolve this .

Thanks in advance.

Check the bean id... is it DBBean or dbBean?? See the stack trace of yours...