JSP - cookie not processing as it should

Hi,

I've been trying to get the jsp to display a table to show the name enter from a form.

However, it doesn't show the table which will display the Name, Value and Comments.

Hope someone can advise me where have I gone wrong with my codes. Thanks.

<%@ page language="java"  %>
<%
String cookieName = "username";
Cookie cookies[] = request.getCookies();
Cookie c = null;
 out.println("<html><head><title>Servlet Cookie2St Information</title>"
	+ "</head><body>");
if ( (cookies == null) || (cookies.length == 0) ){
		out.println("No cookies found");
	} else {
	    out.println("<center><h1>Cookies found in the request</h1></center>"
	    + "<table border><tr><th>Name</th> <th>Value</th><th>Comment</th>"
	    + "<th>Max Age</th></tr>");
	    for (int i=0; i<cookies.length; i++) {
		out.println("<tr><td>" + c.getName() + "</td>" +
		"<td>" + c.getValue() + "</td>" +
		"<td>" + c.getComment() + "</td>" +
		"<td>" + Integer.toString(c.getMaxAge()) + "</td></tr>");
	     }
	    out.println("</table>");
	}

}
%>
<html>
<head>
<title>Show Saved Cookie</title>
</head>
<body>

<%
if (c == null) {
%>
No Cookie found with the name <%=cookieName%>
<%
} else {
%>

<center><h1>Cookies found in the request</h1></center>
	    + "<table border><tr><th>Name</th> <th>Value</th><th>Comment</th>"
	    + "<th>Max Age</th></tr></table>");
                out.println("<tr><td>" + c.getName() + "</td>" +
		"<td>" + c.getValue() + "</td>" +
		"<td>" + c.getComment() + "</td>" +
		"<td>" + Integer.toString(c.getMaxAge()) + "</td>"+
	     	     %>
<%
}
%>
</body>

Firstly, why are you using out.print to emit HTML code? That's why we use JSP in the first place... so that we can just use template text for HTML.

Secondly, you are not generating valid HTML. Do a View Source in the browser and look at the HTML that is being sent to the browser. You'll see that it's a mess.

OK. I will remove the html portion.

But, please advise the jsp portion how to make it correct. Sorry this is my first attempt in a jsp so not very sure.

It's not clear that there's anything wrong with your JSP at all... except for the fact that you are putting Java code in a JSP -- a practice that has been frowned upon for over 8 years now.

If your JSP is not creating valid HTML, the display will not be correct. Making sure that valid HTML is being generated is the first step to even determining if there are any other problems.

Cookie c is never assigned a value. And ++ on what Bear said. Why is java+jsp code together like that ? Separate your view components and place them in your JSP