How to retrieve string from EditText?

[Pramod P Deore]

I am writing one application in that I am taking input from user and sending it through sms, but my problem is that I am not able to get that string(i.e. which is given from user as a input )

suppose I have following in the main.xml file

  

<?xml version="1.0" encoding="utf-8"?>
<AbsoluteLayout
android:id="@+id/widget0"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
xmlns:android="http://schemas.android.com/apk/res/android"
>
<LinearLayout
android:id="@+id/widget30"
android:layout_width="214px"
android:layout_height="229px"
android:orientation="vertical"
android:layout_x="73px"
android:layout_y="49px"
>
<TextView  
        android:layout_width="fill_parent"  
        android:layout_height="wrap_content"  
        android:text="Login:"  
/>  
<EditText  
        android:id="@+id/name"  
        android:singleLine="true"  
        android:layout_width="fill_parent"  
        android:layout_height="wrap_content"  
/>  

<Button
android:id="@+id/ok"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Ok"
>
</Button>
</LinearLayout>
</AbsoluteLayout>

 

It have one TextField, one EditText and one Button.
Now when user write input to EditText then that String I want to send through the sms.

my Test.java contains

 

public class Test extends Activity
{
	
	private EditText name;
	Button ok;   
	String username;





    /** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        
        name = (EditText)findViewById(R.id.name);   
        ok = (Button)this.findViewById(R.id.ok);
        
         username = name.getText().toString(); 
        
        ok.setOnClickListener(okListener); 
        
        
    }
    private OnClickListener okListener = new OnClickListener()
    {
        public void onClick(View v)
        {       
        		sendSMS("9960510915",username);
        	
        	
        }
        
    };
    

     public  void sendSMS(String phoneNumber, String message)
    {        
        //code for sending sms
    }

}
 

Now when I run this and if I supplied input to form as "Pramod Deore" but when I I click on ok button it throws Exception

[Monu Tripathi]

Can you post the exception?

[Pramod P Deore]

Actually It only show following attached screen but on Logcat it does not shows exception.
Thanks for quick reply

[Pramod P Deore]

It shows following error as IllegalArgumentException

 

02-04 16:36:22.556: ERROR/AndroidRuntime(713): Uncaught handler: thread main exiting due to uncaught exception
02-04 16:36:22.596: ERROR/AndroidRuntime(713): java.lang.IllegalArgumentException: Invalid message body
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.telephony.gsm.SmsManager.sendTextMessage(SmsManager.java:74)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.micro.Test.sendSMS(Test.java:126)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.micro.Test$1.onClick(Test.java:60)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.View.performClick(View.java:2179)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.View.onTouchEvent(View.java:3828)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.widget.TextView.onTouchEvent(TextView.java:6291)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.View.dispatchTouchEvent(View.java:3368)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:863)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:863)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:863)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:863)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:863)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:1707)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1197)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.app.Activity.dispatchTouchEvent(Activity.java:1993)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:1691)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.view.ViewRoot.handleMessage(ViewRoot.java:1525)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.os.Handler.dispatchMessage(Handler.java:99)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.os.Looper.loop(Looper.java:123)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at android.app.ActivityThread.main(ActivityThread.java:3948)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at java.lang.reflect.Method.invokeNative(Native Method)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at java.lang.reflect.Method.invoke(Method.java:521)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:782)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:540)
02-04 16:36:22.596: ERROR/AndroidRuntime(713):     at dalvik.system.NativeStart.main(Native Method)


 

[Monu Tripathi]

I suspect, you have not pasted the piece of code that is causing that exception. I do not see SmsManager.sendTextMessage being called anywhere in your code.

[Pramod P Deore]

my method which send sms is as follows

  

public  void sendSMS(String phoneNumber, String message)
    {        
        String SENT = "SMS_SENT";
        String DELIVERED = "SMS_DELIVERED";
 
        PendingIntent sentPI = PendingIntent.getBroadcast(this, 0,new Intent(SENT), 0);
 
        PendingIntent deliveredPI = PendingIntent.getBroadcast(this, 0,new Intent(DELIVERED), 0);
 
        //---when the SMS has been sent---
        registerReceiver(new BroadcastReceiver(){
           
            public void onReceive(Context arg0, Intent arg1)
            {
                switch (getResultCode())
                {
                    case Activity.RESULT_OK:
                        Toast.makeText(getBaseContext(), "", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_GENERIC_FAILURE:
                        Toast.makeText(getBaseContext(), "Generic failure", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_NO_SERVICE:
                        Toast.makeText(getBaseContext(), "No service", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_NULL_PDU:
                        Toast.makeText(getBaseContext(), "Null PDU", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_RADIO_OFF:
                        Toast.makeText(getBaseContext(), "Radio off", 
                                Toast.LENGTH_SHORT).show();
                        break;
                }
            }
        }, new IntentFilter(SENT)); 
 
        //---when the SMS has been delivered---
        registerReceiver(new BroadcastReceiver()
        {
                public void onReceive(Context arg0, Intent arg1)
                {
                	switch (getResultCode())
                	{
                    	case Activity.RESULT_OK:
                        Toast.makeText(getBaseContext(), "",Toast.LENGTH_SHORT).show();
                        break;
                    	case Activity.RESULT_CANCELED:
                        Toast.makeText(getBaseContext(), "SMS not delivered",Toast.LENGTH_SHORT).show();
                        break;                        
                	}
                }
        },new IntentFilter(DELIVERED));        
 
        SmsManager sms = SmsManager.getDefault();
        sms.sendTextMessage(phoneNumber, null, message, sentPI, deliveredPI);        
    }
  
    	

 

[Pramod P Deore]

If I had write

  
sendSMS("9960510915","pramod deore");
 

instead of

sendSMS("9960510915",username);   

Then I get message successfully,
i.e username is not converted into String but how?

[Monu Tripathi]

sms.sendTextMessage(phoneNumber, null, message, sentPI, deliveredPI);  

Does the API permit any of the addresses to be null? What does the documentation say?

[Pramod P Deore]

But when I pass second argument as "Pramod Deore" i.e. String then it runs successfully. But if I pass username (i.e which is get from EditText) then it throws Exception.

[Monu Tripathi]

But when I pass second argument as "Pramod Deore" i.e. String then it runs successfully. But if I pass username (i.e which is get from EditText) then it throws Exception.

Have you tried to print the value you read from the EditText and see what you are getting? Is it null? Is it empty? Are you passing what you are actually reading to the sendSMS() method?

[Pramod P Deore]

Hello , today I write new application
My Test1.java is like

package com.micro;

import android.app.Activity;
import android.app.PendingIntent;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.os.Bundle;
import android.telephony.gsm.SmsManager;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.EditText;
import android.widget.Toast;

public class Test1 extends Activity
{
	EditText name,no;
	Button ok;
	String nm,mob;
	/** Called when the activity is first created. */
    @Override
    public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.main);
        
        name = (EditText)findViewById(R.id.name);
        no = (EditText)findViewById(R.id.no);
        Button ok  = (Button)findViewById(R.id.ok);
        
        
        nm = name.getText().toString();
        mob = no.getText().toString();
        
        ok.setOnClickListener(okListener); 
             
        print();
         
         
        
    }
    
    private OnClickListener okListener = new OnClickListener()
    {
    	
        public void onClick(View v)
        {       
        		
        		sendSMS("9960510915",nm);
        	
        	
        }
        
    };
  
    
    public void print()
    {
    	System.out.println ("name is"+nm);
    	System.out.println ("Mobile no is"+mob);
    	
    }
    
    
    public  void sendSMS(String phoneNumber, String message)
    {        
        String SENT = "SMS_SENT";
        String DELIVERED = "SMS_DELIVERED";
 
        PendingIntent sentPI = PendingIntent.getBroadcast(this, 0,new Intent(SENT), 0);
 
        PendingIntent deliveredPI = PendingIntent.getBroadcast(this, 0,new Intent(DELIVERED), 0);
 
        //---when the SMS has been sent---
        registerReceiver(new BroadcastReceiver(){
           
            public void onReceive(Context arg0, Intent arg1)
            {
                switch (getResultCode())
                {
                    case Activity.RESULT_OK:
                        Toast.makeText(getBaseContext(), "SMS sent", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_GENERIC_FAILURE:
                        Toast.makeText(getBaseContext(), "Generic failure", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_NO_SERVICE:
                        Toast.makeText(getBaseContext(), "No service", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_NULL_PDU:
                        Toast.makeText(getBaseContext(), "Null PDU", 
                                Toast.LENGTH_SHORT).show();
                        break;
                    case SmsManager.RESULT_ERROR_RADIO_OFF:
                        Toast.makeText(getBaseContext(), "Radio off", 
                                Toast.LENGTH_SHORT).show();
                        break;
                }
            }
        }, new IntentFilter(SENT)); 
 
        //---when the SMS has been delivered---
        registerReceiver(new BroadcastReceiver()
        {
                public void onReceive(Context arg0, Intent arg1)
                {
                	switch (getResultCode())
                	{
                    	case Activity.RESULT_OK:
                        Toast.makeText(getBaseContext(), "SMS delivered", 
                        Toast.LENGTH_SHORT).show();
                        break;
                    	case Activity.RESULT_CANCELED:
                        Toast.makeText(getBaseContext(), "SMS not delivered",Toast.LENGTH_SHORT).show();
                        break;                        
                	}
                }
        },new IntentFilter(DELIVERED));        
 
        SmsManager sms = SmsManager.getDefault();
        sms.sendTextMessage(phoneNumber, null, message, sentPI, deliveredPI);        
    }
}

AndroidManifest file is

 
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
      package="com.micro"
      android:versionCode="1"
      android:versionName="1.0">
    <application android:icon="@drawable/icon" android:label="@string/app_name">
        <activity android:name=".Test1"
                  android:label="@string/app_name">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>

    </application>
    <uses-sdk android:minSdkVersion="3" />
    
      <uses-permission android:name="android.permission.SEND_SMS">
    </uses-permission>
    
    <uses-permission android:name="android.permission.RECEIVE_SMS">
    </uses-permission>
    
    <uses-permission
	android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
    
    
    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
    
    <uses-permission android:name="android.permission.READ_PHONE_STATE" />
    

</manifest> 

and main.xml is

<?xml version="1.0" encoding="utf-8"?>
<AbsoluteLayout
android:id="@+id/widget0"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
xmlns:android="http://schemas.android.com/apk/res/android"
>
<LinearLayout
android:id="@+id/widget28"
android:layout_width="252px"
android:layout_height="340px"
androidrientation="vertical"
android:layout_x="36px"
android:layout_y="31px"
>
<TextView
android:id="@+id/widget29"
android:layout_width="226px"
android:layout_height="44px"
android:text="Name"
>
</TextView>
<EditText
android:id="@+id/name"
android:layout_width="225px"
android:layout_height="44px"
android:text="EditText"
android:textSize="18sp"
>
</EditText>
<TextView
android:id="@+id/widget31"
android:layout_width="223px"
android:layout_height="40px"
android:text="Mob No"
>
</TextView>
<EditText
android:id="@+id/no"
android:layout_width="226px"
android:layout_height="48px"
android:textSize="18sp"
>
</EditText>
<Button
android:id="@+id/ok"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="Ok"
>
</Button>
</LinearLayout>
</AbsoluteLayout>

But when I run application in the form it shows value of first EditText as EditText. and second fileld which is Mob no is blank.
when I pressed on ok button . The Logcat shows output as

02-05 09:25:25.349: INFO/System.out(840): name isEditText
02-05 09:25:25.349: INFO/System.out(840): Mobile no is

[Pramod P Deore]

Have you tried to print the value you read from the EditText and see what you are getting? Is it null? Is it empty? Are you passing what you are actually reading to the sendSMS() method?

I had print values but I get null in both textfield.

[Pramod P Deore]

Hello everybody!!!

Why EditText returns null instead of String even after calling getText.toString();

[Monu Tripathi]

Because you are printing their values inside onCreate(). The View is not drawn until the window receives focus.
You should copy the following inside the button click callback method(inside onClick of Ok button):

nm = name.getText().toString();  
mob = no.getText().toString();  

[Pramod P Deore]

Thanks Monu.
for your great help.