Win a copy of Re-engineering Legacy Software this week in the Refactoring forum
or Docker in Action in the Cloud/Virtualization forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Synchronize DataSource Instance?

 
kavin clain
Ranch Hand
Posts: 68
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
After configuring web.xml & context.xml I am using below code to get Connection. "DBBoard.getConnection()"

Do I need to synchronize on DataSource instance... ?

 
Peter Johnson
author
Bartender
Posts: 5852
7
Android Eclipse IDE Ubuntu
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Is there a reason why you wrote this instead of making use of the database connection pool? Using the pool is the best thing to do within a Java EE app.
 
Deepak Bala
Bartender
Posts: 6663
5
Firefox Browser Linux MyEclipse IDE
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Most containers provide their own connection pool. Tomcat for example can use commons DBCP to manage connections. Which container do you use and why dont you try to use its connection pooling mechanism ?
 
kavin clain
Ranch Hand
Posts: 68
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I am using Tomcat 5.5. How to use the connection pool & get connection & after using it how to release it?


In my project folder I created META-INF folder then I wrote context.xml inside the folder.


I was not sure but I wrote the above class(in previous message) to provide access to the datasource.

Then I did one entry in web.xml:


 
Deepak Bala
Bartender
Posts: 6663
5
Firefox Browser Linux MyEclipse IDE
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Simply close the connection after you are done. The Connection pool is responsible for reclaiming it.
 
kavin clain
Ranch Hand
Posts: 68
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thank you Deepak.

I state three things here: one the DBBoard class providing DataSource access to get Connection. and other is configuration of DataSource.

Could you please tell me is it not the correct way to use Tomcat 5.5 connection pool? If not then what is the correct way?
As in previous message by you and Peter suggesting to use Connection Pool provided by container, I think I made some mistake here the way accessing the connection pool.
 
Deepak Bala
Bartender
Posts: 6663
5
Firefox Browser Linux MyEclipse IDE
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Your first post did not mention a DBCP framework working to back the data source. Which is why we raised the point.
 
kavin clain
Ranch Hand
Posts: 68
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks again. It means the configuration part is correct.
And what about the class to getEnvironmentContext, getDataSource & getConnection. Is this implementation correct? please suggest if any changes need to incorporate!

Do I synchronize the getConnection method.

public static syncronized Connection getConnection(){...}
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic