Deleting The Whole Table problem(Index Out Of Bounds)

[michael johanson]

 public class MyTable extends JFrame {

    private JTable inventoryTable;

    private JScrollPane scroll;

    private JMenuBar menuBar;

    private JPanel panel;

    private JSplitPane divider;

    private JButton deleteRowButton;



    private DefaultTableModel model;

    private RowSorter<TableModel> sorter;

    private Dimension windowSize;

    public MyTable() {

        initializeInventory();
    }

    private void initializeInventory() {


        windowSize = Toolkit.getDefaultToolkit().getScreenSize();
        panel = new JPanel();

        deleteRowButton = new JButton("Delete Row");

        menuBar = new JMenuBar();

       
          final String[] columnNames = {"Name", "Surname", "Age"};

        final Object[][] data = {{"Jhon", "Java", "23"}, {"Stupid", "Stupido", "500"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Michael", "Winnie", "20"}, {"Winnie", "Thepoor", "23"},
                                {"Max", "Dumbass", "10"}, {"Melanie", "Martin", "500"},
                                {"Jollibe", "Mcdonalds", "15"}};

        
        model = new DefaultTableModel(data, columnNames);

       
        sorter = new TableRowSorter<TableModel>(model);

       
        deleteRowButton.setBounds(1130, 178, 150, 20);
        deleteRowButton.addActionListener(new MyActionListener());


        
        inventoryTable = new JTable(model);

        
        inventoryTable.setOpaque(false);
        inventoryTable.setFont(new Font("Monospaced", Font.BOLD, 12));
        inventoryTable.setRowSorter(sorter);
        inventoryTable.setRowSelectionAllowed(true);
        inventoryTable.setGridColor(Color.GRAY);
        inventoryTable.setPreferredScrollableViewportSize(new Dimension(500, 70));
        inventoryTable.setFillsViewportHeight(true);
        inventoryTable.setSelectionForeground(new Color(0, 160, 0));


 
        scroll = new JScrollPane(inventoryTable);
        scroll.setBounds(0, 200, 1400, 800);



        panel.setLayout(null);
        panel.add(scroll);
        panel.add(deleteRowButton);

        // set the properties and add the components of this window
        getContentPane().add(panel);
        setDefaultCloseOperation(EXIT_ON_CLOSE);
        setTitle("  Inventory Window");
        setJMenuBar(menuBar);
        setBounds(0, 0, windowSize.width, windowSize.height);
        setResizable(true);
        setVisible(true);
    }

    // class for an action listener that listens to different component's action
    private class MyActionListener implements ActionListener {

        public void actionPerformed(ActionEvent e) {

            if (deleteRowButton.equals(e.getSource())) {

                int numRows = inventoryTable.getSelectedRows().length;

                for (int x = 0; x < numRows; x++) {

                    model.removeRow(inventoryTable.getSelectedRow());
                }
            }
        }
    }

   
    public static void main(String[] args) {

        SwingUtilities.invokeLater(new Runnable() {

            public void run() {

                new MyTable();
            }
        });
    }
}   

the compiler throws me an index out of bounds, i cant find the reason why im getting this, so I tried to remove piece by piece the whole code, until I ended up in this..
but still I cant solve this problem..

when I select all the rows in the Table and press the delete button, it deletes 99% of it, and there is one remains, and an IndexOutOfBoundsException throws me, help with this please

[Rob Spoor]

1) Don't use getSelectedRow(); use the real rows that are selected.

2) If you remove a row, all later rows will have their indexes decreased by one. You can prevent this by iterating backwards:

int[] selectedRows = inventoryTable.getSelectedRows();
int numRows = selectedRows.length;
for (int i = numRows - 1; i >= 0; i--) // iterating backwards so your next indexes will not decrease
{
    model.removeRow(selectedRows[i]); // using the real selected rows
}

This code does assume that selectedRows will be sorted. If you want to make sure, call Arrays.sort before you start iterating.

[michael johanson]

thank you so much!

learned again!

[Maneesh Godbole]

"mykel java"

Please check your private messages for an important administrative matter